From 1b02775db7b553f1d848660c6aaee554996b4a6c Mon Sep 17 00:00:00 2001 From: Marcin Grzejszczak Date: Sun, 18 Nov 2018 10:28:27 +0100 Subject: [PATCH] No NPE when markers not found in index.html --- .../release/internal/docs/ReleaseTrainContentsUpdater.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/spring-cloud-release-tools-core/src/main/java/org/springframework/cloud/release/internal/docs/ReleaseTrainContentsUpdater.java b/spring-cloud-release-tools-core/src/main/java/org/springframework/cloud/release/internal/docs/ReleaseTrainContentsUpdater.java index 254663bb..6052e962 100644 --- a/spring-cloud-release-tools-core/src/main/java/org/springframework/cloud/release/internal/docs/ReleaseTrainContentsUpdater.java +++ b/spring-cloud-release-tools-core/src/main/java/org/springframework/cloud/release/internal/docs/ReleaseTrainContentsUpdater.java @@ -60,6 +60,10 @@ class ReleaseTrainContentsUpdater implements ReleaserPropertiesAware { File releaseTrainProject = this.handler.cloneSpringDocProject(); File index = new File(releaseTrainProject, "index.html"); ReleaseTrainContents contents = this.parser.parseProjectPage(index); + if (contents == null) { + log.warn("There are no markers for the index.html page - I don't really know what to do, so I'll back away"); + return null; + } String newContents = this.generator.releaseTrainContents(contents, projects); if (StringUtils.isEmpty(newContents)) { log.info("No changes to commit to the Spring Project page.");