From 1c786e25e9ac877291d0438a087aab94886f0927 Mon Sep 17 00:00:00 2001 From: Marcin Grzejszczak Date: Tue, 31 Oct 2017 17:18:32 +0100 Subject: [PATCH] Fixed notes milestones link; fixes #55 --- .../src/main/resources/templates/notes.hbs | 2 +- .../release/internal/template/TemplateGeneratorTests.java | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/spring-cloud-release-tools-core/src/main/resources/templates/notes.hbs b/spring-cloud-release-tools-core/src/main/resources/templates/notes.hbs index d89adbb3..88000e3a 100644 --- a/spring-cloud-release-tools-core/src/main/resources/templates/notes.hbs +++ b/spring-cloud-release-tools-core/src/main/resources/templates/notes.hbs @@ -2,5 +2,5 @@ {{ date }} -{{#each projects}} - {{name}} `{{version}}` {{#if closedMilestoneUrl}}([issues]({{ closedMilestoneUrl }})){{/if}} +{{#each projects}} - {{name}} `{{version}}` {{#if closedMilestoneUrl}}([issues]({{{ closedMilestoneUrl }}})){{/if}} {{/each}} \ No newline at end of file diff --git a/spring-cloud-release-tools-core/src/test/java/org/springframework/cloud/release/internal/template/TemplateGeneratorTests.java b/spring-cloud-release-tools-core/src/test/java/org/springframework/cloud/release/internal/template/TemplateGeneratorTests.java index dc6474bb..843c04bb 100644 --- a/spring-cloud-release-tools-core/src/test/java/org/springframework/cloud/release/internal/template/TemplateGeneratorTests.java +++ b/spring-cloud-release-tools-core/src/test/java/org/springframework/cloud/release/internal/template/TemplateGeneratorTests.java @@ -256,7 +256,7 @@ public class TemplateGeneratorTests { throws IOException { ProjectGitHandler handler = new ProjectGitHandler(this.props) { @Override public String milestoneUrl(ProjectVersion releaseVersion) { - return "http://foo.bar.com"; + return "http://foo.bar.com?closed=1"; } }; this.props.getPom().setBranch("Dalston.RC1"); @@ -272,8 +272,8 @@ public class TemplateGeneratorTests { then(content(generatedOutput)) .contains("# Dalston.RC1") - .contains("Spring Cloud Sleuth `1.0.0.RC1` ([issues](http://foo.bar.com))") - .contains("Spring Cloud Consul `1.0.1.RC1` ([issues](http://foo.bar.com))") + .contains("Spring Cloud Sleuth `1.0.0.RC1` ([issues](http://foo.bar.com?closed=1))") + .contains("Spring Cloud Consul `1.0.1.RC1` ([issues](http://foo.bar.com?closed=1))") .doesNotContain("Boot"); }