From 7e5d225a7e49eba3b52945861e31f3c6061a7727 Mon Sep 17 00:00:00 2001 From: Marcin Grzejszczak Date: Sat, 28 Dec 2019 14:07:45 +0100 Subject: [PATCH] Should not throw an exception from batch --- .../internal/spring/SpringBatchFlowRunner.java | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/releaser-spring/src/main/java/releaser/internal/spring/SpringBatchFlowRunner.java b/releaser-spring/src/main/java/releaser/internal/spring/SpringBatchFlowRunner.java index e46192a8..94fcef79 100644 --- a/releaser-spring/src/main/java/releaser/internal/spring/SpringBatchFlowRunner.java +++ b/releaser-spring/src/main/java/releaser/internal/spring/SpringBatchFlowRunner.java @@ -172,11 +172,7 @@ class SpringBatchFlowRunner implements FlowRunner, Closeable { } private ExecutionResult runTask(ReleaserTask releaserTask, Arguments args) { - ExecutionResult executionResult = executionResult(releaserTask, args); - if (executionResult.isFailure() && releaserTask instanceof ReleaseReleaserTask) { - throw executionResult.foundExceptions(); - } - return executionResult; + return executionResult(releaserTask, args); } private ExecutionResult executionResult(ReleaserTask releaserTask, Arguments args) { @@ -191,7 +187,10 @@ class SpringBatchFlowRunner implements FlowRunner, Closeable { catch (Exception ex) { log.error("Exception occurred while trying to execute the task [{}]", releaserTask.getClass().getSimpleName(), ex); - return ExecutionResult.failure(ex); + if (releaserTask instanceof ReleaseReleaserTask) { + return ExecutionResult.failure(ex); + } + return ExecutionResult.unstable(ex); } }