SpringCloud/spring-cloud-release-tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Switch for updating spring guides; fixes gh-101

Browse Source
This commit is contained in:
Marcin Grzejszczak
2018-10-16 18:20:01 +02:00
parent e60879924e
commit e7fffd37ba
3 changed files with 53 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
spring-cloud-release-tools-core/src/main/java/org/springframework/cloud/release/internal/ReleaserProperties.java
View File

@@ -185,6 +185,11 @@ public class ReleaserProperties implements Serializable {
*/
private Integer numberOfCheckedMilestones = 10;
/**
* If set to {@code false}, will not update Spring Guides for a release train.
*/
private boolean updateSpringGuides = true;
public String getSpringCloudReleaseGitUrl() {
return this.springCloudReleaseGitUrl;
}
@@ -265,13 +270,27 @@ public class ReleaserProperties implements Serializable {
this.fetchVersionsFromGit = fetchVersionsFromGit;
}
@Override public String toString() {
return "Git{" + "springCloudReleaseGitUrl='" + this.springCloudReleaseGitUrl + '\''
+ ", documentationUrl='" + this.documentationUrl + '\''
+ ", documentationBranch='" + this.documentationBranch + '\''
+ ", cloneDestinationDir='" + this.cloneDestinationDir + '\''
+ ", fetchVersionsFromGit=" + this.fetchVersionsFromGit
+ ", numberOfCheckedMilestones=" + this.numberOfCheckedMilestones + '}';
public boolean isUpdateSpringGuides() {
return this.updateSpringGuides;
}
public void setUpdateSpringGuides(boolean updateSpringGuides) {
this.updateSpringGuides = updateSpringGuides;
}
@Override
public String toString() {
return "Git{" +
"springCloudReleaseGitUrl='" + this.springCloudReleaseGitUrl + '\'' +
", documentationUrl='" + this.documentationUrl + '\'' +
", documentationBranch='" + this.documentationBranch + '\'' +
", updateDocumentationRepo=" + this.updateDocumentationRepo +
", cloneDestinationDir='" + this.cloneDestinationDir + '\'' +
", fetchVersionsFromGit=" + this.fetchVersionsFromGit +
", oauthToken='" + this.oauthToken + '\'' +
", numberOfCheckedMilestones=" + this.numberOfCheckedMilestones +
", updateSpringGuides=" + this.updateSpringGuides +
'}';
}
}

5
spring-cloud-release-tools-core/src/main/java/org/springframework/cloud/release/internal/git/GithubIssues.java
View File

@@ -45,6 +45,11 @@ class GithubIssues {
}
void fileIssue(Projects projects, ProjectVersion version) {
if (!this.properties.getGit().isUpdateSpringGuides()) {
log.info("Will not file an issue to Spring Guides, since the switch to do so "
+ "is off. Set [releaser.git.update-spring-guides] to [true] to change that");
return;
}
Assert.hasText(this.properties.getGit().getOauthToken(),
"You have to pass Github OAuth token for milestone closing to be operational");
// do this only for RELEASE & SR