From 248cb22c9c1605016b3af35233ff81ecec85604d Mon Sep 17 00:00:00 2001 From: Marcin Grzejszczak Date: Thu, 5 Nov 2020 10:14:57 +0100 Subject: [PATCH] Made the tests less brittle --- .../cloud/internal/GenerateReleaseTrainDocsTests.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/train-docs/src/test/java/org/springframework/cloud/internal/GenerateReleaseTrainDocsTests.java b/train-docs/src/test/java/org/springframework/cloud/internal/GenerateReleaseTrainDocsTests.java index b7ab11d..95622a3 100644 --- a/train-docs/src/test/java/org/springframework/cloud/internal/GenerateReleaseTrainDocsTests.java +++ b/train-docs/src/test/java/org/springframework/cloud/internal/GenerateReleaseTrainDocsTests.java @@ -23,6 +23,7 @@ import java.nio.file.Files; import java.util.Arrays; import java.util.List; +import org.apache.maven.model.Model; import org.assertj.core.api.BDDAssertions; import org.junit.jupiter.api.Test; @@ -33,6 +34,8 @@ public class GenerateReleaseTrainDocsTests { @Test void should_return_a_list_of_docs_modules_to_download() throws URISyntaxException { File testPom = new File(GenerateReleaseTrainDocsTests.class.getResource("/test/pom.xml").toURI()); + Model pom = PomReader.readPom(testPom); + String busVersion = pom.getProperties().getProperty("spring-cloud-bus.version"); List projects = new GenerateReleaseTrainDocs().mavenPropertiesToDocsProjects(testPom); @@ -42,7 +45,7 @@ public class GenerateReleaseTrainDocsTests { "spring-cloud-gateway", "spring-cloud-kubernetes", "spring-cloud-netflix", "spring-cloud-openfeign", "spring-cloud-security", "spring-cloud-sleuth", "spring-cloud-stream", "spring-cloud-task", "spring-cloud-vault", "spring-cloud-zookeeper", "spring-cloud-cli"); - BDDAssertions.then(projects).contains(new Project("spring-cloud-bus", "1.2.3-SNAPSHOT")); + BDDAssertions.then(projects).contains(new Project("spring-cloud-bus", busVersion)); } @Test