SpringCloud/spring-cloud-sleuth
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add an option to provide additional sleuth skip patterns through configuration

Browse Source 
without this change you always have to set the skip pattern. You can't append anything to the default pattern
with this change via the property you can provide some additional skip patterns

fixes gh-865
This commit is contained in:
Marcin Grzejszczak
2018-02-22 14:42:58 +01:00
parent 3410eea145
commit 0c42fcb809
4 changed files with 94 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
docs/src/main/asciidoc/spring-cloud-sleuth.adoc
View File

@@ -1012,7 +1012,9 @@ Features from this section can be disabled by providing the `spring.sleuth.web.e
Via the `TraceFilter` all sampled incoming requests result in creation of a Span. That Span's name is `http:` + the path to which
the request was sent. E.g. if the request was sent to `/foo/bar` then the name will be `http:/foo/bar`. You can configure which URIs you would
like to skip via the `spring.sleuth.web.skipPattern` property. If you have `ManagementServerProperties` on classpath then
its value of `contextPath` gets appended to the provided skip pattern.
its value of `contextPath` gets appended to the provided skip pattern. If you want to reuse the
Sleuth's default skip patterns and just append your own, pass those patterns via
the `spring.sleuth.web.additionalSkipPattern`.
==== HandlerInterceptor
@@ -1032,7 +1034,9 @@ If your controller returns a `Callable` or a `WebAsyncTask` Spring Cloud Sleuth
Via the `TraceWebFilter` all sampled incoming requests result in creation of a Span. That Span's name is `http:` + the path to which
the request was sent. E.g. if the request was sent to `/foo/bar` then the name will be `http:/foo/bar`. You can configure which URIs you would
like to skip via the `spring.sleuth.web.skipPattern` property. If you have `ManagementServerProperties` on classpath then
its value of `contextPath` gets appended to the provided skip pattern.
its value of `contextPath` gets appended to the provided skip pattern. If you want to reuse the
Sleuth's default skip patterns and just append your own, pass those patterns via
the `spring.sleuth.web.additionalSkipPattern`.
=== HTTP client integration
@@ -1125,7 +1129,9 @@ If you want to skip Span creation for some `@Scheduled` annotated classes you ca
`spring.sleuth.scheduled.skipPattern` with a regular expression that will match the fully qualified name of the
`@Scheduled` annotated class.
TIP: If you are using `spring-cloud-sleuth-stream` and `spring-cloud-netflix-hystrix-stream` together, Span will be created for each Hystrix metrics and sent to Zipkin. This may be annoying. You can prevent this by setting `spring.sleuth.scheduled.skipPattern=org.springframework.cloud.netflix.hystrix.stream.HystrixStreamTask`
TIP: If you are using `spring-cloud-sleuth-stream` and `spring-cloud-netflix-hystrix-stream` together, Span will be created for
each Hystrix metrics and sent to Zipkin. This may be annoying. You can prevent this by setting
`spring.sleuth.scheduled.skipPattern=org.springframework.cloud.netflix.hystrix.stream.HystrixStreamTask`
==== Executor, ExecutorService and ScheduledExecutorService