SpringCloud/spring-cloud-sleuth
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Added logging in case delegate wasn't instrumented

Browse Source
This commit is contained in:
Marcin Grzejszczak
2019-12-27 10:05:44 +01:00
parent b492868546
commit 3159f96a49
2 changed files with 375 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
spring-cloud-sleuth-core/src/main/java/org/springframework/cloud/sleuth/instrument/web/client/feign/TraceFeignObjectWrapper.java
View File

@@ -19,6 +19,8 @@ package org.springframework.cloud.sleuth.instrument.web.client.feign;
import java.lang.reflect.Field;
import feign.Client;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import org.springframework.aop.support.AopUtils;
import org.springframework.beans.factory.BeanFactory;
@@ -35,6 +37,8 @@ import org.springframework.util.ClassUtils;
*/
final class TraceFeignObjectWrapper {
private static final Log log = LogFactory.getLog(TraceFeignObjectWrapper.class);
private static final boolean ribbonPresent;
static {
@@ -71,19 +75,20 @@ final class TraceFeignObjectWrapper {
else {
LoadBalancerFeignClient client = ((LoadBalancerFeignClient) bean);
try {
Field delegate = LoadBalancerFeignClient.class.getDeclaredField("delegate");
Field delegate = LoadBalancerFeignClient.class
.getDeclaredField("delegate");
delegate.setAccessible(true);
delegate.set(client, new TraceFeignObjectWrapper(this.beanFactory).wrap(client.getDelegate()));
delegate.set(client, new TraceFeignObjectWrapper(this.beanFactory)
.wrap(client.getDelegate()));
}
catch (NoSuchFieldException | IllegalArgumentException | IllegalAccessException | SecurityException e) {
// not sure the best option here
// to fallback to only wrapping the delegate (losing any extension functionality)
// or something more catastrophic to make user aware of the problem
catch (NoSuchFieldException | IllegalArgumentException
| IllegalAccessException | SecurityException e) {
log.warn(
"Exception occurred while trying to access the delegate's field. Will fallback to default instrumentation mechanism, which means that the delegate might not be instrumented",
e);
}
return new TraceLoadBalancerFeignClient(
client,
factory(), (SpringClientFactory) clientFactory(),
this.beanFactory);
return new TraceLoadBalancerFeignClient(client, factory(),
(SpringClientFactory) clientFactory(), this.beanFactory);
}
}
else if (ribbonPresent && bean instanceof TraceLoadBalancerFeignClient) {