From 3709ed80e7f87397f9fe2b2425c9ad8e42e1d5c8 Mon Sep 17 00:00:00 2001 From: Marcin Grzejszczak Date: Tue, 6 Apr 2021 11:44:25 +0200 Subject: [PATCH] Fixed missing options for benchmarks --- .../org/springframework/cloud/sleuth/benchmarks/jmh/Pair.java | 4 ++++ .../benchmarks/jmh/stream/MicroBenchmarkStreamTests.java | 3 +-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/benchmarks/src/test/java/org/springframework/cloud/sleuth/benchmarks/jmh/Pair.java b/benchmarks/src/test/java/org/springframework/cloud/sleuth/benchmarks/jmh/Pair.java index 3a4e82416..67c0ca5fe 100644 --- a/benchmarks/src/test/java/org/springframework/cloud/sleuth/benchmarks/jmh/Pair.java +++ b/benchmarks/src/test/java/org/springframework/cloud/sleuth/benchmarks/jmh/Pair.java @@ -47,6 +47,10 @@ public class Pair { return new Pair("spring.sleuth.reactor.instrumentation-type", SleuthReactorProperties.InstrumentationType.DECORATE_ON_EACH.name()); } + public static Pair decorateQueues() { + return new Pair("spring.sleuth.reactor.instrumentation-type", SleuthReactorProperties.InstrumentationType.DECORATE_QUEUES.name()); + } + public static Pair manual() { return new Pair("spring.sleuth.reactor.instrumentation-type", SleuthReactorProperties.InstrumentationType.MANUAL.name()); } diff --git a/benchmarks/src/test/java/org/springframework/cloud/sleuth/benchmarks/jmh/stream/MicroBenchmarkStreamTests.java b/benchmarks/src/test/java/org/springframework/cloud/sleuth/benchmarks/jmh/stream/MicroBenchmarkStreamTests.java index 225821b5a..6ce4905df 100644 --- a/benchmarks/src/test/java/org/springframework/cloud/sleuth/benchmarks/jmh/stream/MicroBenchmarkStreamTests.java +++ b/benchmarks/src/test/java/org/springframework/cloud/sleuth/benchmarks/jmh/stream/MicroBenchmarkStreamTests.java @@ -163,8 +163,7 @@ public class MicroBenchmarkStreamTests { sleuthSimpleOnLast(function("simple"), Pair.onLast()), sleuthSimpleWithAroundOnQueues(function("simple_function_with_around")), noSleuthReactiveSimple(function("reactive_simple"), Pair.noSleuth()), - // TODO: CHECK WHY IT'S FAILING - // sleuthReactiveSimpleOnQueues(function("DECORATE_QUEUES")), + sleuthReactiveSimpleOnQueues(function("DECORATE_QUEUES"), Pair.decorateQueues(), integrationEnabled()), sleuthReactiveSimpleOnEach(function("DECORATE_ON_EACH"), Pair.onEach(), integrationEnabled()), sleuthReactiveSimpleManual(function("reactive_simple_manual"), Pair.manual()), sleuthReactiveSimpleNoFunctionInstrumentationManual(function("reactive_simple_manual"), Pair.manual(), integrationEnabled(), functionDisabled());