SpringCloud/spring-cloud-sleuth
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Removed the - signs from default spring var resolution

Browse Source 
with the current setup we're using the MDC's default interpolation as a default for spring var resolution (which makes no sense)
with this change we're removing the dashes

fixes gh-1396
This commit is contained in:
Marcin Grzejszczak
2019-07-26 13:05:38 +02:00
parent b59277f0ef
commit 51c367e45e
3 changed files with 19 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
spring-cloud-sleuth-samples/spring-cloud-sleuth-sample-feign/src/test/java/sample/SampleFeignApplicationTests.java
View File

@@ -16,10 +16,15 @@
package sample;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import org.assertj.core.api.BDDAssertions;
import org.junit.Rule;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.springframework.boot.test.context.SpringBootTest;
import org.springframework.boot.test.rule.OutputCapture;
import org.springframework.test.context.TestPropertySource;
import org.springframework.test.context.junit4.SpringRunner;
@@ -28,8 +33,21 @@ import org.springframework.test.context.junit4.SpringRunner;
@TestPropertySource(properties = "sample.zipkin.enabled=false")
public class SampleFeignApplicationTests {
private static final Log log = LogFactory.getLog(SampleFeignApplicationTests.class);
@Rule
public OutputCapture outputCapture = new OutputCapture();
@Test
public void contextLoads() {
}
// https://github.com/spring-cloud/spring-cloud-sleuth/issues/1396
@Test
public void should_not_pass_dash_as_default_service_name() {
log.info("HELLO");
BDDAssertions.then(this.outputCapture.toString()).doesNotContain("INFO [-,,,]");
}
}