From f5345211f2a217806f145e1ce5680cd558a30b2a Mon Sep 17 00:00:00 2001 From: Marcin Grzejszczak Date: Thu, 16 Aug 2018 17:34:04 +0200 Subject: [PATCH] Starts spans in TraceAsyncAspect; fixes gh-1061 --- .../cloud/sleuth/instrument/async/TraceAsyncAspect.java | 2 +- .../cloud/sleuth/instrument/async/TraceAsyncAspectTest.java | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/spring-cloud-sleuth-core/src/main/java/org/springframework/cloud/sleuth/instrument/async/TraceAsyncAspect.java b/spring-cloud-sleuth-core/src/main/java/org/springframework/cloud/sleuth/instrument/async/TraceAsyncAspect.java index 354521fcd..68996d2db 100644 --- a/spring-cloud-sleuth-core/src/main/java/org/springframework/cloud/sleuth/instrument/async/TraceAsyncAspect.java +++ b/spring-cloud-sleuth-core/src/main/java/org/springframework/cloud/sleuth/instrument/async/TraceAsyncAspect.java @@ -59,7 +59,7 @@ public class TraceAsyncAspect { span = this.tracer.nextSpan(); } span = span.name(spanName); - try(Tracer.SpanInScope ws = this.tracer.withSpanInScope(span)) { + try(Tracer.SpanInScope ws = this.tracer.withSpanInScope(span.start())) { span.tag(CLASS_KEY, pjp.getTarget().getClass().getSimpleName()); span.tag(METHOD_KEY, pjp.getSignature().getName()); return pjp.proceed(); diff --git a/spring-cloud-sleuth-core/src/test/java/org/springframework/cloud/sleuth/instrument/async/TraceAsyncAspectTest.java b/spring-cloud-sleuth-core/src/test/java/org/springframework/cloud/sleuth/instrument/async/TraceAsyncAspectTest.java index 7fcc34f0f..dcb1cb5d3 100644 --- a/spring-cloud-sleuth-core/src/test/java/org/springframework/cloud/sleuth/instrument/async/TraceAsyncAspectTest.java +++ b/spring-cloud-sleuth-core/src/test/java/org/springframework/cloud/sleuth/instrument/async/TraceAsyncAspectTest.java @@ -46,5 +46,6 @@ public class TraceAsyncAspectTest { BDDAssertions.then(this.reporter.getSpans()).hasSize(1); BDDAssertions.then(this.reporter.getSpans().get(0).name()).isEqualTo("foo-bar"); + BDDAssertions.then(this.reporter.getSpans().get(0).timestamp()).isPositive(); } } \ No newline at end of file