diff --git a/spring-cloud-sleuth-samples/pom.xml b/spring-cloud-sleuth-samples/pom.xml index 074216089..9427bdc47 100644 --- a/spring-cloud-sleuth-samples/pom.xml +++ b/spring-cloud-sleuth-samples/pom.xml @@ -58,41 +58,15 @@ spring-cloud-sleuth-sample-test-core ${project.version} - - org.testcontainers - docker-compose - 0.9.8 - test - - - com.fasterxml.jackson.core - jackson-databind - ${testcontainers.jackson.version} - compile - - - com.fasterxml.jackson.core - jackson-core - ${testcontainers.jackson.version} - compile - - - com.fasterxml.jackson.core - jackson-annotations - ${testcontainers.jackson.version} - compile - io.zipkin.java zipkin 0.4.4 - compile io.zipkin.java zipkin-server 0.4.4 - compile diff --git a/spring-cloud-sleuth-samples/spring-cloud-sleuth-sample-test-core/pom.xml b/spring-cloud-sleuth-samples/spring-cloud-sleuth-sample-test-core/pom.xml index 929b113ba..4b250f6dc 100644 --- a/spring-cloud-sleuth-samples/spring-cloud-sleuth-sample-test-core/pom.xml +++ b/spring-cloud-sleuth-samples/spring-cloud-sleuth-sample-test-core/pom.xml @@ -91,22 +91,6 @@ awaitility compile - - com.fasterxml.jackson.core - jackson-databind - - - com.fasterxml.jackson.core - jackson-core - - - com.fasterxml.jackson.core - jackson-annotations - - - org.testcontainers - docker-compose - io.zipkin.java zipkin diff --git a/spring-cloud-sleuth-samples/spring-cloud-sleuth-sample-zipkin/pom.xml b/spring-cloud-sleuth-samples/spring-cloud-sleuth-sample-zipkin/pom.xml index f6d12fd58..87713bf70 100644 --- a/spring-cloud-sleuth-samples/spring-cloud-sleuth-sample-zipkin/pom.xml +++ b/spring-cloud-sleuth-samples/spring-cloud-sleuth-sample-zipkin/pom.xml @@ -94,7 +94,6 @@ io.dropwizard.metrics metrics-core - ${dropwizard-metrics.version} test diff --git a/spring-cloud-sleuth-samples/spring-cloud-sleuth-sample-zipkin/src/test/java/integration/ZipkinTests.java b/spring-cloud-sleuth-samples/spring-cloud-sleuth-sample-zipkin/src/test/java/integration/ZipkinTests.java index 64e24f94d..0e60ce3d0 100644 --- a/spring-cloud-sleuth-samples/spring-cloud-sleuth-sample-zipkin/src/test/java/integration/ZipkinTests.java +++ b/spring-cloud-sleuth-samples/spring-cloud-sleuth-sample-zipkin/src/test/java/integration/ZipkinTests.java @@ -15,12 +15,12 @@ */ package integration; -import integration.ZipkinTests.WaitUntilZipkinIsUpConfig; -import lombok.SneakyThrows; -import lombok.extern.slf4j.Slf4j; +import java.util.Random; + import org.junit.Before; import org.junit.Test; import org.junit.runner.RunWith; +import org.springframework.beans.factory.annotation.Value; import org.springframework.boot.test.SpringApplicationConfiguration; import org.springframework.boot.test.WebIntegrationTest; import org.springframework.cloud.sleuth.metric.SpanReporterService; @@ -31,26 +31,29 @@ import org.springframework.context.annotation.Bean; import org.springframework.context.annotation.Configuration; import org.springframework.test.context.TestPropertySource; import org.springframework.test.context.junit4.SpringJUnit4ClassRunner; + +import integration.ZipkinTests.WaitUntilZipkinIsUpConfig; +import lombok.SneakyThrows; +import lombok.extern.slf4j.Slf4j; import sample.SampleZipkinApplication; import tools.AbstractIntegrationTest; import zipkin.server.ZipkinServer; -import java.util.Random; - @RunWith(SpringJUnit4ClassRunner.class) @SpringApplicationConfiguration(classes = { WaitUntilZipkinIsUpConfig.class, SampleZipkinApplication.class }) @WebIntegrationTest -@TestPropertySource(properties = "sample.zipkin.enabled=true") +@TestPropertySource(properties = {"sample.zipkin.enabled=true"}) public class ZipkinTests extends AbstractIntegrationTest { private static final String APP_NAME = "testsleuthzipkin"; - private static int port = 3380; - private static String sampleAppUrl = "http://localhost:" + port; + @Value("${local.server.port}") + private int port = 3380; + private String sampleAppUrl = "http://localhost:" + this.port; @Before public void setup() { - ZipkinServer.main(new String[] { "server.port=9411" }); + ZipkinServer.main(new String[] { "--server.port=9411" }); await().until(zipkinQueryServerIsUp()); } @@ -59,7 +62,7 @@ public class ZipkinTests extends AbstractIntegrationTest { long traceId = new Random().nextLong(); await().until(httpMessageWithTraceIdInHeadersIsSuccessfullySent( - sampleAppUrl + "/hi2", traceId)); + this.sampleAppUrl + "/hi2", traceId)); await().until(allSpansWereRegisteredInZipkinWithTraceIdEqualTo(traceId)); }