diff --git a/spring-cloud-sleuth-samples/spring-cloud-sleuth-sample-messaging/pom.xml b/spring-cloud-sleuth-samples/spring-cloud-sleuth-sample-messaging/pom.xml index e24ff63bd..bcd74e57d 100644 --- a/spring-cloud-sleuth-samples/spring-cloud-sleuth-sample-messaging/pom.xml +++ b/spring-cloud-sleuth-samples/spring-cloud-sleuth-sample-messaging/pom.xml @@ -76,10 +76,6 @@ org.springframework.boot spring-boot-starter-actuator - - com.github.kristofa - brave-core - org.springframework.boot spring-boot-starter-test diff --git a/spring-cloud-sleuth-samples/spring-cloud-sleuth-sample-messaging/src/main/java/sample/SampleMessagingApplication.java b/spring-cloud-sleuth-samples/spring-cloud-sleuth-sample-messaging/src/main/java/sample/SampleMessagingApplication.java index d4972b174..74d12d5b7 100644 --- a/spring-cloud-sleuth-samples/spring-cloud-sleuth-sample-messaging/src/main/java/sample/SampleMessagingApplication.java +++ b/spring-cloud-sleuth-samples/spring-cloud-sleuth-sample-messaging/src/main/java/sample/SampleMessagingApplication.java @@ -19,17 +19,12 @@ package sample; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.boot.SpringApplication; import org.springframework.boot.autoconfigure.SpringBootApplication; -import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty; -import org.springframework.context.annotation.Bean; import org.springframework.context.annotation.EnableAspectJAutoProxy; import org.springframework.integration.annotation.IntegrationComponentScan; import org.springframework.scheduling.annotation.EnableAsync; import org.springframework.web.bind.annotation.RequestMapping; import org.springframework.web.bind.annotation.RestController; -import com.github.kristofa.brave.LoggingSpanCollector; -import com.github.kristofa.brave.SpanCollector; - /** * @author Spencer Gibb */ @@ -68,11 +63,4 @@ public class SampleMessagingApplication { SpringApplication.run(SampleMessagingApplication.class, args); } - // Use this for debugging (or if there is no Zipkin server running on port 9411) - @Bean - @ConditionalOnProperty(value="sample.zipkin.enabled", havingValue="false") - public SpanCollector spanCollector() { - return new LoggingSpanCollector(); - } - } diff --git a/spring-cloud-sleuth-samples/spring-cloud-sleuth-sample-zipkin/pom.xml b/spring-cloud-sleuth-samples/spring-cloud-sleuth-sample-zipkin/pom.xml index 516b2ac6c..aebf1e0a2 100644 --- a/spring-cloud-sleuth-samples/spring-cloud-sleuth-sample-zipkin/pom.xml +++ b/spring-cloud-sleuth-samples/spring-cloud-sleuth-sample-zipkin/pom.xml @@ -82,16 +82,6 @@ zipkin-server test - - com.github.kristofa - brave-core - test - - - io.dropwizard.metrics - metrics-core - test - diff --git a/spring-cloud-sleuth-samples/spring-cloud-sleuth-sample-zipkin/src/test/java/integration/ZipkinTests.java b/spring-cloud-sleuth-samples/spring-cloud-sleuth-sample-zipkin/src/test/java/integration/ZipkinTests.java index ec7fd409e..baaa2a5b1 100644 --- a/spring-cloud-sleuth-samples/spring-cloud-sleuth-sample-zipkin/src/test/java/integration/ZipkinTests.java +++ b/spring-cloud-sleuth-samples/spring-cloud-sleuth-sample-zipkin/src/test/java/integration/ZipkinTests.java @@ -22,6 +22,8 @@ import org.junit.Test; import org.junit.runner.RunWith; import org.slf4j.Logger; import org.springframework.beans.factory.annotation.Value; +import org.springframework.boot.SpringApplication; +import org.springframework.boot.autoconfigure.SpringBootApplication; import org.springframework.boot.test.SpringApplicationConfiguration; import org.springframework.boot.test.WebIntegrationTest; import org.springframework.cloud.sleuth.metric.SpanReporterService; @@ -36,7 +38,7 @@ import org.springframework.test.context.junit4.SpringJUnit4ClassRunner; import integration.ZipkinTests.WaitUntilZipkinIsUpConfig; import sample.SampleZipkinApplication; import tools.AbstractIntegrationTest; -import zipkin.server.ZipkinServer; +import zipkin.server.EnableZipkinServer; @RunWith(SpringJUnit4ClassRunner.class) @SpringApplicationConfiguration(classes = { WaitUntilZipkinIsUpConfig.class, @@ -103,4 +105,12 @@ public class ZipkinTests extends AbstractIntegrationTest { spanReporterService); } } + + @SpringBootApplication + @EnableZipkinServer + protected static class ZipkinServer { + public static void main(String[] args) { + SpringApplication.run(ZipkinServer.class, args); + } + } }