From 94ed8cfe4b3fd796e6526f2f8716f09432d9a978 Mon Sep 17 00:00:00 2001 From: Marcin Grzejszczak Date: Mon, 9 May 2016 17:28:58 +0200 Subject: [PATCH] Fixed tests with a workaround had to add @EnableIntegration. Will remove it once https://github.com/spring-projects/spring-boot/issues/5901 is resolved --- .../TraceChannelInterceptorTests.java | 3 +++ ...extPropagationChannelInterceptorTests.java | 3 +++ .../MessagingApplicationTests.java | 20 ++++++++++--------- 3 files changed, 17 insertions(+), 9 deletions(-) diff --git a/spring-cloud-sleuth-core/src/test/java/org/springframework/cloud/sleuth/instrument/messaging/TraceChannelInterceptorTests.java b/spring-cloud-sleuth-core/src/test/java/org/springframework/cloud/sleuth/instrument/messaging/TraceChannelInterceptorTests.java index 4511186b1..cf37894dd 100644 --- a/spring-cloud-sleuth-core/src/test/java/org/springframework/cloud/sleuth/instrument/messaging/TraceChannelInterceptorTests.java +++ b/spring-cloud-sleuth-core/src/test/java/org/springframework/cloud/sleuth/instrument/messaging/TraceChannelInterceptorTests.java @@ -34,6 +34,7 @@ import org.springframework.cloud.sleuth.util.ArrayListSpanAccumulator; import org.springframework.context.annotation.Bean; import org.springframework.context.annotation.Configuration; import org.springframework.integration.channel.DirectChannel; +import org.springframework.integration.config.EnableIntegration; import org.springframework.integration.core.MessagingTemplate; import org.springframework.integration.support.MessageBuilder; import org.springframework.messaging.Message; @@ -178,6 +179,8 @@ public class TraceChannelInterceptorTests implements MessageHandler { @Configuration @EnableAutoConfiguration + // TODO: Remove once https://github.com/spring-projects/spring-boot/issues/5901 is resolved + @EnableIntegration static class App { @Bean diff --git a/spring-cloud-sleuth-core/src/test/java/org/springframework/cloud/sleuth/instrument/messaging/TraceContextPropagationChannelInterceptorTests.java b/spring-cloud-sleuth-core/src/test/java/org/springframework/cloud/sleuth/instrument/messaging/TraceContextPropagationChannelInterceptorTests.java index 74c38d0bf..3c9d6455c 100644 --- a/spring-cloud-sleuth-core/src/test/java/org/springframework/cloud/sleuth/instrument/messaging/TraceContextPropagationChannelInterceptorTests.java +++ b/spring-cloud-sleuth-core/src/test/java/org/springframework/cloud/sleuth/instrument/messaging/TraceContextPropagationChannelInterceptorTests.java @@ -32,6 +32,7 @@ import org.springframework.cloud.sleuth.trace.TestSpanContextHolder; import org.springframework.context.annotation.Bean; import org.springframework.context.annotation.Configuration; import org.springframework.integration.channel.QueueChannel; +import org.springframework.integration.config.EnableIntegration; import org.springframework.integration.support.MessageBuilder; import org.springframework.messaging.Message; import org.springframework.messaging.PollableChannel; @@ -91,6 +92,8 @@ public class TraceContextPropagationChannelInterceptorTests { @Configuration @EnableAutoConfiguration + // TODO: Remove once https://github.com/spring-projects/spring-boot/issues/5901 is resolved + @EnableIntegration static class App { @Bean diff --git a/spring-cloud-sleuth-samples/spring-cloud-sleuth-sample-messaging/src/test/java/integration/MessagingApplicationTests.java b/spring-cloud-sleuth-samples/spring-cloud-sleuth-sample-messaging/src/test/java/integration/MessagingApplicationTests.java index 516299e70..51a0097e0 100644 --- a/spring-cloud-sleuth-samples/spring-cloud-sleuth-sample-messaging/src/test/java/integration/MessagingApplicationTests.java +++ b/spring-cloud-sleuth-samples/spring-cloud-sleuth-sample-messaging/src/test/java/integration/MessagingApplicationTests.java @@ -15,13 +15,7 @@ */ package integration; -import java.util.Collection; -import java.util.Collections; -import java.util.List; -import java.util.Optional; -import java.util.Random; -import java.util.stream.Collectors; - +import integration.MessagingApplicationTests.IntegrationSpanCollectorConfig; import org.junit.After; import org.junit.Test; import org.junit.runner.RunWith; @@ -31,15 +25,21 @@ import org.springframework.boot.test.WebIntegrationTest; import org.springframework.cloud.sleuth.zipkin.ZipkinSpanReporter; import org.springframework.context.annotation.Bean; import org.springframework.context.annotation.Configuration; +import org.springframework.integration.config.EnableIntegration; import org.springframework.test.context.TestPropertySource; import org.springframework.test.context.junit4.SpringJUnit4ClassRunner; - -import integration.MessagingApplicationTests.IntegrationSpanCollectorConfig; import sample.SampleMessagingApplication; import tools.AbstractIntegrationTest; import zipkin.Constants; import zipkin.Span; +import java.util.Collection; +import java.util.Collections; +import java.util.List; +import java.util.Optional; +import java.util.Random; +import java.util.stream.Collectors; + import static org.assertj.core.api.BDDAssertions.then; @RunWith(SpringJUnit4ClassRunner.class) @@ -160,6 +160,8 @@ public class MessagingApplicationTests extends AbstractIntegrationTest { } @Configuration + // TODO: Remove once https://github.com/spring-projects/spring-boot/issues/5901 is resolved + @EnableIntegration public static class IntegrationSpanCollectorConfig { @Bean ZipkinSpanReporter integrationTestZipkinSpanReporter() {