From 9c93d678d0f6279c9119fd794fcb07be26dadeba Mon Sep 17 00:00:00 2001 From: Marcin Grzejszczak Date: Wed, 12 Feb 2020 11:18:31 +0100 Subject: [PATCH] Removed Hystrix from docs --- README.adoc | 2 ++ docs/src/main/asciidoc/_configprops.adoc | 6 ++--- .../main/asciidoc/spring-cloud-sleuth.adoc | 27 ------------------- 3 files changed, 4 insertions(+), 31 deletions(-) diff --git a/README.adoc b/README.adoc index 71493d83d..23df48ae1 100644 --- a/README.adoc +++ b/README.adoc @@ -888,6 +888,7 @@ Checkstyle rules are *disabled by default*. To add checkstyle to your project ju spring-javaformat-maven-plugin <5> + org.apache.maven.plugins maven-checkstyle-plugin @@ -895,6 +896,7 @@ Checkstyle rules are *disabled by default*. To add checkstyle to your project ju <5> + org.apache.maven.plugins maven-checkstyle-plugin diff --git a/docs/src/main/asciidoc/_configprops.adoc b/docs/src/main/asciidoc/_configprops.adoc index 2692e0e3c..2b16d58b0 100644 --- a/docs/src/main/asciidoc/_configprops.adoc +++ b/docs/src/main/asciidoc/_configprops.adoc @@ -12,11 +12,9 @@ |spring.sleuth.feign.processor.enabled | true | Enable post processor that wraps Feign Context in its tracing representations. |spring.sleuth.grpc.enabled | true | Enable span information propagation when using GRPC. |spring.sleuth.http.enabled | true | -|spring.sleuth.http.legacy.enabled | false | Enables the legacy Sleuth setup. -|spring.sleuth.hystrix.strategy.enabled | true | Enable custom HystrixConcurrencyStrategy that wraps all Callable instances into their Sleuth representative - the TraceCallable. -|spring.sleuth.hystrix.strategy.passthrough | false | When enabled the tracing information is passed to the Hystrix execution threads but spans are not created for each execution. +|spring.sleuth.http.legacy.enabled | false | |spring.sleuth.integration.enabled | true | Enable Spring Integration sleuth instrumentation. -|spring.sleuth.integration.patterns | [!hystrixStreamOutput*, *] | An array of patterns against which channel names will be matched. @see org.springframework.integration.config.GlobalChannelInterceptor#patterns() Defaults to any channel name not matching the Hystrix Stream channel name. +|spring.sleuth.integration.patterns | [!hystrixStreamOutput*, *, !channel*] | An array of patterns against which channel names will be matched. @see org.springframework.integration.config.GlobalChannelInterceptor#patterns() Defaults to any channel name not matching the Hystrix Stream and functional Stream channel names. |spring.sleuth.integration.websockets.enabled | true | Enable tracing for WebSockets. |spring.sleuth.keys.http.headers | | Additional headers that should be added as tags if they exist. If the header value is multi-valued, the tag value will be a comma-separated, single-quoted list. |spring.sleuth.keys.http.prefix | http. | Prefix for header names if they are added as tags. diff --git a/docs/src/main/asciidoc/spring-cloud-sleuth.adoc b/docs/src/main/asciidoc/spring-cloud-sleuth.adoc index 40e8d9c50..ac7b75d08 100644 --- a/docs/src/main/asciidoc/spring-cloud-sleuth.adoc +++ b/docs/src/main/asciidoc/spring-cloud-sleuth.adoc @@ -1087,33 +1087,6 @@ That way, you ensure that a new span is created and closed for each execution. If you have Spring Cloud CircuitBreaker on the classpath, we will wrap the passed command `Supplier` and the fallback `Function` in its trace representations. In order to disable this instrumentation set `spring.sleuth.circuitbreaker.enabled` to `false`. - -=== Hystrix - -==== Custom Concurrency Strategy - -We register a custom https://github.com/Netflix/Hystrix/wiki/Plugins#concurrencystrategy[`HystrixConcurrencyStrategy`] called `TraceCallable` that wraps all `Callable` instances in their Sleuth representative. -The strategy either starts or continues a span, depending on whether tracing was already going on before the Hystrix command was called. -Optionally, you can set `spring.sleuth.hystrix.strategy.passthrough` to `true` to just propagate the trace context to the Hystrix execution thread if you don't wish to start a new span. -To disable the custom Hystrix Concurrency Strategy, set the `spring.sleuth.hystrix.strategy.enabled` to `false`. - -==== Manual Command setting - -Assume that you have the following `HystrixCommand`: - -[source,java] ----- -include::{project-root}/spring-cloud-sleuth-core/src/test/java/org/springframework/cloud/sleuth/instrument/hystrix/TraceCommandTests.java[tags=hystrix_command,indent=0] ----- - -To pass the tracing information, you have to wrap the same logic in the Sleuth version of the `HystrixCommand`, which is called -`TraceCommand`, as shown in the following example: - -[source,java] ----- -include::{project-root}/spring-cloud-sleuth-core/src/test/java/org/springframework/cloud/sleuth/instrument/hystrix/TraceCommandTests.java[tags=trace_hystrix_command,indent=0] ----- - === RxJava We registering a custom https://github.com/ReactiveX/RxJava/wiki/Plugins#rxjavaschedulershook[`RxJavaSchedulersHook`] that wraps all `Action0` instances in their Sleuth representative, which is called `TraceAction`.