From 9ed2e87fa033d13b8a20b11d773fd5410e41f7a3 Mon Sep 17 00:00:00 2001 From: Marcin Grzejszczak Date: Mon, 7 Aug 2017 22:52:41 +0200 Subject: [PATCH] Trying to fix the build --- pom.xml | 13 +++++++++++++ .../reactor/TraceReactorAutoConfiguration.java | 10 ++++++++-- .../instrument/reactor/SpanSubscriberTests.java | 3 +++ 3 files changed, 24 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 2b03f2271..8e66140ef 100644 --- a/pom.xml +++ b/pom.xml @@ -179,6 +179,18 @@ pom import + + org.springframework + spring-core + ${spring.version} + + + org.springframework + spring-framework-bom + ${spring.version} + import + pom + org.springframework.boot spring-boot-dependencies @@ -255,6 +267,7 @@ Bismuth-BUILD-SNAPSHOT 2.0.0.BUILD-SNAPSHOT + 5.0.0.BUILD-SNAPSHOT diff --git a/spring-cloud-sleuth-core/src/main/java/org/springframework/cloud/sleuth/instrument/reactor/TraceReactorAutoConfiguration.java b/spring-cloud-sleuth-core/src/main/java/org/springframework/cloud/sleuth/instrument/reactor/TraceReactorAutoConfiguration.java index fd5626184..c79291196 100644 --- a/spring-cloud-sleuth-core/src/main/java/org/springframework/cloud/sleuth/instrument/reactor/TraceReactorAutoConfiguration.java +++ b/spring-cloud-sleuth-core/src/main/java/org/springframework/cloud/sleuth/instrument/reactor/TraceReactorAutoConfiguration.java @@ -1,8 +1,9 @@ package org.springframework.cloud.sleuth.instrument.reactor; -import javax.annotation.PostConstruct; import java.util.concurrent.ScheduledExecutorService; import java.util.function.Supplier; +import javax.annotation.PostConstruct; +import javax.annotation.PreDestroy; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.boot.autoconfigure.AutoConfigureAfter; @@ -16,7 +17,6 @@ import org.springframework.cloud.sleuth.Tracer; import org.springframework.cloud.sleuth.instrument.async.TraceableScheduledExecutorService; import org.springframework.cloud.sleuth.instrument.web.TraceWebFluxAutoConfiguration; import org.springframework.context.annotation.Configuration; - import reactor.core.publisher.Hooks; import reactor.core.publisher.Mono; import reactor.core.scheduler.Schedulers; @@ -57,5 +57,11 @@ public class TraceReactorAutoConfiguration { } }); } + + @PreDestroy + public void cleanupHooks() { + Hooks.resetOnLastOperator(); + Schedulers.resetFactory(); + } } } \ No newline at end of file diff --git a/spring-cloud-sleuth-core/src/test/java/org/springframework/cloud/sleuth/instrument/reactor/SpanSubscriberTests.java b/spring-cloud-sleuth-core/src/test/java/org/springframework/cloud/sleuth/instrument/reactor/SpanSubscriberTests.java index 58a6eacb1..fc769f8bb 100644 --- a/spring-cloud-sleuth-core/src/test/java/org/springframework/cloud/sleuth/instrument/reactor/SpanSubscriberTests.java +++ b/spring-cloud-sleuth-core/src/test/java/org/springframework/cloud/sleuth/instrument/reactor/SpanSubscriberTests.java @@ -5,8 +5,10 @@ import java.util.concurrent.atomic.AtomicReference; import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; import org.awaitility.Awaitility; +import org.junit.After; import org.junit.AfterClass; import org.junit.Before; +import org.junit.BeforeClass; import org.junit.Test; import org.junit.runner.RunWith; import org.reactivestreams.Publisher; @@ -18,6 +20,7 @@ import org.springframework.cloud.sleuth.Sampler; import org.springframework.cloud.sleuth.Span; import org.springframework.cloud.sleuth.Tracer; import org.springframework.cloud.sleuth.sampler.AlwaysSampler; +import org.springframework.cloud.sleuth.trace.TestSpanContextHolder; import org.springframework.cloud.sleuth.util.ExceptionUtils; import org.springframework.context.annotation.Bean; import org.springframework.context.annotation.Configuration;