From b6054bfbe485cdf6fe5454d780fe8752ec631d80 Mon Sep 17 00:00:00 2001 From: Adrian Cole Date: Mon, 25 Jan 2016 09:24:54 +0100 Subject: [PATCH] Clarifies configuration in zipkin sample --- .../src/main/java/sample/SampleZipkinApplication.java | 5 +++-- .../src/main/resources/application.yml | 9 +++++++-- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/spring-cloud-sleuth-samples/spring-cloud-sleuth-sample-zipkin/src/main/java/sample/SampleZipkinApplication.java b/spring-cloud-sleuth-samples/spring-cloud-sleuth-sample-zipkin/src/main/java/sample/SampleZipkinApplication.java index 03b942f3f..903b5eda1 100644 --- a/spring-cloud-sleuth-samples/spring-cloud-sleuth-sample-zipkin/src/main/java/sample/SampleZipkinApplication.java +++ b/spring-cloud-sleuth-samples/spring-cloud-sleuth-sample-zipkin/src/main/java/sample/SampleZipkinApplication.java @@ -36,8 +36,9 @@ import org.springframework.scheduling.annotation.EnableAsync; @Slf4j public class SampleZipkinApplication { - public static final String CLIENT_NAME = "testApp"; - + /** + * Sleuth will not report trace data unless you define a sampler like below. + */ @Bean public Sampler defaultSampler() { return new AlwaysSampler(); diff --git a/spring-cloud-sleuth-samples/spring-cloud-sleuth-sample-zipkin/src/main/resources/application.yml b/spring-cloud-sleuth-samples/spring-cloud-sleuth-sample-zipkin/src/main/resources/application.yml index 0c4dab528..4bca4d767 100644 --- a/spring-cloud-sleuth-samples/spring-cloud-sleuth-sample-zipkin/src/main/resources/application.yml +++ b/spring-cloud-sleuth-samples/spring-cloud-sleuth-sample-zipkin/src/main/resources/application.yml @@ -3,8 +3,13 @@ server: spring: application: - name: testSleuthZipkin + # This ends up as the service name in zipkin + name: my-boot + zipkin: + # Uncomment to send to zipkin, replacing 192.168.99.100 with your docker-machine's IP address + # baseUrl: http://192.168.99.100:9411/ sample: zipkin: - enabled: false \ No newline at end of file + # When enabled=false, traces log to the console. Comment to send to zipkin + enabled: false