From 6a07a3417d445c92039e91f9f1185d8b5064a799 Mon Sep 17 00:00:00 2001 From: Marcin Grzejszczak Date: Mon, 21 Oct 2019 15:50:45 +0200 Subject: [PATCH] Fixed checkstyle --- .../TraceWebClientBeanPostProcessor.java | 5 ++- .../client/integration/WebClientTests.java | 36 ++++++++++++------- 2 files changed, 25 insertions(+), 16 deletions(-) diff --git a/spring-cloud-sleuth-core/src/main/java/org/springframework/cloud/sleuth/instrument/web/client/TraceWebClientBeanPostProcessor.java b/spring-cloud-sleuth-core/src/main/java/org/springframework/cloud/sleuth/instrument/web/client/TraceWebClientBeanPostProcessor.java index 2bf50a245..6b4fa85a1 100644 --- a/spring-cloud-sleuth-core/src/main/java/org/springframework/cloud/sleuth/instrument/web/client/TraceWebClientBeanPostProcessor.java +++ b/spring-cloud-sleuth-core/src/main/java/org/springframework/cloud/sleuth/instrument/web/client/TraceWebClientBeanPostProcessor.java @@ -362,9 +362,8 @@ final class TraceExchangeFilterFunction implements ExchangeFilterFunction { "Non positive status code was returned from the call. Will close the span [" + this.span + "]"); } - throwable = new RestClientException("Status code of the response is [" - + statusCode - + "]"); + throwable = new RestClientException( + "Status code of the response is [" + statusCode + "]"); } handleReceive(this.span, this.ws, clientResponse, throwable); } diff --git a/spring-cloud-sleuth-core/src/test/java/org/springframework/cloud/sleuth/instrument/web/client/integration/WebClientTests.java b/spring-cloud-sleuth-core/src/test/java/org/springframework/cloud/sleuth/instrument/web/client/integration/WebClientTests.java index 723d1b8c2..776e2b2e8 100644 --- a/spring-cloud-sleuth-core/src/test/java/org/springframework/cloud/sleuth/instrument/web/client/integration/WebClientTests.java +++ b/spring-cloud-sleuth-core/src/test/java/org/springframework/cloud/sleuth/instrument/web/client/integration/WebClientTests.java @@ -16,6 +16,19 @@ package org.springframework.cloud.sleuth.instrument.web.client.integration; +import java.util.ArrayList; +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.Optional; +import java.util.concurrent.Future; +import java.util.concurrent.TimeUnit; +import java.util.concurrent.atomic.AtomicReference; +import java.util.stream.Collectors; + +import javax.servlet.http.HttpServletRequest; + import brave.Span; import brave.Tracer; import brave.Tracing; @@ -36,8 +49,17 @@ import org.apache.http.impl.client.HttpClientBuilder; import org.apache.http.impl.nio.client.CloseableHttpAsyncClient; import org.apache.http.impl.nio.client.HttpAsyncClientBuilder; import org.awaitility.Awaitility; -import org.junit.*; +import org.junit.After; +import org.junit.Before; +import org.junit.ClassRule; +import org.junit.Rule; +import org.junit.Test; import org.junit.runner.RunWith; +import reactor.netty.http.client.HttpClient; +import reactor.netty.http.client.HttpClientResponse; +import zipkin2.Annotation; +import zipkin2.reporter.Reporter; + import org.springframework.beans.factory.annotation.Autowired; import org.springframework.beans.factory.annotation.Value; import org.springframework.boot.autoconfigure.EnableAutoConfiguration; @@ -70,19 +92,7 @@ import org.springframework.web.bind.annotation.RequestMethod; import org.springframework.web.bind.annotation.RestController; import org.springframework.web.client.HttpClientErrorException; import org.springframework.web.client.RestTemplate; -import org.springframework.web.reactive.function.client.UnknownHttpStatusCodeException; import org.springframework.web.reactive.function.client.WebClient; -import reactor.netty.http.client.HttpClient; -import reactor.netty.http.client.HttpClientResponse; -import zipkin2.Annotation; -import zipkin2.reporter.Reporter; - -import javax.servlet.http.HttpServletRequest; -import java.util.*; -import java.util.concurrent.Future; -import java.util.concurrent.TimeUnit; -import java.util.concurrent.atomic.AtomicReference; -import java.util.stream.Collectors; import static org.assertj.core.api.Assertions.fail; import static org.assertj.core.api.BDDAssertions.then;