diff --git a/benchmarks/pom.xml b/benchmarks/pom.xml
index b89d325b3..b0576968e 100644
--- a/benchmarks/pom.xml
+++ b/benchmarks/pom.xml
@@ -34,7 +34,8 @@
1.8
1.8
2.1.10.RELEASE
- 5.8.0
+ 2.3.0.BUILD-SNAPSHOT
+ 5.9.2
3.11.0
diff --git a/pom.xml b/pom.xml
index 4d826eb1d..f4c4ea03b 100644
--- a/pom.xml
+++ b/pom.xml
@@ -264,7 +264,7 @@
Fishtown.SR4
2.1.5.BUILD-SNAPSHOT
2.1.5.BUILD-SNAPSHOT
- 5.8.0
+ 5.9.2
2.1.2.RELEASE
diff --git a/spring-cloud-sleuth-core/src/test/java/org/springframework/cloud/sleuth/instrument/messaging/JmsTracingConfigurationTest.java b/spring-cloud-sleuth-core/src/test/java/org/springframework/cloud/sleuth/instrument/messaging/JmsTracingConfigurationTest.java
index 13fe6e1e8..4f5e3ce41 100644
--- a/spring-cloud-sleuth-core/src/test/java/org/springframework/cloud/sleuth/instrument/messaging/JmsTracingConfigurationTest.java
+++ b/spring-cloud-sleuth-core/src/test/java/org/springframework/cloud/sleuth/instrument/messaging/JmsTracingConfigurationTest.java
@@ -32,13 +32,11 @@ import javax.jms.XAConnectionFactory;
import javax.resource.spi.ResourceAdapter;
import brave.Tracing;
-import brave.internal.HexCodec;
import brave.propagation.CurrentTraceContext;
import brave.propagation.TraceContext;
import org.apache.activemq.ra.ActiveMQActivationSpec;
import org.apache.activemq.ra.ActiveMQResourceAdapter;
import org.junit.Test;
-import zipkin2.Annotation;
import zipkin2.Span;
import org.springframework.beans.factory.annotation.Autowired;
@@ -281,8 +279,6 @@ public class JmsTracingConfigurationTest {
EurekaClientAutoConfiguration.class })
class JmsTestTracingConfiguration {
- static final String CONTEXT_LEAK = "context.leak";
-
/**
* When testing servers or asynchronous clients, spans are reported on a worker
* thread. In order to read them on the main thread, we use a concurrent queue. As
@@ -304,34 +300,14 @@ class JmsTestTracingConfiguration {
return () -> {
Span result = this.spans.poll(3, TimeUnit.SECONDS);
assertThat(result).withFailMessage("Span was not reported").isNotNull();
- assertThat(result.annotations()).extracting(Annotation::value)
- .doesNotContain(CONTEXT_LEAK);
return result;
};
}
@Bean
Tracing tracing(CurrentTraceContext currentTraceContext) {
- return Tracing.newBuilder().spanReporter(s -> {
- // make sure the context was cleared prior to finish.. no leaks!
- TraceContext current = currentTraceContext.get();
- boolean contextLeak = false;
- if (current != null) {
- // add annotation in addition to throwing, in case we are off the main
- // thread
- if (HexCodec.toLowerHex(current.spanId()).equals(s.id())) {
- s = s.toBuilder().addAnnotation(s.timestampAsLong(), CONTEXT_LEAK)
- .build();
- contextLeak = true;
- }
- }
- this.spans.add(s);
- // throw so that we can see the path to the code that leaked the context
- if (contextLeak) {
- throw new AssertionError(
- CONTEXT_LEAK + " on " + Thread.currentThread().getName());
- }
- }).currentTraceContext(currentTraceContext).build();
+ return Tracing.newBuilder().spanReporter(spans::add)
+ .currentTraceContext(currentTraceContext).build();
}
}
diff --git a/spring-cloud-sleuth-samples/pom.xml b/spring-cloud-sleuth-samples/pom.xml
index 3657f9ea2..18c17a060 100644
--- a/spring-cloud-sleuth-samples/pom.xml
+++ b/spring-cloud-sleuth-samples/pom.xml
@@ -73,7 +73,7 @@
io.zipkin.zipkin2
zipkin
- 2.17.0
+ 2.19.3