From e2e1cdb336ec89b26fcd22116510c2d5eee6924e Mon Sep 17 00:00:00 2001 From: Jan van den Berg Date: Thu, 5 Sep 2019 11:05:48 +0200 Subject: [PATCH] Fix TraceableExecutorService (#1437) TraceableExecutorService swallows Exception because `execute` submits a Runnable and ignores the Future's result. It should call the delegates `execute` method instead of the `submit`. --- .../cloud/sleuth/instrument/async/TraceableExecutorService.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spring-cloud-sleuth-core/src/main/java/org/springframework/cloud/sleuth/instrument/async/TraceableExecutorService.java b/spring-cloud-sleuth-core/src/main/java/org/springframework/cloud/sleuth/instrument/async/TraceableExecutorService.java index 833fd8644..1f14f19ce 100644 --- a/spring-cloud-sleuth-core/src/main/java/org/springframework/cloud/sleuth/instrument/async/TraceableExecutorService.java +++ b/spring-cloud-sleuth-core/src/main/java/org/springframework/cloud/sleuth/instrument/async/TraceableExecutorService.java @@ -63,7 +63,7 @@ public class TraceableExecutorService implements ExecutorService { @Override public void execute(Runnable command) { - this.delegate.submit(ContextUtil.isContextInCreation(this.beanFactory) ? command + this.delegate.execute(ContextUtil.isContextInCreation(this.beanFactory) ? command : new TraceRunnable(tracing(), spanNamer(), command, this.spanName)); }