Commit Graph

1306 Commits

Author SHA1 Message Date
Adrian Cole
8431588db7 Removes deprecations from server code (#1534) 2020-01-24 08:42:05 +08:00
Adrian Cole
e5227ba090 Moves client instrumentation off deprecated Brave code (#1532) 2020-01-22 14:23:47 +01:00
Adrian Cole
8a4002d288 Cleanups of build including upgrade of Brave (#1530)
In efforts to dig deep into benchmarks, I noticed we were a bit out of
date on Brave. Then, noticed some other artifacts could be bumped
safely. Finally, a find/replace on http/https was over zealous and
tripped up XML.

One change to test expectations and Brave is explained here:
https://github.com/openzipkin/brave/blob/master/instrumentation/RATIONALE.md#calling-spanfinish-while-the-context-is-in-scope
2020-01-22 19:31:50 +08:00
Olga Maciaszek-Sharma
d7b7e81235 Gh 1528 instrument feign sc loadbalancer client (#1531)
* Add optional SC LoadBalancer dependency. Create TraceFeignBlockingLoadBalancerClient.

* Instrument Spring Cloud LoadBalancer in TraceFeignObjectWrapper.

* Do not use class in field in order to avoid NoClassDefFound.

fixes #1528
2020-01-21 19:57:23 +01:00
Adrian Cole
58a956b29a Addresses Spring Boot 2.3 drift (#1527) 2020-01-20 16:42:17 +08:00
Adrian Cole
d08e106100 Reduces overhead when using reactor by avoiding redundant context syncs (#1525)
This switches to pass around and use `TraceContext` instead of `Span` in
Reactor's context to take advantage of `maybeScope` which is far cheaper
than `withSpanInScope` when the span is already current. This also kills
some extra scope checks and any other accidental calls noticed.

The performance improvement here, I can't quantify as haven't done any
JMH on it.
2020-01-17 23:50:32 +01:00
mcohen75
b93e739cc7 Configure OpentracingAutoConfiguration after TraceAutoConfiguration. (#1519)
TraceAutoConfiguration provides the Tracing bean. Without this dependency
in place a Tracing bean is sometimes not present when the
OpentracingAutoConfiguration is applied.
2020-01-13 12:02:53 +01:00
Marcin Grzejszczak
90c3128170 Removed duplicated test 2020-01-13 11:59:29 +01:00
Marcin Grzejszczak
7d0d9b9deb Merge branch '2.1.x' 2020-01-13 11:58:58 +01:00
Marcin Grzejszczak
d89624d712 Added missing test 2020-01-13 11:58:36 +01:00
Marcin Grzejszczak
67365321b6 Improved WebClient parent-child relation; fixes gh-1516 2020-01-13 11:55:16 +01:00
Marcin Grzejszczak
8f5bcdabd7 Improved WebClient parent-child relation; fixes gh-1516 2020-01-13 11:39:43 +01:00
Marcin Grzejszczak
a2e73ce0b4 Added a NPE guard 2020-01-10 00:13:13 +01:00
Csaba Kos
619133848a WebClient tracing should respect skipPattern. (#1517) 2020-01-10 00:07:09 +01:00
Marcin Grzejszczak
5a44385448 Removed the workaround since it got fixed in kafka; fixes gh-1515 2020-01-09 09:24:55 +01:00
Olga Maciaszek-Sharma
73f762285e Minor test refactoring. 2020-01-08 15:41:56 +01:00
Olga Maciaszek-Sharma
199ebb69d0 Fix compatibility in feign-based tests. 2020-01-08 15:13:01 +01:00
Marcin Grzejszczak
b76d3bfa0c Fixed broken compilation 2020-01-07 18:06:31 +01:00
Csaba Kos
68f720a2e5 Report HTTP pattern and handler function name for functional WebFlux routes. (#1513) 2020-01-07 17:07:28 +01:00
Marcin Grzejszczak
06cb4d747d For WebFilter removes any initial context entries if previously present
fixes gh-1507
2019-12-30 15:07:35 +01:00
Marcin Grzejszczak
06fae4468f Misaligned spans with WebClient
not using the SpanInScope for the cases where threads can be switched

fixes gh-1510
2019-12-30 12:23:23 +01:00
Marcin Grzejszczak
48c9d44a9a Merge branch '2.1.x' 2019-12-27 10:06:51 +01:00
Marcin Grzejszczak
3159f96a49 Added logging in case delegate wasn't instrumented 2019-12-27 10:05:44 +01:00
colejnic
b492868546 Instruments manually created load-balanced Feign Clients
fixes gh-1125
2019-12-27 09:36:56 +01:00
Spencer Gibb
26a1c0b372 Makes test less brittle 2019-12-19 15:24:01 -05:00
Marcin Grzejszczak
16c576c557 Making Redis instrumentation lazy; fixes gh-1508 2019-12-17 08:55:41 +01:00
Marcin Grzejszczak
11c8090b94 Spring Cloud Circuit Breaker tracing (#1505)
Adds support for Spring Cloud CircuitBreaker
2019-12-13 11:49:43 +01:00
Erik Smith
bc640791ab exclude redis command args from span tags (#1496) 2019-12-11 09:22:17 +01:00
buildmaster
795bb007e5 Bumping versions 2019-12-04 05:29:51 +00:00
Jakub Rosa
8510596e69 Issue 1498 (#1499)
* Add check another expression before create default B3Propagation factory - issue 1498

* fix ImportOrder errors
2019-12-03 10:45:00 +01:00
Marcin Grzejszczak
911e3f97a1 Merge branch '2.1.x' 2019-11-22 21:33:13 +01:00
evilnull
247d19f5c8 Shouldn't call finalize on LazyTraceThreadPoolTaskScheduler delegate
fixes gh-1485
2019-11-22 21:00:52 +01:00
Marcin Grzejszczak
065ccfd8da Merge branch '2.1.x' 2019-11-20 13:26:06 +01:00
Marcin Grzejszczak
1cbe0c03b0 When application context is closed, tracing bean retrieval will result in an exception
fixes gh-1450
2019-11-20 13:25:24 +01:00
Marcin Grzejszczak
b564361111 Shouldn't call finalize on LazyTraceThreadPoolTaskScheduler delegate; fixes gh-1485 2019-11-20 11:18:57 +01:00
Marcin Grzejszczak
34b2f3a268 Fixed wrong gateway integration and b3 parsing; fixes gh-1452 2019-11-08 17:44:43 +01:00
Marcin Grzejszczak
356dd0a3a5 Fixed wrong gateway integration and b3 parsing; fixes gh-1452 2019-11-08 17:42:30 +01:00
Adrian Cole
d1dddbf2c9 Adds Messaging sampling (#1483)
Same as #1456 except for messaging. This completes remote span sampling!
2019-11-04 12:15:15 +01:00
Marcin Grzejszczak
ec5973bd90 Revert "Revert "Revert "Came back to previous test impl"" - priort to the release" - after the release
This reverts commit 3173ca1505.
2019-10-31 12:40:32 +01:00
Marcin Grzejszczak
3173ca1505 Revert "Revert "Came back to previous test impl"" - priort to the release
This reverts commit 1a3e405e5a.
2019-10-31 12:28:33 +01:00
Marcin Grzejszczak
848442e99c Gateway should try to continue an existing trace from either thread local or request 2019-10-31 11:06:06 +01:00
Marcin Grzejszczak
6ee2cf6dab Gateway should try to continue an existing trace from either thread local or request 2019-10-31 10:55:37 +01:00
Marcin Grzejszczak
76b7563feb Merge branch '2.1.x' 2019-10-30 13:11:39 +01:00
Marcin Grzejszczak
cd2e2c2d49 Configure Reactor instrumentation to wrap onLastOperator or onEachOperator
with this feature we would allow user to pick whether they instrument on each or on last operator.

fixes gh-1478
2019-10-30 13:09:30 +01:00
worldtiki
bff52872e3 Service name for the remote redis endpoint. (#1475)
fixes #1406
2019-10-29 08:49:33 +01:00
Marcin Grzejszczak
34f61908fd Update auto-configuration to use @Configuration(proxyBeanMethods=false)
fixes gh-1245
2019-10-24 13:42:00 +02:00
Marcin Grzejszczak
4bfa08bb1c Fixed configuration names for metrics 2019-10-24 11:17:57 +02:00
Marcin Grzejszczak
d515370df2 Use Micrometer metrics instead of in memory one (#1477)
Using the micrometer zipkin reporter

fixes #1468
2019-10-24 10:57:00 +02:00
Marcin Grzejszczak
759ac87481 Not using loadbalancer zipkin URI extractor when zipkin url contains a port
fixes gh-1474
2019-10-23 13:41:24 +02:00
Adrian Cole
b22f5e8db3 Adds the possibility to opt-out of executor decoration (#1464)
* Adds the possibility to opt-out of executor decoration

Recently, `AsyncAutoConfiguration` auto-instruments executors. This
causes spans named 'async' with no tag or other metadata to help
understand what is happening. It was somewhat difficult troubleshooting
this because the control is by bean name, but for example the "async"
span doesn't include the bean name.

See https://github.com/spring-cloud/spring-cloud-gcp/issues/1978
2019-10-23 12:48:37 +02:00