Commit Graph

48 Commits

Author SHA1 Message Date
Adrian Cole
8a4002d288 Cleanups of build including upgrade of Brave (#1530)
In efforts to dig deep into benchmarks, I noticed we were a bit out of
date on Brave. Then, noticed some other artifacts could be bumped
safely. Finally, a find/replace on http/https was over zealous and
tripped up XML.

One change to test expectations and Brave is explained here:
https://github.com/openzipkin/brave/blob/master/instrumentation/RATIONALE.md#calling-spanfinish-while-the-context-is-in-scope
2020-01-22 19:31:50 +08:00
Olga Maciaszek-Sharma
d7b7e81235 Gh 1528 instrument feign sc loadbalancer client (#1531)
* Add optional SC LoadBalancer dependency. Create TraceFeignBlockingLoadBalancerClient.

* Instrument Spring Cloud LoadBalancer in TraceFeignObjectWrapper.

* Do not use class in field in order to avoid NoClassDefFound.

fixes #1528
2020-01-21 19:57:23 +01:00
Olga Maciaszek-Sharma
31d4574a1c Fix test naming. 2020-01-20 16:05:31 +01:00
Adrian Cole
58a956b29a Addresses Spring Boot 2.3 drift (#1527) 2020-01-20 16:42:17 +08:00
Adrian Cole
d08e106100 Reduces overhead when using reactor by avoiding redundant context syncs (#1525)
This switches to pass around and use `TraceContext` instead of `Span` in
Reactor's context to take advantage of `maybeScope` which is far cheaper
than `withSpanInScope` when the span is already current. This also kills
some extra scope checks and any other accidental calls noticed.

The performance improvement here, I can't quantify as haven't done any
JMH on it.
2020-01-17 23:50:32 +01:00
Marcin Grzejszczak
5a44385448 Removed the workaround since it got fixed in kafka; fixes gh-1515 2020-01-09 09:24:55 +01:00
Olga Maciaszek-Sharma
73f762285e Minor test refactoring. 2020-01-08 15:41:56 +01:00
Olga Maciaszek-Sharma
199ebb69d0 Fix compatibility in feign-based tests. 2020-01-08 15:13:01 +01:00
Csaba Kos
68f720a2e5 Report HTTP pattern and handler function name for functional WebFlux routes. (#1513) 2020-01-07 17:07:28 +01:00
buildmaster
a31ca0ace3 Bumping versions 2019-12-28 05:29:48 +00:00
Marcin Grzejszczak
b1e3f31dd8 Fixing checkstyle 2019-12-27 11:30:52 +01:00
Marcin Grzejszczak
553faa2a50 Fixing checkstyle 2019-12-27 11:25:54 +01:00
Marcin Grzejszczak
48c9d44a9a Merge branch '2.1.x' 2019-12-27 10:06:51 +01:00
colejnic
b492868546 Instruments manually created load-balanced Feign Clients
fixes gh-1125
2019-12-27 09:36:56 +01:00
buildmaster
1c4a3da588 Bumping versions to 2.2.2.BUILD-SNAPSHOT after release 2019-12-20 13:48:43 +00:00
buildmaster
ac6dff3407 Going back to snapshots 2019-12-20 13:48:43 +00:00
buildmaster
c71d6ff0e2 Update SNAPSHOT to 2.2.1.RELEASE 2019-12-20 13:46:45 +00:00
Marcin Grzejszczak
16c576c557 Making Redis instrumentation lazy; fixes gh-1508 2019-12-17 08:55:41 +01:00
buildmaster
9ca94951ec Bumping versions to 2.2.1.BUILD-SNAPSHOT after release 2019-11-26 10:35:52 +00:00
buildmaster
830f300ca9 Going back to snapshots 2019-11-26 10:35:52 +00:00
buildmaster
312f87cd23 Update SNAPSHOT to 2.2.0.RELEASE 2019-11-26 10:34:27 +00:00
buildmaster
99ebccf97c Going back to snapshots 2019-11-10 00:19:36 +00:00
buildmaster
10e6f9a705 Update SNAPSHOT to 2.2.0.RC2 2019-11-10 00:18:38 +00:00
Adrian Cole
d1dddbf2c9 Adds Messaging sampling (#1483)
Same as #1456 except for messaging. This completes remote span sampling!
2019-11-04 12:15:15 +01:00
buildmaster
d5bb9437f7 Bumping versions 2019-10-31 05:29:53 +00:00
Marcin Grzejszczak
a868b76300 Fixed invalid call to reactor configuration 2019-10-30 14:01:44 +01:00
Marcin Grzejszczak
52e9e89423 Fixed checkstyle 2019-10-30 13:30:53 +01:00
Marcin Grzejszczak
76b7563feb Merge branch '2.1.x' 2019-10-30 13:11:39 +01:00
worldtiki
bff52872e3 Service name for the remote redis endpoint. (#1475)
fixes #1406
2019-10-29 08:49:33 +01:00
buildmaster
b4b597872f Going back to snapshots 2019-10-24 21:05:59 +00:00
buildmaster
d972a87338 Update SNAPSHOT to 2.2.0.RC1 2019-10-24 21:05:02 +00:00
buildmaster
9361cf2017 Going back to snapshots 2019-10-03 20:06:35 +00:00
buildmaster
365a1c60f0 Update SNAPSHOT to 2.2.0.M3 2019-10-03 20:05:37 +00:00
Adrian Cole
be5fa04118 Updates to latest Sampling infrastructure (#1456)
* Updates to latest Sampling infrastructure

Brave recently switched to an interface model for higher level sampling
like HTTP. So, `HttpSampler` -> `SamplingFunction<HttpRequest>`. Don't
worry because `HttpSampler` was retrofitted as a `SamplingFunction`.

This change moves to the higher interface, avoiding deprecated methods
and such. More interestingly, this weaves in support for `RpcTracing`,
which *finally* introduces RPC sampling the same way. Specifically, this
adds `SamplingFunction<RpcRequest>` under the same conventions as HTTP.

Most immediately, this can be used here in gRPC and Dubbo, as
autoconfiguration exists. It also works with any autoconfiguration that
isn't here, such as Armeria.

Ex. Here's a sampler that traces 100 "GetUserToken" requests per second. This
doesn't start new traces for requests to the health check service. Other
requests will use a global rate provided by the tracing component.

```java
import static brave.rpc.RpcRequestMatchers.methodEquals;
import static brave.rpc.RpcRequestMatchers.serviceEquals;
import static brave.sampler.Matchers.and;

--snip--
@Bean(name = ServerSampler.NAME)
SamplerFunction<RpcRequest> myRpcSampler() {
  Matcher<RpcRequest> userAuth = and(
      serviceEquals("users.UserService"),
      methodEquals("GetUserToken")
  );
  return RpcRuleSampler.newBuilder()
      .putRule(serviceEquals("grpc.health.v1.Health"), Sampler.NEVER_SAMPLE)
      .putRule(userAuth, RateLimitingSampler.create(100)).build();
}
```
2019-10-03 12:21:56 +02:00
buildmaster
c7b818753f Bumping versions 2019-10-03 05:29:37 +00:00
Marcin Grzejszczak
29c9afe403 Added improved support of DefaultKafkaHeaderMapper wrapping for Kafka
without this change there was a propagation gap due to additional quotes in the headers
with this change we're wrapping the DefaultKafkaHeaderMapper to not add additional quotes

fixes gh-1430
2019-10-02 13:13:37 +02:00
Marcin Grzejszczak
80dd22acc9 Merge branch '2.1.x' 2019-09-19 11:46:27 +02:00
Nick
a5d41840b3 Fix ThreadPoolTaskScheduler proxy mechanism (#1447) 2019-09-19 09:49:46 +02:00
Marcin Grzejszczak
4db9b49f20 Merge branch '2.1.x' 2019-09-18 12:10:39 +02:00
Marcin Grzejszczak
667210e0fb Fixed the broken compilation 2019-09-18 10:03:19 +02:00
Marcin Grzejszczak
0cf9003ae9 Merge branch '2.1.x' 2019-08-30 15:35:34 +02:00
buildmaster
40a5333e56 Going back to snapshots 2019-08-14 15:47:10 +00:00
buildmaster
4884f0f78c Update SNAPSHOT to 2.2.0.M2 2019-08-14 15:45:31 +00:00
buildmaster
ad379974e1 Bumping versions 2019-07-23 10:09:49 +00:00
Marcin Grzejszczak
1bda9a57df Trying to make the build less brittle 2019-07-10 16:14:30 +02:00
Marcin Grzejszczak
e449aaad81 Moved the rest template test 2019-07-09 10:15:55 +02:00
Marcin Grzejszczak
9fa559e830 Makes tests less brittle 2019-07-09 09:27:07 +02:00
Marcin Grzejszczak
e6b78d267f Migrates tests to separate modules (#1395)
fixes #1394
2019-07-08 13:36:20 +02:00