Commit Graph

331 Commits

Author SHA1 Message Date
buildmaster
682f0b82d0 Bumping versions 2020-06-06 05:29:27 +00:00
buildmaster
93ea0d6b00 Going back to snapshots 2020-05-29 19:03:35 +00:00
buildmaster
640faa7c30 Update SNAPSHOT to 3.0.0-M2 2020-05-29 19:02:42 +00:00
Adrian Cole
31fb3001c5 Merge branch '2.2.x' 2020-05-18 23:58:46 +08:00
Adrian Cole
453be43b5a bump 2020-05-18 21:13:23 +08:00
Adrian Cole
3da9de053e Merge branch '2.2.x' 2020-05-18 20:20:40 +08:00
Adrian Cole
40785d642a Removes Zipkin dependency from all tests (#1645)
Brave's SpanHandler can report natively in other formats which have different
constraints than Zipkin and often extensions to the data model.

This change ports all tests away from Zipkin's types so that it is more clear
what's actually recorded vs what's a side-effect of Zipkin conversion.

This removes `BlockingQueueSpanReporter` which was never released, also.
2020-05-18 17:02:29 +08:00
Adrian Cole
58094e4d76 Merge branch '2.2.x' 2020-05-17 22:38:01 +08:00
Adrian Cole
99ce7cdd1c latest brave 2020-05-17 21:01:31 +08:00
Adrian Cole
8ae5e13d31 Merge branch '2.2.x' 2020-05-16 15:15:37 +08:00
Adrian Cole
b1d39ce291 Updates to Brave 5.12 and introduces SpanHandler (#1632)
`SpanHandler` is the base type for the now deprecated `FinishedSpanHandler`.

Notable, it can not just handle things at the end of a recording, but also the
beginning.

For example, this permits set-once baggage without the HTTP abstraction:
```java
static final BaggageField EPOCH_SECONDS = BaggageField.create("epoch_seconds");

static final class RootOnlyBaggage extends SpanHandler {
  @Override
  public boolean begin(TraceContext context, MutableSpan span, @Nullable TraceContext parent) {
    if (EPOCH_SECONDS.getValue(context) == null) { // only set at the first span
      long epochSeconds = System.currentTimeMillis() / 1000;
      EPOCH_SECONDS.updateValue(context, String.valueOf(epochSeconds));
    }
    return true;
  }

  @Override public boolean end(TraceContext context, MutableSpan span, Cause cause) {
    Tags.BAGGAGE_FIELD.tag(EPOCH_SECONDS, context, span);
    return true;
  }
}
```

As the parent is available, it can also facilitate advanced tasks like counting
children, or summarizing entire local roots.

See https://github.com/openzipkin/brave/tree/master/brave/src/test/java/brave/features/handler
and https://github.com/openzipkin/brave/blob/master/brave/src/main/java/brave/handler/SpanHandler.java for more
2020-05-16 14:01:38 +08:00
buildmaster
d41d75a3eb Bumping versions 2020-04-17 14:53:39 +00:00
buildmaster
08a575141d Going back to snapshots 2020-04-09 22:48:15 +00:00
buildmaster
66b540f0b9 Update SNAPSHOT to 3.0.0.M1 2020-04-09 22:47:21 +00:00
Adrian Cole
b92db4ce51 Stops propagating Sleuth 1.x spring-messaging headers
To reduce confusion and overhead, the following custom spring-messaging headers added in Sleuth 1.0 are no longer sent, and a log warning is issued once if they are by outside code.

* spanId
* spanSampled
* spanParentSpanId
* spanTraceId
* spanFlags

Sending the above headers actually increases the headers by up to 10 because they are duplicated in the "native" part of messages. This overhead is extreme especially if messages never leave the process.

The solution is to only send [b3 single format](https://github.com/openzipkin/b3-propagation#single-header), which has been in sleuth since 2.0 and is compatible with JMS. The B3 single format is always parsed and takes precedence, even if multiple headers are sent, so this is a safe change.

Note: Unlike RPC, messaging spans never join with their parent. Better performance is achieved by not propagating the producer's parentId downstream.

Note: Deprecated spring-messaging headers such "spanTraceId" as are still read in Sleuth 3.x. However, they will not be at some point in the future. Please pay attention to the log messages and update your code if you are accidentally using them.
2020-04-07 10:58:49 +08:00
Adrian Cole
fa6eb20914 latest brave 2020-04-06 16:54:15 +08:00
Adrian Cole
dcefd7b4db Stops configuring ExtraFieldPropagation. Starts configuring BaggagePropagation (#1602) 2020-04-06 16:38:32 +08:00
Adrian Cole
a21ea1279d Turn off fail on javadoc warnings #1600 2020-04-04 15:15:24 +08:00
Adrian Cole
b79f8897c2 Merge branch '2.2.x' 2020-04-03 20:20:58 +08:00
Adrian Cole
c20f6c6a11 Moves Slf4jScopeDecorator to use CorrelationField internally (#1597) 2020-04-03 19:57:37 +08:00
Adrian Cole
b9b2357fb5 Merge branch '2.2.x' 2020-04-03 16:17:24 +08:00
Adrian Cole
60820379f1 Updates to latest brave and removes all static thread local use (#1594) 2020-04-03 08:01:22 +08:00
Marcin Grzejszczak
729df801ab Merge branch '2.2.x' 2020-03-31 14:20:34 +02:00
Marcin Grzejszczak
351d1d4e44 Removed javadoc warnings 2020-03-30 16:07:26 +02:00
Marcin Grzejszczak
053d9a79b0 Switch Javadocs check to true 2020-03-30 15:08:37 +02:00
Adrian Cole
1e1e1f04bf Finalizes reactor-netty HttpClient implementations (#1586) 2020-03-26 17:10:01 +08:00
Spencer Gibb
9620ed8685 bumps build to 2.3.0.BUILD-SNAPSHOT 2020-03-19 12:08:31 -04:00
Spencer Gibb
0d79f74df5 bumps build to 2.2.4.BUILD-SNAPSHOT 2020-03-18 18:46:02 -04:00
buildmaster
2674fba171 Bumping versions to 2.2.3.BUILD-SNAPSHOT after release 2020-03-04 16:59:42 +00:00
buildmaster
5dd714da5c Going back to snapshots 2020-03-04 16:59:42 +00:00
buildmaster
151218b30a Update SNAPSHOT to 2.2.2.RELEASE 2020-03-04 16:57:41 +00:00
Marcin Grzejszczak
3ce018bc51 Upgrades to JUnit5; fixes gh-1567 2020-03-03 19:53:57 +01:00
Marcin Grzejszczak
2024e28937 Added example with Stream Bridge 2020-03-03 16:22:18 +01:00
Adrian Cole
8e6760d2b6 Merge branch '2.2.x' 2020-02-27 16:07:57 +08:00
Adrian Cole
44c9027199 brave patch 2020-02-27 15:52:14 +08:00
Adrian Cole
db2d9aeaaa Merge branch '2.2.x' 2020-02-26 16:51:58 +08:00
Adrian Cole
7262790717 Performs minimal work to update to Brave 5.10 (#1573)
A later PR will handle new features/deprecation
2020-02-26 16:43:14 +08:00
Adrian Cole
236af9c70f bumps to latest brave 2020-02-13 12:06:04 -08:00
buildmaster
ca494f0d67 Bumping versions 2020-02-13 05:30:07 +00:00
Marcin Grzejszczak
3813cf9dd4 Removes modules in maintenance more.
Zuul, ribbon and hystrix
2020-02-12 11:03:04 +01:00
Adrian Cole
a6d7bd3784 bumps to latest brave 2020-02-04 13:24:12 +08:00
Adrian Cole
fc47d61883 bumps to latest brave 2020-02-04 13:23:54 +08:00
Adrian Cole
fe2591b22a latest brave 2020-01-29 14:06:10 +08:00
Adrian Cole
163532fd8a latest brave 2020-01-29 14:05:46 +08:00
Adrian Cole
8a4002d288 Cleanups of build including upgrade of Brave (#1530)
In efforts to dig deep into benchmarks, I noticed we were a bit out of
date on Brave. Then, noticed some other artifacts could be bumped
safely. Finally, a find/replace on http/https was over zealous and
tripped up XML.

One change to test expectations and Brave is explained here:
https://github.com/openzipkin/brave/blob/master/instrumentation/RATIONALE.md#calling-spanfinish-while-the-context-is-in-scope
2020-01-22 19:31:50 +08:00
Adrian Cole
8866b84906 Cleanups of build including upgrade of Brave (#1530)
In efforts to dig deep into benchmarks, I noticed we were a bit out of
date on Brave. Then, noticed some other artifacts could be bumped
safely. Finally, a find/replace on http/https was over zealous and
tripped up XML.

One change to test expectations and Brave is explained here:
https://github.com/openzipkin/brave/blob/master/instrumentation/RATIONALE.md#calling-spanfinish-while-the-context-is-in-scope
2020-01-21 09:44:08 +01:00
buildmaster
a3c0431f03 Bumping versions 2019-12-21 05:30:19 +00:00
buildmaster
1c4a3da588 Bumping versions to 2.2.2.BUILD-SNAPSHOT after release 2019-12-20 13:48:43 +00:00
buildmaster
ac6dff3407 Going back to snapshots 2019-12-20 13:48:43 +00:00
buildmaster
c71d6ff0e2 Update SNAPSHOT to 2.2.1.RELEASE 2019-12-20 13:46:45 +00:00