Commit Graph

723 Commits

Author SHA1 Message Date
Marcin Grzejszczak
4ac7efa28b Merge branch '1.2.x' 2017-09-30 09:13:01 +02:00
Marcin Grzejszczak
3c447f43b7 Fixing missing new Hook(); fixes #718 2017-09-30 09:12:32 +02:00
Marcin Grzejszczak
1b1a1698ca Removed setting of the "fallback span"
without this change we created a "fallback span" in the case where a Spring component didn't handle the span. By handling it means that it got processed by anyway (a tag, log was added etc.). Why did we do that? That's because if no component was involved in creation of additional spans then in the Zipkin UI the service that had only the span that has the SR, SS logs wouldn't show up. In other words, if service A called service B and service B had only a single span, then service B wouldn't show up in the UI (there would be no blue bar). All the data would show up however in the client side of that span.

with this change we're removing this behaviour. That's because it introduces confusion for our users, that use non Spring related components. Also it seems that the Zipkin UI got fixed and this error no longer is present. If however it turns out that it's still there, it clearly seems that the place to fix this error should be Zipkin and not Sleuth.

fixes #708
2017-09-22 13:21:46 +02:00
Marcin Grzejszczak
cefef8cc9f Fixed return value of the tracer 2017-09-18 20:49:55 +01:00
Marcin Grzejszczak
5b6d039036 Fixed a typo 2017-09-14 17:15:30 +02:00
Marcin Grzejszczak
cfd3a619dd Introduced a "shared" field in Span (#698)
whenever:

- a span or trace id get generated when a request / message arrives
- child span is created

we set the field to false

whenever we find ids in the incoming request / message we set the field to true

fixes #696
2017-09-14 17:14:09 +02:00
Marcin Grzejszczak
5bb444f042 Adding tags for spans created via annotations (#691)
without this change we don't know which class or method (if the SpanCreator got overridden) was annotated
with this change we're adding the tags with this info

fixes #690
2017-09-12 13:37:01 +02:00
Marcin Grzejszczak
17e303a1f7 Removed remaining deprecations 2017-08-25 13:07:36 +02:00
Marcin Grzejszczak
f14f5efe43 Going back to snapshots 2017-08-25 12:47:28 +02:00
Marcin Grzejszczak
61ca762dd4 Update SNAPSHOT to 1.3.0.M1 2017-08-25 12:44:31 +02:00
Marcin Grzejszczak
b83caf4ac0 Polish 2017-08-25 11:52:14 +02:00
Marcin Grzejszczak
126101f0ab Merge branch '1.2.x' 2017-08-24 14:24:02 +02:00
Marcin Grzejszczak
c951dc88fd Improvements of customizing the TraceFilter
without this change you have to add a `@Primary` annotation around your custom `TraceFilter` bean to alter the behaviour of the current `TraceFilter` implementation
with this change we're marking the `TraceFilter` as conditional on missing bean; also we're ensuring that the registered `SkipPatternProvider` will be reused when no explicit pattern was set.

also documentation is added

fixes #633
2017-08-24 14:14:01 +02:00
Marcin Grzejszczak
77c1de386f Fixed class not being static 2017-08-23 18:19:36 +02:00
Marcin Grzejszczak
d147b19a8d Merge branch '1.2.x' 2017-08-23 18:18:38 +02:00
Marcin Grzejszczak
6d25738ec4 Adding the default Trace representation of UserInfoRestTemplateCustomizer 2017-08-23 18:15:48 +02:00
Marcin Grzejszczak
05f1d6df43 Merge branch '1.2.x' 2017-08-22 13:07:08 +02:00
Marcin Grzejszczak
58f3d0fce0 Added fallback approach to try to create a JDK proxy when CGLIB one fails
without this change when a CGLIB proxy fails to be created an exception is thrown
with this change we're trying to save the situation by trying to create a JDK proxy. If that also won't work then we're throwing an exception.

fixes #684
2017-08-22 12:52:35 +02:00
Marcin Grzejszczak
17df781524 Bumping versions to 1.2.5.BUILD-SNAPSHOT after release 2017-08-21 10:06:48 +02:00
Marcin Grzejszczak
cbddd5568c Going back to snapshots 2017-08-21 10:06:47 +02:00
Marcin Grzejszczak
5eba47d891 Update SNAPSHOT to 1.2.4.RELEASE 2017-08-21 10:01:14 +02:00
Marcin Grzejszczak
02a0c864e8 Bumping versions to 1.2.4.BUILD-SNAPSHOT after release 2017-08-18 18:46:50 +02:00
Marcin Grzejszczak
73211f673b Going back to snapshots 2017-08-18 18:46:49 +02:00
Marcin Grzejszczak
47612da5cc Update SNAPSHOT to 1.2.3.RELEASE 2017-08-18 18:36:51 +02:00
Marcin Grzejszczak
3931087628 Merge branch '1.2.x' 2017-08-18 16:42:25 +02:00
Marcin Grzejszczak
59f5a99c24 TraceFilter skipPattern and extra span when X-B3-Flags header is present
without this change if there's a debug flag we set traceid & spanid for the first request inside the zipkin http extractor. we don't set the parent span flag so an additional span is created.
with this change we set the trace and span id ONLY when the debug flag is set AND the request is malformed. That means - only when the span id is set and there is no trace id.

fixes #665
2017-08-18 16:24:28 +02:00
Marcin Grzejszczak
ebe74c1d8f Merge branch '1.2.x' 2017-08-18 03:52:31 +02:00
Marcin Grzejszczak
e9211e8bd0 Polish 2017-08-18 03:32:24 +02:00
Marcin Grzejszczak
c268d55656 Added debug logs for TraceChannelInterceptor 2017-08-18 03:31:35 +02:00
Marcin Grzejszczak
acfbb3b8f7 Added missing profile 2017-08-18 02:50:27 +02:00
Marcin Grzejszczak
4c53d65039 Added http keys for a root span
without this, the root span doesn't have any HTTP trace keys set
with this, the root span has both the request and response trace keys set

fixes #668
2017-08-17 17:51:50 +02:00
Marcin Grzejszczak
6f8f02e944 Fixed the Sonar issue related to non static class 2017-08-17 14:53:06 +02:00
Marcin Grzejszczak
f322d7a06c @Async Spans should use SpanNamer
without this change there's no way to alter the name of the methods annotated with @Async
with this change the value passed to @Async annotated method via @SpanName will be the name of the span

fixes #653
2017-08-17 14:05:31 +02:00
Marcin Grzejszczak
a85bb0f743 Merge branch '1.2.x' 2017-08-17 13:41:12 +02:00
Marcin Grzejszczak
c3d198053f Enable spring-data only on demand for tests 2017-08-17 13:40:27 +02:00
Marcin Grzejszczak
24c1471f92 Merged 1.2.x into master 2017-08-14 10:33:58 -04:00
Marcin Grzejszczak
253b34b1cf Fixed missing interceptor injection in OAuth2RestTemplate
fixes #581
2017-08-14 10:10:38 -04:00
Marcin Grzejszczak
3034497617 Merge branch '1.2.x' 2017-08-05 22:11:13 +02:00
Canaan Stafford
7dffabd91a Expand type check in TraceChannelInterceptor (#673)
The type check in the method 'getMessage' was only for a sub-class of
MessagingException. The check was expanded to the base class.
2017-08-05 22:10:54 +02:00
Marcin Grzejszczak
09862f3516 Updated poms 2017-08-04 11:53:27 +02:00
Marcin Grzejszczak
48227e7793 Returns proper message; fixes #669 2017-08-04 11:52:31 +02:00
Marcin Grzejszczak
883a8d4e24 Merge branch '1.2.x' 2017-08-03 17:56:47 +02:00
Marcin Grzejszczak
aadf0a8334 Added support for failed messages
without this change when messages arrive at a error channel a new traceid is set
with this change we continue the trace

fixes #667
2017-08-03 17:50:47 +02:00
Dave Syer
b60620239c Remove IntroductionAdvisor from SleuthAdvisorConfig
Fxies gh-659
2017-07-26 12:56:09 +01:00
Dave Syer
540c95895a Remove redundant method matcher
Fixes gh-658
2017-07-26 11:51:23 +01:00
Marcin Grzejszczak
e8d30be75e Going back to snapshots 2017-07-21 12:58:54 +02:00
Marcin Grzejszczak
932f8e74d3 Update SNAPSHOT to 1.2.2.RELEASE 2017-07-21 12:30:53 +02:00
Marcin Grzejszczak
8c98386c14 WIP 2017-07-15 19:39:48 +02:00
Marcin Grzejszczak
362f20d0a8 WIP 2017-07-15 15:15:39 +02:00
Marcin Grzejszczak
bddad6e2bc Merge branch '1.2.x' 2017-07-15 10:17:16 +02:00