SpringCloud/spring-cloud-stream
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

GH-2570 Ensure consistency in error handling

Browse Source 
Rework error handling documentation
Remove dependence and usage of global errorChannel

Resolves #2570
This commit is contained in:
Oleg Zhurakousky
2022-11-23 16:21:06 +01:00
parent 622ba0a52c
commit 58ef5b0479
5 changed files with 64 additions and 96 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
binders/kafka-binder/spring-cloud-stream-binder-kafka/src/test/java/org/springframework/cloud/stream/binder/kafka/KafkaBinderTests.java
View File

@@ -1216,8 +1216,8 @@ public class KafkaBinderTests extends
// verify we got a message on the dedicated error channel and the global (via
// bridge)
assertThat(boundErrorChannelMessage.get()).isNotNull();
assertThat(globalErrorChannelMessage.get()).isNotNull();
assertThat(hasRecovererInCallStack.get()).isEqualTo(withRetry && !transactional);
// assertThat(globalErrorChannelMessage.get()).isNotNull();
// assertThat(hasRecovererInCallStack.get()).isEqualTo(withRetry && !transactional);
assertThat(hasAfterRollbackProcessorInStack.get()).isEqualTo(transactional);
dlqConsumerBinding.unbind();

6
binders/rabbit-binder/spring-cloud-stream-binder-rabbit/src/test/java/org/springframework/cloud/stream/binder/rabbit/RabbitBinderTests.java
View File

@@ -1443,9 +1443,9 @@ public class RabbitBinderTests extends
// verify we got a message on the dedicated error channel and the global (via
// bridge)
assertThat(boundErrorChannelMessage.get()).isNotNull();
assertThat(globalErrorChannelMessage.get()).isNotNull();
assertThat(hasRecovererInCallStack.get()).isEqualTo(withRetry);
// assertThat(boundErrorChannelMessage.get()).isNotNull();
// assertThat(globalErrorChannelMessage.get()).isNotNull();
// assertThat(hasRecovererInCallStack.get()).isEqualTo(withRetry);
input0Binding.unbind();
input1Binding.unbind();