From 5f4e3eebc5ec664769107d089e60ec8457e81caa Mon Sep 17 00:00:00 2001 From: Soby Chacko Date: Mon, 24 May 2021 16:46:26 -0400 Subject: [PATCH] Removing deprecated setAckOnError method call (#1082) Going forward, binder will use the default ack on error settings in Spring Kafka, which is true by default. If the applicaitons need to change this behavior, then a custom error handler must be provided through ListenerContainerCustomizer. Resolves https://github.com/spring-cloud/spring-cloud-stream-binder-kafka/issues/1079 --- .../cloud/stream/binder/kafka/KafkaMessageChannelBinder.java | 5 ----- 1 file changed, 5 deletions(-) diff --git a/spring-cloud-stream-binder-kafka/src/main/java/org/springframework/cloud/stream/binder/kafka/KafkaMessageChannelBinder.java b/spring-cloud-stream-binder-kafka/src/main/java/org/springframework/cloud/stream/binder/kafka/KafkaMessageChannelBinder.java index 730bf412a..a42ef4680 100644 --- a/spring-cloud-stream-binder-kafka/src/main/java/org/springframework/cloud/stream/binder/kafka/KafkaMessageChannelBinder.java +++ b/spring-cloud-stream-binder-kafka/src/main/java/org/springframework/cloud/stream/binder/kafka/KafkaMessageChannelBinder.java @@ -709,11 +709,6 @@ public class KafkaMessageChannelBinder extends if (!extendedConsumerProperties.getExtension().isAutoCommitOffset()) { messageListenerContainer.getContainerProperties() .setAckMode(ContainerProperties.AckMode.MANUAL); - messageListenerContainer.getContainerProperties().setAckOnError(false); - } - else { - messageListenerContainer.getContainerProperties() - .setAckOnError(isAutoCommitOnError(extendedConsumerProperties)); } } }