From 70cba0ae036526c239217e674fd5628618418de5 Mon Sep 17 00:00:00 2001
From: Gary Russell <grussell@pivotal.io>
Date: Fri, 17 Feb 2017 21:29:45 -0500
Subject: [PATCH] Fix KafkaTopicProvisioner Inner Classes

- make destination inner classes `static` since they have no dependence on the outer class
- make ctors package-protected - private ctors for inner classes cause the compiler to
  generate a synthetic ctor with an additional synthetic parameter
---
 .../provisioning/KafkaTopicProvisioner.java   | 26 +++++++++++--------
 1 file changed, 15 insertions(+), 11 deletions(-)

diff --git a/spring-cloud-stream-binder-kafka-core/src/main/java/org/springframework/cloud/stream/binder/kafka/provisioning/KafkaTopicProvisioner.java b/spring-cloud-stream-binder-kafka-core/src/main/java/org/springframework/cloud/stream/binder/kafka/provisioning/KafkaTopicProvisioner.java
index 99c0b2fed..c810f06b3 100644
--- a/spring-cloud-stream-binder-kafka-core/src/main/java/org/springframework/cloud/stream/binder/kafka/provisioning/KafkaTopicProvisioner.java
+++ b/spring-cloud-stream-binder-kafka-core/src/main/java/org/springframework/cloud/stream/binder/kafka/provisioning/KafkaTopicProvisioner.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2014-2016 the original author or authors.
+ * Copyright 2014-2017 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -54,6 +54,7 @@ import kafka.utils.ZkUtils;
  * Kafka implementation for {@link ProvisioningProvider}
  *
  * @author Soby Chacko
+ * @author Gary Russell
  */
 public class KafkaTopicProvisioner implements ProvisioningProvider<ExtendedConsumerProperties<KafkaConsumerProperties>,
 		ExtendedProducerProperties<KafkaProducerProperties>>, InitializingBean {
@@ -238,18 +239,19 @@ public class KafkaTopicProvisioner implements ProvisioningProvider<ExtendedConsu
 		}
 	}
 
-	private final class KafkaProducerDestination implements ProducerDestination {
+	private static final class KafkaProducerDestination implements ProducerDestination {
 
 		private final String producerDestinationName;
+
 		private final int partitions;
 
-		private KafkaProducerDestination(String destinationName, Integer partitions) {
-			this.producerDestinationName = destinationName;
-			this.partitions = partitions;
+		KafkaProducerDestination(String destinationName) {
+			this(destinationName, 0);
 		}
 
-		private KafkaProducerDestination(String destinationName) {
-			this(destinationName, 0);
+		KafkaProducerDestination(String destinationName, Integer partitions) {
+			this.producerDestinationName = destinationName;
+			this.partitions = partitions;
 		}
 
 		@Override
@@ -271,21 +273,23 @@ public class KafkaTopicProvisioner implements ProvisioningProvider<ExtendedConsu
 		}
 	}
 
-	private final class KafkaConsumerDestination implements ConsumerDestination {
+	private static final class KafkaConsumerDestination implements ConsumerDestination {
 
 		private final String consumerDestinationName;
+
 		private final int partitions;
+
 		private final String dlqName;
 
-		private KafkaConsumerDestination(String consumerDestinationName) {
+		KafkaConsumerDestination(String consumerDestinationName) {
 			this(consumerDestinationName, 0, null);
 		}
 
-		private KafkaConsumerDestination(String consumerDestinationName, int partitions) {
+		KafkaConsumerDestination(String consumerDestinationName, int partitions) {
 			this(consumerDestinationName, partitions, null);
 		}
 
-		private KafkaConsumerDestination(String consumerDestinationName, Integer partitions, String dlqName) {
+		KafkaConsumerDestination(String consumerDestinationName, Integer partitions, String dlqName) {
 			this.consumerDestinationName = consumerDestinationName;
 			this.partitions = partitions;
 			this.dlqName = dlqName;