From 765e19d761b7a2be9320560b8df520bdb7a7ed3f Mon Sep 17 00:00:00 2001 From: Gary Russell Date: Thu, 17 Sep 2020 12:33:29 -0400 Subject: [PATCH] Remove TODO from binder config Even though Boot auto-configures a `ConnectionNameStrategy` we cannot remove it from the binder configuration because Boot auto-configuration runs before the binder configuration. Resolves #306 --- .../rabbit/config/RabbitMessageChannelBinderConfiguration.java | 1 - 1 file changed, 1 deletion(-) diff --git a/spring-cloud-stream-binder-rabbit/src/main/java/org/springframework/cloud/stream/binder/rabbit/config/RabbitMessageChannelBinderConfiguration.java b/spring-cloud-stream-binder-rabbit/src/main/java/org/springframework/cloud/stream/binder/rabbit/config/RabbitMessageChannelBinderConfiguration.java index 86effae06..d16fd9944 100644 --- a/spring-cloud-stream-binder-rabbit/src/main/java/org/springframework/cloud/stream/binder/rabbit/config/RabbitMessageChannelBinderConfiguration.java +++ b/spring-cloud-stream-binder-rabbit/src/main/java/org/springframework/cloud/stream/binder/rabbit/config/RabbitMessageChannelBinderConfiguration.java @@ -123,7 +123,6 @@ public class RabbitMessageChannelBinderConfiguration { final AtomicInteger nameIncrementer = new AtomicInteger(); ConnectionNameStrategy namer = f -> this.rabbitBinderConfigurationProperties .getConnectionNamePrefix() + "#" + nameIncrementer.getAndIncrement(); - // TODO: this can be removed when Boot 2.0.1 wires it in cf.setConnectionNameStrategy(namer); return namer; }