Added checkstyle

This commit is contained in:
Marcin Grzejszczak
2019-02-04 15:55:35 +01:00
parent c6d238085f
commit a8cbf77794
362 changed files with 8885 additions and 6508 deletions

View File

@@ -1,5 +1,7 @@
<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<project xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xmlns="http://maven.apache.org/POM/4.0.0"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>org.springframework.cloud</groupId>
@@ -8,7 +10,8 @@
</parent>
<artifactId>spring-cloud-stream-test-support-internal</artifactId>
<description>Set of classes and utility code that may assist in testing both
spring-cloud-stream itself, and also modules.</description>
spring-cloud-stream itself, and also modules.
</description>
<dependencies>
<dependency>
<groupId>junit</groupId>

View File

@@ -35,11 +35,15 @@ import static org.junit.Assert.fail;
* skipped, depending on the value of system property
* {@value #SCS_EXTERNAL_SERVERS_REQUIRED}.
*
* @param <R> resource type
* @author Eric Bottard
* @author Gary Russell
*/
public abstract class AbstractExternalResourceTestSupport<R> implements TestRule {
/**
* SCS external servers required environment variable.
*/
public static final String SCS_EXTERNAL_SERVERS_REQUIRED = "SCS_EXTERNAL_SERVERS_REQUIRED";
protected final Log logger = LogFactory.getLog(getClass());
@@ -76,7 +80,8 @@ public abstract class AbstractExternalResourceTestSupport<R> implements TestRule
cleanupResource();
}
catch (Exception ignored) {
logger.warn("Exception while trying to cleanup proper resource",
AbstractExternalResourceTestSupport.this.logger.warn(
"Exception while trying to cleanup proper resource",
ignored);
}
}
@@ -88,18 +93,21 @@ public abstract class AbstractExternalResourceTestSupport<R> implements TestRule
private Statement failOrSkip(final Exception e) {
String serversRequired = System.getenv(SCS_EXTERNAL_SERVERS_REQUIRED);
if ("true".equalsIgnoreCase(serversRequired)) {
logger.error(resourceDescription + " IS REQUIRED BUT NOT AVAILABLE", e);
fail(resourceDescription + " IS NOT AVAILABLE");
this.logger.error(this.resourceDescription + " IS REQUIRED BUT NOT AVAILABLE",
e);
fail(this.resourceDescription + " IS NOT AVAILABLE");
// Never reached, here to satisfy method signature
return null;
}
else {
logger.error(resourceDescription + " IS NOT AVAILABLE, SKIPPING TESTS", e);
this.logger.error(
this.resourceDescription + " IS NOT AVAILABLE, SKIPPING TESTS", e);
return new Statement() {
@Override
public void evaluate() throws Throwable {
Assume.assumeTrue("Skipping test due to " + resourceDescription
Assume.assumeTrue("Skipping test due to "
+ AbstractExternalResourceTestSupport.this.resourceDescription
+ " not being available " + e, false);
}
};
@@ -107,23 +115,23 @@ public abstract class AbstractExternalResourceTestSupport<R> implements TestRule
}
private void maybeCleanup() {
if (resource != null) {
if (this.resource != null) {
try {
cleanupResource();
}
catch (Exception ignored) {
logger.warn("Exception while trying to cleanup failed resource", ignored);
this.logger.warn("Exception while trying to cleanup failed resource",
ignored);
}
}
}
public R getResource() {
return resource;
return this.resource;
}
/**
* Perform cleanup of the {@link #resource} field, which is guaranteed to be non null.
*
* @throws Exception any exception thrown by this method will be logged and swallowed
*/
protected abstract void cleanupResource() throws Exception;
@@ -132,6 +140,7 @@ public abstract class AbstractExternalResourceTestSupport<R> implements TestRule
* Try to obtain and validate a resource. Implementors should either set the
* {@link #resource} field with a valid resource and return normally, or throw an
* exception.
* @throws Exception when resource couldn't be obtained
*/
protected abstract void obtainResource() throws Exception;