From bc973e3462afa1c3286241dbb61c549201222c25 Mon Sep 17 00:00:00 2001 From: Ginkgo <112621199+ginkgo-framework@users.noreply.github.com> Date: Mon, 5 Sep 2022 12:05:25 +0800 Subject: [PATCH] Fix KafkaBinderHealthIndicator return Down Error When we set enable.auto.commit to true, the actuator/health returns DOWN status. For more details see this: https://github.com/spring-cloud/spring-cloud-stream/pull/2504#issue-1361385289 Update KafkaBinderConfigurationProperties.java Polish commit --- .../kafka/properties/KafkaBinderConfigurationProperties.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/binders/kafka-binder/spring-cloud-stream-binder-kafka-core/src/main/java/org/springframework/cloud/stream/binder/kafka/properties/KafkaBinderConfigurationProperties.java b/binders/kafka-binder/spring-cloud-stream-binder-kafka-core/src/main/java/org/springframework/cloud/stream/binder/kafka/properties/KafkaBinderConfigurationProperties.java index 5b7af17c3..8c3908e38 100644 --- a/binders/kafka-binder/spring-cloud-stream-binder-kafka-core/src/main/java/org/springframework/cloud/stream/binder/kafka/properties/KafkaBinderConfigurationProperties.java +++ b/binders/kafka-binder/spring-cloud-stream-binder-kafka-core/src/main/java/org/springframework/cloud/stream/binder/kafka/properties/KafkaBinderConfigurationProperties.java @@ -411,7 +411,7 @@ public class KafkaBinderConfigurationProperties { private void filterStreamManagedConfiguration(Map configuration) { if (configuration.containsKey(ConsumerConfig.ENABLE_AUTO_COMMIT_CONFIG) - && configuration.get(ConsumerConfig.ENABLE_AUTO_COMMIT_CONFIG).equals(true)) { + && configuration.get(ConsumerConfig.ENABLE_AUTO_COMMIT_CONFIG).toString().equalsIgnoreCase("true")) { logger.warn(constructIgnoredConfigMessage(ConsumerConfig.ENABLE_AUTO_COMMIT_CONFIG) + ConsumerConfig.ENABLE_AUTO_COMMIT_CONFIG + "=true is not supported by the Kafka binder"); configuration.remove(ConsumerConfig.ENABLE_AUTO_COMMIT_CONFIG);