From bfff729b817c559c4bae9f80c49c3f4eadfdadac Mon Sep 17 00:00:00 2001
From: Marius Bogoevici <mbogoevici@pivotal.io>
Date: Fri, 15 Apr 2016 14:48:26 -0400
Subject: [PATCH] Reinstate checkstyle running by default

- Rely on `checkstyle.skip` instead of a custom property
- Remove configuration from plugin definition, rely on execution only to set project-specific dependencies. This prevents inheritors from outside the project to fail on not finding the configuration. Note: on the long run, we will want to create a `build-tools` submodule that hold the configurations.
---
 pom.xml | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/pom.xml b/pom.xml
index 22ae67e79..94544fafe 100644
--- a/pom.xml
+++ b/pom.xml
@@ -19,7 +19,6 @@
 	</scm>
 	<properties>
 		<java.version>1.7</java.version>
-		<disable.checks>true</disable.checks>
 	</properties>
 	<dependencyManagement>
 		<dependencies>
@@ -51,9 +50,6 @@
 					<groupId>org.apache.maven.plugins</groupId>
 					<artifactId>maven-checkstyle-plugin</artifactId>
 					<version>2.17</version>
-					<configuration>
-						<configLocation>src/checkstyle/checkstyle.xml</configLocation>
-					</configuration>
 					<dependencies>
 						<dependency>
 							<groupId>com.puppycrawl.tools</groupId>
@@ -87,7 +83,6 @@
 						<id>checkstyle-validation</id>
 						<phase>validate</phase>
 						<configuration>
-							<skip>${disable.checks}</skip>
 							<configLocation>src/checkstyle/checkstyle.xml</configLocation>
 							<headerLocation>src/checkstyle/checkstyle-header.txt</headerLocation>
 							<propertyExpansion>checkstyle.build.directory=${project.build.directory}</propertyExpansion>