From c8154203058a5c1d046cc24ce772ecfb011f3dde Mon Sep 17 00:00:00 2001 From: Ilayaperumal Gopinathan Date: Fri, 15 Apr 2016 19:28:21 +0530 Subject: [PATCH] Cleanup todo items This resolves #485 --- .../binder/rabbit/RabbitMessageChannelBinder.java | 10 ---------- .../annotation/rxjava/SubjectMessageHandler.java | 1 - .../StreamListenerAnnotationBeanPostProcessor.java | 1 - 3 files changed, 12 deletions(-) diff --git a/spring-cloud-stream-binders/spring-cloud-stream-binder-rabbit/src/main/java/org/springframework/cloud/stream/binder/rabbit/RabbitMessageChannelBinder.java b/spring-cloud-stream-binders/spring-cloud-stream-binder-rabbit/src/main/java/org/springframework/cloud/stream/binder/rabbit/RabbitMessageChannelBinder.java index b6e201e3b..57415a359 100644 --- a/spring-cloud-stream-binders/spring-cloud-stream-binder-rabbit/src/main/java/org/springframework/cloud/stream/binder/rabbit/RabbitMessageChannelBinder.java +++ b/spring-cloud-stream-binders/spring-cloud-stream-binder-rabbit/src/main/java/org/springframework/cloud/stream/binder/rabbit/RabbitMessageChannelBinder.java @@ -28,7 +28,6 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; import org.springframework.amqp.AmqpConnectException; -import org.springframework.amqp.UncategorizedAmqpException; import org.springframework.amqp.core.AnonymousQueue; import org.springframework.amqp.core.BindingBuilder; import org.springframework.amqp.core.DirectExchange; @@ -490,15 +489,6 @@ public class RabbitMessageChannelBinder extends AbstractBinder message) throws Exception { subject.onNext(message.getPayload()); } diff --git a/spring-cloud-stream/src/main/java/org/springframework/cloud/stream/binding/StreamListenerAnnotationBeanPostProcessor.java b/spring-cloud-stream/src/main/java/org/springframework/cloud/stream/binding/StreamListenerAnnotationBeanPostProcessor.java index c4498236f..7ab657620 100644 --- a/spring-cloud-stream/src/main/java/org/springframework/cloud/stream/binding/StreamListenerAnnotationBeanPostProcessor.java +++ b/spring-cloud-stream/src/main/java/org/springframework/cloud/stream/binding/StreamListenerAnnotationBeanPostProcessor.java @@ -97,7 +97,6 @@ public class StreamListenerAnnotationBeanPostProcessor implements BeanPostProces " already existing for " + mappedBindings.get(streamListener.value()).getShortLogMessage()); } mappedBindings.put(streamListener.value(), invocableHandlerMethod); - // TODO: support pollable channels https://github.com/spring-cloud/spring-cloud-stream/issues/436 SubscribableChannel channel = applicationContext.getBean(streamListener.value(), SubscribableChannel.class); final String defaultOutputChannel = extractDefaultOutput(method);