From 94f76b903fb0333a52e241b43c6eb5d16e88e931 Mon Sep 17 00:00:00 2001 From: Soby Chacko Date: Mon, 26 Aug 2019 17:08:01 -0400 Subject: [PATCH 1/2] Additional docs for dlq producer properties Resolves #657 --- docs/src/main/asciidoc/overview.adoc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/src/main/asciidoc/overview.adoc b/docs/src/main/asciidoc/overview.adoc index eba2fd4a2..c34af075b 100644 --- a/docs/src/main/asciidoc/overview.adoc +++ b/docs/src/main/asciidoc/overview.adoc @@ -223,6 +223,8 @@ Default: null (If not specified, messages that result in errors are forwarded to dlqProducerProperties:: Using this, DLQ-specific producer properties can be set. All the properties available through kafka producer properties can be set through this property. +When native decoding is enabled on the consumer, the application must provide corresponding key/value serializers for DLQ. +This must be provided in the form of `dlqProducerProperties.configuration.key.serializer` and `dlqProducerProperties.configuration.value.serializer`. + Default: Default Kafka producer properties. standardHeaders:: From 413cc4d2b5eedf115a8d34050737109abc51f1af Mon Sep 17 00:00:00 2001 From: Soby Chacko Date: Tue, 27 Aug 2019 17:37:33 -0400 Subject: [PATCH 2/2] Addressing PR review --- docs/src/main/asciidoc/overview.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/src/main/asciidoc/overview.adoc b/docs/src/main/asciidoc/overview.adoc index c34af075b..c6726d3f6 100644 --- a/docs/src/main/asciidoc/overview.adoc +++ b/docs/src/main/asciidoc/overview.adoc @@ -223,7 +223,7 @@ Default: null (If not specified, messages that result in errors are forwarded to dlqProducerProperties:: Using this, DLQ-specific producer properties can be set. All the properties available through kafka producer properties can be set through this property. -When native decoding is enabled on the consumer, the application must provide corresponding key/value serializers for DLQ. +When native decoding is enabled on the consumer (i.e., useNativeDecoding: true) , the application must provide corresponding key/value serializers for DLQ. This must be provided in the form of `dlqProducerProperties.configuration.key.serializer` and `dlqProducerProperties.configuration.value.serializer`. + Default: Default Kafka producer properties.