SpringCloud/spring-cloud-task
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Added More tests.

Browse Source
This commit is contained in:
Glenn Renfro
2016-10-26 15:27:45 -04:00
parent 1611c28768
commit eff83a1897
5 changed files with 76 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
spring-cloud-task-stream/src/main/java/org/springframework/cloud/task/launcher/TaskLaunchRequest.java
View File

@@ -114,23 +114,23 @@ public class TaskLaunchRequest implements Serializable{
if (!uri.equals(that.uri)){
return false;
}
if (!(commandlineArguments != null ? commandlineArguments.equals(that.commandlineArguments) : that.commandlineArguments == null)){
if (!commandlineArguments.equals(that.commandlineArguments)){
return false;
}
if(!(deploymentProperties != null ? deploymentProperties.equals(that.deploymentProperties) : that.deploymentProperties == null))
if(!deploymentProperties.equals(that.deploymentProperties))
{
return false;
}
return environmentProperties != null ? environmentProperties.equals(that.environmentProperties) : that.environmentProperties == null;
return environmentProperties.equals(that.environmentProperties);
}
@Override
public int hashCode() {
int result = uri != null ? uri.hashCode() : 0;
result = 31 * result + (commandlineArguments != null ? commandlineArguments.hashCode() : 0);
result = 31 * result + (environmentProperties != null ? environmentProperties.hashCode() : 0);
result = 31 * result + (deploymentProperties != null ? deploymentProperties.hashCode() : 0);
int result = uri.hashCode();
result = 31 * result + commandlineArguments.hashCode();
result = 31 * result + environmentProperties.hashCode();
result = 31 * result + deploymentProperties.hashCode();
return result;
}
}

8
spring-cloud-task-stream/src/test/java/org/springframework/cloud/task/launcher/TaskLaunchRequestTests.java
View File

@@ -24,6 +24,7 @@ import java.util.Map;
import org.junit.Test;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;
@@ -49,6 +50,7 @@ public class TaskLaunchRequestTests {
Collections.EMPTY_MAP,
Collections.EMPTY_MAP);
assertFalse(request.equals(null));
assertFalse(request.equals("nope"));
assertTrue(request.equals(request));
assertTrue(request.equals(request2));
TaskLaunchRequest requestDiff = new TaskLaunchRequest("http://oops",
@@ -63,6 +65,10 @@ public class TaskLaunchRequestTests {
Collections.EMPTY_MAP);
assertFalse(request.equals(requestDiff));
requestDiff = new TaskLaunchRequest(URI,
null, null, null);
assertTrue(request.equals(requestDiff));
requestDiff = new TaskLaunchRequest(URI,
Collections.EMPTY_LIST,
map,
@@ -75,5 +81,7 @@ public class TaskLaunchRequestTests {
map);
assertFalse(request.equals(requestDiff));
assertEquals(request.hashCode(), request.hashCode());
}
}