Commit Graph

41 Commits

Author SHA1 Message Date
Glenn Renfro
c7ef7fbff4 Starting to move to java 11[Do Not Merge]
All version changes are present.

Fixed all Java-Doc Errors and warnings

* Due to the stricter nature of the javadoc compiler we can't wrap <ul> / <ui> in <p>
* We will also need to Push up a test app for taklauncher to work with.   The old one fails to start now.   Or use one of the task starters possibly.
* Built on the work from TASK-439C.   Wait for that merge before merging this one.
* Replaced applicationFailedEvent class attribute with applicaitonFailedException
* Also polished the app used by the taskLauncherSink integration test
2018-11-01 15:23:17 -04:00
Michael Minella
90c88c52e6 Polish 2018-11-01 10:45:15 -05:00
Glenn Renfro
d2bc2530cc Update Task to BOOT 2.1.M1
Migrating to use ApplicationContextRunner or ImportAutoConfiguration with SpringApp.run, instead of SpringApplicationBuilder, because builder does not handle AutoConfiguration properly

SimpleTaskAutoConfiguration now has an annotation AutoConfigureBefore the BatchTaskAutoConfig so that it is processed prior.  THis is so that that BatchTaskAutoConfig can create the appropriate beans

SimpleTaskAutoConfiguration has new annotations so that it is AutoConfigured after BindingServiceConfiguration and after SimpleTaskAutoConfiguration.  This is so that it does not attempt to start emitting messages before stream is ready and it can create the appropriate beans after SimpleTaskAutoConfiguration has run.

Renamed SimpleTaskConfiguration to SimpleTaskAutoConfiguration.

Task version updated to  2.1.0

Added missing headers

Updated documentation.

Deprecated EnableTask

Added ability to disable Task autoconfiguration.

Removed @EnableTask from tests

Resolves #439
Resolves #440
Resolves #448
Resolves #466
2018-11-01 10:43:31 -05:00
Glenn Renfro
d2c90c5256 Updated to add metadata for Conditionals
Also renamed camel-cased properties to cononical format.

resolves #442
2018-10-26 09:42:14 +01:00
Michael Minella
71b74665a0 Polish 2018-02-13 11:49:56 -06:00
Glenn Renfro
01311e8be6 FactoryBean now sets the tablePrefix for taskBatchExecutionListener
resolves #353
2018-02-13 11:49:48 -06:00
Michael Minella
6426cfea7e Polish 2018-02-13 09:28:22 -06:00
Glenn Renfro
76309b89ff Removed code that was marked as deprecated.
Also updated test that tested deprecated code.

resolves #366
2018-02-13 09:28:09 -06:00
Michael Minella
1ae7930d09 Added ability to cofigure CommandLineRunner order
This commit adds the ability to configure the order for the
TaskJobLauncherCommandLineRunner.  It also provides minor polish on a
few other code review related items.
2018-02-12 17:03:48 -06:00
Glenn Renfro
cd4dbe6a93 Allows failed batch apps to set exit code of task app.
resolves #201
 Please enter the commit message for your changes. Lines starting

Cleanup Removed taskProperties from TaskBatchAutoConfiguration
2018-02-12 17:03:36 -06:00
Glenn Renfro
b6f6d68385 Deprecate the use of spring.cloud.task.batch.listener.enable
replace it with spring.cloud.task.batch.listener.enabled

resolves #379
2018-02-12 13:41:59 -06:00
Glenn Renfro
3ad9efe3fe Updated tests to remove deprecated code from tests
* cleanup removing unused headers
* Updated asserts in code base that needed messages (marked as deprecated)
* left one test that was testing a deprecated constructor.  When that code is removed we can remove that test.
* some other cleanup

resolves #338
2018-01-18 11:42:37 -06:00
Glenn Renfro
d95f46002f Migrate Task to Spring Cloud Build 2.0.x
resolves #313
2017-07-12 11:38:00 -05:00
Glenn Renfro
68307a9312 Updated deployer dependencies to 1.2.1.RELEASE
Also updated the docs
2017-06-27 10:16:10 -05:00
Michael Minella
3b8670e765 Provided the ability to configure if properites are sent to the worker
via command line arguments or environment variables.
2017-06-23 13:08:14 -05:00
Glenn Renfro
bbb0d68ce6 Moved the injection of the TaskBatchListner to the postProcessAfterInitialization from postProcessBeforeInitialization
Because when using FactoryBeans  the TaskBatchListener postprocessing isn't fired when using before initialization
2017-04-10 14:37:04 -04:00
Michael Minella
48af5e5b32 Added TaskExecutionListenerSupport
This commit adds the TaskExecutionListenerSupport, a no-op
implementation of the TaskExecutionListner. This allows a user to extend
the TaskExecutionListenerSupport and simply override what they need
instead of implementing all of the methods.
2017-02-10 14:16:11 -06:00
Michael Minella
1d1a935f46 Add appending capabilities to the SimpleCommandLineArgsProvider
Adds the ability to add a list of command line arguments to the existing
ones.

Resolves #279
2017-02-10 13:45:55 -06:00
Glenn Renfro
acaaad89f3 Adds support for Task Execution Parent Ids
resolves #261
2017-01-20 14:47:12 -06:00
Michael Minella
3d1ee18db3 Minor polish 2017-01-06 12:54:38 -06:00
Glenn Renfro
10bb457a5a Allows user to set table prefix via properties.
resolves #244
2017-01-06 12:54:30 -06:00
Glenn Renfro
1185421803 TaskBatchAutoConfiguration now uses datasource from TaskConfigurer
resovles #252
2016-12-20 19:25:26 -06:00
Glenn Renfro
7a30a3357b Replace : separators for spring.cloud.task.name to _ for partitions
resolves #242
2016-11-16 13:31:36 -06:00
Glenn Renfro
44b3531824 Removed un-necessary test 2016-11-01 20:30:09 -04:00
Glenn Renfro
eff83a1897 Added More tests. 2016-11-01 17:32:22 -04:00
Glenn Renfro
1611c28768 Adding a few more tests.
Added unit tests to classes that had no coverage.
Added unit tests to classes bump up coverage.
2016-11-01 17:32:22 -04:00
Michael Minella
17e4250586 Checks for invalid ExecutionId in the TaskLifeCycleListener
resolves #115
* Fixes bug where if the user set the environment variable and commandline args a unique constraint would fire.
* Updated docs
* Removed deprecation
* Fixed version number for integration test.

Added integration tests for externally generated task executions

Add externalExecutionId

resolves #80
2016-10-12 12:45:29 -05:00
Michael Minella
025c447b89 Refactored for CloudFoundry Support
This commit adds on an abstraction for the providing unique command line
arugements for each worker.  It also updates the partitioned job sample
to be able to successfully be run on CloudFoundry.

Resolves spring-cloud/spring-cloud-task#193

Updated based on comments
2016-09-08 14:20:08 -04:00
Michael Minella
526dc41af9 Added abstraction for defining environment variables
When launching workers as separate tasks, it can be useful to be able to
use additional logic to define environment variables.  This commit
provides an abstraction to allow for the customization of environment
variables on a per worker basis as well as two useful implementations:

* A no-op implementation (returns an empty Map).
* An implementation that moves the current environment variable handling
* out of the `DeployerPartitionHandler`.

Resolves spring-cloud/spring-cloud-task#181
2016-07-22 10:29:36 -05:00
Michael Minella
57e9d4dcae Refactored dependency management
Created a Spring Boot starter that can be used to configure Spring Cloud
Task and it's related functionality.

Updates per code review

Removed autowiring of app context

Refactored DeployerPartitionHandler to correctly use environment variables

Exposed deployment properties of TaskLauncher

Exposed deployment properties via the TaskLaunchRequest

Updated based on code review
2016-07-06 16:15:13 -04:00
Glenn Renfro
15a1c168d0 Updated version numbers for deployers and fixed tests. 2016-06-28 22:55:16 -04:00
Michael Minella
77fdfbdbc0 Refactored the use of the name parameters to be arguments
This PR refactors the use of the term parameters to arguments to be
consistent with how the component is utilized within Spring Cloud Data
Flow.
2016-06-09 09:39:14 -05:00
Glenn Renfro
df14546a7f SCT-139 Exception info and error codes will be recorded for the task
resolves spring-cloud/spring-cloud-task#139
2016-05-20 09:57:23 -05:00
Ilayaperumal Gopinathan
9a073631f1 Modify poll interval assertion in DeployerPartitionHandlerTests
- Greater than 20s poll interval check in the assertion might as well needs to be equal to 20s interval as the test could finish before the next second
2016-04-08 11:16:50 -05:00
Michael Minella
d810601708 Added message for debugging timing issues in tests 2016-04-06 14:21:23 -05:00
Michael Minella
0a56672171 Refactored task end event to be Spring Boot's ApplicationReadyEvent
In testing and other use cases, the ability to keep a context open
beyond the end of a task can be useful.  This change provides the
ability to keep the context alive once a task has completed while also
explicitly shutting the context down (by default) once a task has ended.

Resolves spring-cloud/spring-cloud-task#102
2016-04-06 12:24:52 -05:00
Michael Minella
3d3b90812e Create the DeployerPartitionHandler and related
DeployerStepExecutionHandler

Created a PartitionHandler that delegates to a TaskLauncher from Spring
Cloud Deployer to execute workers.

Resolves spring-cloud/spring-cloud-task#109

Updates per code review
2016-04-04 11:01:03 -04:00
Glenn Renfro
695e71f6b9 Updated Per Code Review 2016-03-23 16:05:30 -04:00
Glenn Renfro
685e4aabee Changes to support putting SCDF back onto snapshot
* Only configure the BatchListener if the Job.class has a bean instance
* Add the task-batch to the task-dependencies pom.
2016-03-23 14:14:41 -04:00
Michael Minella
f35f8ef52d Update TaskLifecycleListener to use SmartLifecycle
This commit changes the starting point of a task from the point when the
ApplicationContext issues the ContextRefreshedEvent to
SmartLifecycle#start.  This is a more accurate point of start for a task
in that all beans should now be available.  It also allows us to clean
up many ApplicationContext hacks that were present to get around the
fact that many beans were not ready when a Task was attempting to begin.

Resolves spring-cloud/spring-cloud-task#107
2016-03-18 14:51:59 -04:00
Michael Minella
7c8fc5f50e Add listener to persist relationship between job and task
This introduces a listener that stores the association between a Spring
Batch job and the task it was executed within.

Resolves spring-cloud/spring-cloud-task#46

Merge Changes based on code review.
2016-03-11 09:16:59 -05:00