From 77a63f39fdaef8ecc564a9b3515ca3639fc0c883 Mon Sep 17 00:00:00 2001 From: Chris Bono Date: Wed, 6 Apr 2022 00:06:58 -0500 Subject: [PATCH] Polish "GH-248: Exclude Geode SSL config" * Add comments in tests about geode ssl flag verification --- .../cloud/fn/aggregator/DefaultAggregatorTests.java | 1 + .../GroupTimeOutAndGemfireMessageStoreAggregatorTests.java | 1 + .../cloud/fn/aggregator/JdbcMessageStoreAggregatorTests.java | 1 + 3 files changed, 3 insertions(+) diff --git a/function/aggregator-function/src/test/java/org/springframework/cloud/fn/aggregator/DefaultAggregatorTests.java b/function/aggregator-function/src/test/java/org/springframework/cloud/fn/aggregator/DefaultAggregatorTests.java index 024448eb..7af1cdad 100644 --- a/function/aggregator-function/src/test/java/org/springframework/cloud/fn/aggregator/DefaultAggregatorTests.java +++ b/function/aggregator-function/src/test/java/org/springframework/cloud/fn/aggregator/DefaultAggregatorTests.java @@ -65,6 +65,7 @@ public class DefaultAggregatorTests extends AbstractAggregatorFunctionTests { assertThat(this.messageGroupStore).isNull(); assertThat(this.aggregatingMessageHandler.getMessageStore()).isInstanceOf(SimpleMessageStore.class); + // Also verify geode ssl flag not enabled for default message store (non-geode) assertThat(this.geodeSslEnable).isFalse(); } diff --git a/function/aggregator-function/src/test/java/org/springframework/cloud/fn/aggregator/GroupTimeOutAndGemfireMessageStoreAggregatorTests.java b/function/aggregator-function/src/test/java/org/springframework/cloud/fn/aggregator/GroupTimeOutAndGemfireMessageStoreAggregatorTests.java index 8b043e6f..850a9ded 100644 --- a/function/aggregator-function/src/test/java/org/springframework/cloud/fn/aggregator/GroupTimeOutAndGemfireMessageStoreAggregatorTests.java +++ b/function/aggregator-function/src/test/java/org/springframework/cloud/fn/aggregator/GroupTimeOutAndGemfireMessageStoreAggregatorTests.java @@ -62,6 +62,7 @@ public class GroupTimeOutAndGemfireMessageStoreAggregatorTests extends AbstractA assertThat(this.messageGroupStore).isInstanceOf(GemfireMessageStore.class); assertThat(this.aggregatingMessageHandler.getMessageStore()).isSameAs(this.messageGroupStore); + // Also verify geode ssl flag enabled for geode message stores assertThat(this.geodeSslEnable).isTrue(); } diff --git a/function/aggregator-function/src/test/java/org/springframework/cloud/fn/aggregator/JdbcMessageStoreAggregatorTests.java b/function/aggregator-function/src/test/java/org/springframework/cloud/fn/aggregator/JdbcMessageStoreAggregatorTests.java index f11ccee4..ac87a5c5 100644 --- a/function/aggregator-function/src/test/java/org/springframework/cloud/fn/aggregator/JdbcMessageStoreAggregatorTests.java +++ b/function/aggregator-function/src/test/java/org/springframework/cloud/fn/aggregator/JdbcMessageStoreAggregatorTests.java @@ -68,6 +68,7 @@ public class JdbcMessageStoreAggregatorTests extends AbstractAggregatorFunctionT assertThat(this.aggregatingMessageHandler.getMessageStore()).isSameAs(this.messageGroupStore); + // Also verify geode ssl flag not enabled for non-geode message stores assertThat(this.geodeSslEnable).isFalse(); }