Commit 01c9d726 authored by Phillip Webb's avatar Phillip Webb

Polish

parent d1a48733
...@@ -60,7 +60,8 @@ public class InfoEndpoint extends AbstractEndpoint<Info> { ...@@ -60,7 +60,8 @@ public class InfoEndpoint extends AbstractEndpoint<Info> {
/** /**
* Return additional information to include in the output. * Return additional information to include in the output.
* @return additional information * @return additional information
* @deprecated define an additional {@link InfoContributor} bean instead. * @deprecated as of 1.4 in favor of defining an additional {@link InfoContributor}
* bean.
*/ */
@Deprecated @Deprecated
protected Map<String, Object> getAdditionalInfo() { protected Map<String, Object> getAdditionalInfo() {
......
...@@ -181,8 +181,8 @@ public class RabbitAutoConfiguration { ...@@ -181,8 +181,8 @@ public class RabbitAutoConfiguration {
} }
private boolean determineMandatoryFlag() { private boolean determineMandatoryFlag() {
Boolean flag = this.properties.getTemplate().getMandatory(); Boolean mandatory = this.properties.getTemplate().getMandatory();
return (flag != null ? flag : this.properties.isPublisherReturns()); return (mandatory != null ? mandatory : this.properties.isPublisherReturns());
} }
private RetryTemplate createRetryTemplate(RabbitProperties.Retry properties) { private RetryTemplate createRetryTemplate(RabbitProperties.Retry properties) {
......
...@@ -71,7 +71,7 @@ public class ActiveMQProperties { ...@@ -71,7 +71,7 @@ public class ActiveMQProperties {
/** /**
* Get if pooling is enabled. * Get if pooling is enabled.
* @return if pooling is enabled * @return if pooling is enabled
* @deprecated since 1.4 in favor of "spring.activemq.pool.enabled" * @deprecated as of 1.4 in favor of "spring.activemq.pool.enabled"
*/ */
@Deprecated @Deprecated
@DeprecatedConfigurationProperty(replacement = "spring.activemq.pool.enabled") @DeprecatedConfigurationProperty(replacement = "spring.activemq.pool.enabled")
...@@ -82,7 +82,7 @@ public class ActiveMQProperties { ...@@ -82,7 +82,7 @@ public class ActiveMQProperties {
/** /**
* Set if pooling is enabled. * Set if pooling is enabled.
* @param pooled the pooling enabled value * @param pooled the pooling enabled value
* @deprecated since 1.4 in favor of "spring.activemq.pool.enabled" * @deprecated as of 1.4 in favor of "spring.activemq.pool.enabled"
*/ */
@Deprecated @Deprecated
public void setPooled(boolean pooled) { public void setPooled(boolean pooled) {
......
...@@ -33,7 +33,7 @@ import org.springframework.core.annotation.AliasFor; ...@@ -33,7 +33,7 @@ import org.springframework.core.annotation.AliasFor;
* *
* @author Phillip Webb * @author Phillip Webb
* @since 1.3.0 * @since 1.3.0
* @deprecated since 1.4.0 in favor of * @deprecated as of 1.4 in favor of
* {@link org.springframework.boot.autoconfigure.ImportAutoConfiguration} * {@link org.springframework.boot.autoconfigure.ImportAutoConfiguration}
*/ */
@Target(ElementType.TYPE) @Target(ElementType.TYPE)
......
...@@ -16,6 +16,6 @@ ...@@ -16,6 +16,6 @@
/** /**
* Test utilities related to auto-configuration. * Test utilities related to auto-configuration.
* @deprecated in 1.4.0 in favor of the {@code spring-boot-test-autoconfigure} module * @deprecated as of 1.4 in favor of the {@code spring-boot-test-autoconfigure} module
*/ */
package org.springframework.boot.autoconfigure.test; package org.springframework.boot.autoconfigure.test;
...@@ -55,7 +55,7 @@ import org.springframework.web.servlet.view.velocity.VelocityConfigurer; ...@@ -55,7 +55,7 @@ import org.springframework.web.servlet.view.velocity.VelocityConfigurer;
* @author Andy Wilkinson * @author Andy Wilkinson
* @author Brian Clozel * @author Brian Clozel
* @since 1.1.0 * @since 1.1.0
* @deprecated In 1.4.0 following the deprecation of Velocity support in Spring Framework * @deprecated as of 1.4 following the deprecation of Velocity support in Spring Framework
* 4.3 * 4.3
*/ */
@Configuration @Configuration
......
/* /*
* Copyright 2012-2014 the original author or authors. * Copyright 2012-2016 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
...@@ -28,7 +28,7 @@ import org.springframework.web.servlet.view.velocity.VelocityViewResolver; ...@@ -28,7 +28,7 @@ import org.springframework.web.servlet.view.velocity.VelocityViewResolver;
* *
* @author Andy Wilkinson * @author Andy Wilkinson
* @since 1.1.0 * @since 1.1.0
* @deprecated In 1.4.0 following the deprecation of Velocity support in Spring Framework * @deprecated as of 1.4 following the deprecation of Velocity support in Spring Framework
* 4.3 * 4.3
*/ */
@Deprecated @Deprecated
......
/* /*
* Copyright 2012-2015 the original author or authors. * Copyright 2012-2016 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
...@@ -29,7 +29,7 @@ import org.springframework.util.ClassUtils; ...@@ -29,7 +29,7 @@ import org.springframework.util.ClassUtils;
* *
* @author Andy Wilkinson * @author Andy Wilkinson
* @since 1.1.0 * @since 1.1.0
* @deprecated In 1.4.0 following the deprecation of Velocity support in Spring Framework * @deprecated as of 1.4 following the deprecation of Velocity support in Spring Framework
* 4.3 * 4.3
*/ */
@Deprecated @Deprecated
......
...@@ -384,8 +384,8 @@ public class RabbitAutoConfigurationTests { ...@@ -384,8 +384,8 @@ public class RabbitAutoConfigurationTests {
@SuppressWarnings("unchecked") @SuppressWarnings("unchecked")
private boolean getMandatory(RabbitTemplate rabbitTemplate) { private boolean getMandatory(RabbitTemplate rabbitTemplate) {
ValueExpression<Boolean> expression = (ValueExpression<Boolean>) ValueExpression<Boolean> expression = (ValueExpression<Boolean>) new DirectFieldAccessor(
new DirectFieldAccessor(rabbitTemplate).getPropertyValue("mandatoryExpression"); rabbitTemplate).getPropertyValue("mandatoryExpression");
return expression.getValue(); return expression.getValue();
} }
......
...@@ -47,71 +47,61 @@ import org.springframework.transaction.annotation.EnableTransactionManagement; ...@@ -47,71 +47,61 @@ import org.springframework.transaction.annotation.EnableTransactionManagement;
@EnableConfigurationProperties(SampleDataGemFireProperties.class) @EnableConfigurationProperties(SampleDataGemFireProperties.class)
public class SampleDataGemFireApplication { public class SampleDataGemFireApplication {
protected static final String GEMSTONES_REGION_NAME = "Gemstones"; private static final String GEMSTONES_REGION_NAME = "Gemstones";
private final SampleDataGemFireProperties applicationProperties; private final SampleDataGemFireProperties properties;
public SampleDataGemFireApplication(SampleDataGemFireProperties applicationProperties) { public SampleDataGemFireApplication(
this.applicationProperties = applicationProperties; SampleDataGemFireProperties applicationProperties) {
this.properties = applicationProperties;
} }
public static void main(final String[] args) {
SpringApplication.run(SampleDataGemFireApplication.class, args);
}
@Bean @Bean
CacheFactoryBean gemfireCache() { public CacheFactoryBean gemfireCache() {
CacheFactoryBean gemfireCache = new CacheFactoryBean(); CacheFactoryBean cache = new CacheFactoryBean();
cache.setClose(true);
gemfireCache.setClose(true); cache.setProperties(getCacheProperties());
gemfireCache.setProperties(gemfireProperties()); return cache;
return gemfireCache;
} }
private Properties gemfireProperties() { private Properties getCacheProperties() {
Properties gemfireProperties = new Properties(); Properties properties = new Properties();
properties.setProperty("name",
gemfireProperties.setProperty("name", SampleDataGemFireApplication.class.getSimpleName()); SampleDataGemFireApplication.class.getSimpleName());
gemfireProperties.setProperty("mcast-port", "0"); properties.setProperty("mcast-port", "0");
gemfireProperties.setProperty("locators", ""); properties.setProperty("locators", "");
gemfireProperties.setProperty("log-level", this.applicationProperties.getLogLevel()); properties.setProperty("log-level", this.properties.getLogLevel());
return properties;
return gemfireProperties;
} }
@Bean(name = GEMSTONES_REGION_NAME) @Bean(name = GEMSTONES_REGION_NAME)
ReplicatedRegionFactoryBean<Long, Gemstone> gemstonesRegion(Cache gemfireCache, public ReplicatedRegionFactoryBean<Long, Gemstone> gemstonesRegion(Cache cache,
RegionAttributes<Long, Gemstone> gemstonesRegionAttributes) { RegionAttributes<Long, Gemstone> attributes) {
ReplicatedRegionFactoryBean<Long, Gemstone> region = new ReplicatedRegionFactoryBean<Long, Gemstone>();
ReplicatedRegionFactoryBean<Long, Gemstone> gemstonesRegion = region.setAttributes(attributes);
new ReplicatedRegionFactoryBean<Long, Gemstone>(); region.setClose(false);
region.setCache(cache);
gemstonesRegion.setAttributes(gemstonesRegionAttributes); region.setName(GEMSTONES_REGION_NAME);
gemstonesRegion.setClose(false); region.setPersistent(false);
gemstonesRegion.setCache(gemfireCache); return region;
gemstonesRegion.setName(GEMSTONES_REGION_NAME);
gemstonesRegion.setPersistent(false);
return gemstonesRegion;
} }
@Bean @Bean
@SuppressWarnings("unchecked") @SuppressWarnings({ "unchecked", "deprecation" })
RegionAttributesFactoryBean gemstonesRegionAttributes() { public RegionAttributesFactoryBean gemstonesRegionAttributes() {
RegionAttributesFactoryBean gemstonesRegionAttributes = RegionAttributesFactoryBean attributes = new RegionAttributesFactoryBean();
new RegionAttributesFactoryBean(); attributes.setKeyConstraint(Long.class);
attributes.setValueConstraint(Gemstone.class);
gemstonesRegionAttributes.setKeyConstraint(Long.class); return attributes;
gemstonesRegionAttributes.setValueConstraint(Gemstone.class);
return gemstonesRegionAttributes;
} }
@Bean @Bean
GemfireTransactionManager gemfireTransactionManager(Cache gemfireCache) { public GemfireTransactionManager gemfireTransactionManager(Cache gemfireCache) {
return new GemfireTransactionManager(gemfireCache); return new GemfireTransactionManager(gemfireCache);
} }
public static void main(final String[] args) {
SpringApplication.run(SampleDataGemFireApplication.class, args);
}
} }
...@@ -18,6 +18,7 @@ package sample.data.gemfire.domain; ...@@ -18,6 +18,7 @@ package sample.data.gemfire.domain;
import java.io.Serializable; import java.io.Serializable;
import org.springframework.core.style.ToStringCreator;
import org.springframework.data.annotation.Id; import org.springframework.data.annotation.Id;
import org.springframework.data.gemfire.mapping.Region; import org.springframework.data.gemfire.mapping.Region;
import org.springframework.util.ObjectUtils; import org.springframework.util.ObjectUtils;
...@@ -39,11 +40,11 @@ public class Gemstone implements Serializable { ...@@ -39,11 +40,11 @@ public class Gemstone implements Serializable {
public Gemstone() { public Gemstone() {
} }
public Gemstone(final Long id) { public Gemstone(Long id) {
this.id = id; this.id = id;
} }
public Gemstone(final Long id, final String name) { public Gemstone(Long id, String name) {
this.id = id; this.id = id;
this.name = name; this.name = name;
} }
...@@ -52,7 +53,7 @@ public class Gemstone implements Serializable { ...@@ -52,7 +53,7 @@ public class Gemstone implements Serializable {
return this.id; return this.id;
} }
public void setId(final Long id) { public void setId(Long id) {
this.id = id; this.id = id;
} }
...@@ -60,36 +61,32 @@ public class Gemstone implements Serializable { ...@@ -60,36 +61,32 @@ public class Gemstone implements Serializable {
return this.name; return this.name;
} }
public void setName(final String name) { public void setName(String name) {
this.name = name; this.name = name;
} }
@Override @Override
public boolean equals(final Object obj) { public boolean equals(Object obj) {
if (obj == this) { if (obj == this) {
return true; return true;
} }
if (obj == null || !obj.getClass().equals(getClass())) {
if (!(obj instanceof Gemstone)) {
return false; return false;
} }
return ObjectUtils.nullSafeEquals(this.getName(), ((Gemstone) obj).getName());
Gemstone that = (Gemstone) obj;
return ObjectUtils.nullSafeEquals(this.getName(), that.getName());
} }
@Override @Override
public int hashCode() { public int hashCode() {
int hashValue = 17; return ObjectUtils.nullSafeHashCode(getName());
hashValue = 37 * hashValue + ObjectUtils.nullSafeHashCode(getName());
return hashValue;
} }
@Override @Override
public String toString() { public String toString() {
return String.format("{ @type = %1$s, id = %2$d, name = %3$s }", ToStringCreator creator = new ToStringCreator(this);
getClass().getName(), getId(), getName()); creator.append("id", this.id);
creator.append("name", this.name);
return creator.toString();
} }
} }
...@@ -16,15 +16,14 @@ ...@@ -16,15 +16,14 @@
package sample.data.gemfire.service; package sample.data.gemfire.service;
import java.util.ArrayList;
import java.util.Arrays; import java.util.Arrays;
import java.util.Collections;
import java.util.List; import java.util.List;
import javax.annotation.PostConstruct; import javax.annotation.PostConstruct;
import sample.data.gemfire.domain.Gemstone; import sample.data.gemfire.domain.Gemstone;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.stereotype.Service; import org.springframework.stereotype.Service;
import org.springframework.transaction.annotation.Transactional; import org.springframework.transaction.annotation.Transactional;
import org.springframework.util.Assert; import org.springframework.util.Assert;
...@@ -39,14 +38,18 @@ import org.springframework.util.Assert; ...@@ -39,14 +38,18 @@ import org.springframework.util.Assert;
@Service("gemstoneService") @Service("gemstoneService")
public class GemstoneServiceImpl implements GemstoneService { public class GemstoneServiceImpl implements GemstoneService {
protected static final List<String> APPROVED_GEMS = new ArrayList<String>( protected static final List<String> APPROVED_GEMS;
Arrays.asList("ALEXANDRITE", "AQUAMARINE", "DIAMOND", "OPAL", "PEARL", "RUBY",
"SAPPHIRE", "SPINEL", "TOPAZ"));
private final GemstoneRepository gemstoneRepository; static {
APPROVED_GEMS = Collections.unmodifiableList(
Arrays.asList("ALEXANDRITE,AQUAMARINE,DIAMOND,OPAL,PEARL,"
+ "RUBY,SAPPHIRE,SPINEL,TOPAZ".split(",")));
}
private final GemstoneRepository repository;
public GemstoneServiceImpl(GemstoneRepository gemstoneRepository) { public GemstoneServiceImpl(GemstoneRepository gemstoneRepository) {
this.gemstoneRepository = gemstoneRepository; this.repository = gemstoneRepository;
} }
@PostConstruct @PostConstruct
...@@ -56,20 +59,16 @@ public class GemstoneServiceImpl implements GemstoneService { ...@@ -56,20 +59,16 @@ public class GemstoneServiceImpl implements GemstoneService {
/** /**
* Returns a count of the number of Gemstones in the GemFire Cache. * Returns a count of the number of Gemstones in the GemFire Cache.
* <p/>
*
* @return a long value indicating the number of Gemstones in the GemFire Cache. * @return a long value indicating the number of Gemstones in the GemFire Cache.
*/ */
@Override @Override
@Transactional(readOnly = true) @Transactional(readOnly = true)
public long count() { public long count() {
return this.gemstoneRepository.count(); return this.repository.count();
} }
/** /**
* Gets a Gemstone by ID. * Gets a Gemstone by ID.
* <p/>
*
* @param id a long value indicating the identifier of the Gemstone. * @param id a long value indicating the identifier of the Gemstone.
* @return a Gemstone with ID, or null if no Gemstone exists with ID. * @return a Gemstone with ID, or null if no Gemstone exists with ID.
* @see sample.data.gemfire.domain.Gemstone * @see sample.data.gemfire.domain.Gemstone
...@@ -77,13 +76,11 @@ public class GemstoneServiceImpl implements GemstoneService { ...@@ -77,13 +76,11 @@ public class GemstoneServiceImpl implements GemstoneService {
@Override @Override
@Transactional(readOnly = true) @Transactional(readOnly = true)
public Gemstone get(Long id) { public Gemstone get(Long id) {
return this.gemstoneRepository.findOne(id); return this.repository.findOne(id);
} }
/** /**
* Gets a Gemstone by name. * Gets a Gemstone by name.
* <p/>
*
* @param name a String value indicating the name of the Gemstone. * @param name a String value indicating the name of the Gemstone.
* @return a Gemstone with name, or null if no Gemstone exists with name. * @return a Gemstone with name, or null if no Gemstone exists with name.
* @see sample.data.gemfire.domain.Gemstone * @see sample.data.gemfire.domain.Gemstone
...@@ -91,13 +88,11 @@ public class GemstoneServiceImpl implements GemstoneService { ...@@ -91,13 +88,11 @@ public class GemstoneServiceImpl implements GemstoneService {
@Override @Override
@Transactional(readOnly = true) @Transactional(readOnly = true)
public Gemstone get(String name) { public Gemstone get(String name) {
return this.gemstoneRepository.findByName(name); return this.repository.findByName(name);
} }
/** /**
* Return a listing of Gemstones currently stored in the GemFire Cache. * Return a listing of Gemstones currently stored in the GemFire Cache.
* <p/>
*
* @return an Iterable object to iterate over the list of Gemstones currently stored * @return an Iterable object to iterate over the list of Gemstones currently stored
* in the GemFire Cache. * in the GemFire Cache.
* @see java.lang.Iterable * @see java.lang.Iterable
...@@ -106,13 +101,11 @@ public class GemstoneServiceImpl implements GemstoneService { ...@@ -106,13 +101,11 @@ public class GemstoneServiceImpl implements GemstoneService {
@Override @Override
@Transactional(readOnly = true) @Transactional(readOnly = true)
public Iterable<Gemstone> list() { public Iterable<Gemstone> list() {
return this.gemstoneRepository.findAll(); return this.repository.findAll();
} }
/** /**
* Saves the specified Gemstone to the GemFire Cache. * Saves the specified Gemstone to the GemFire Cache.
* <p/>
*
* @param gemstone the Gemstone to save in the GemFire Cache. * @param gemstone the Gemstone to save in the GemFire Cache.
* @return the saved Gemstone. * @return the saved Gemstone.
* @see sample.data.gemfire.domain.Gemstone * @see sample.data.gemfire.domain.Gemstone
...@@ -122,17 +115,13 @@ public class GemstoneServiceImpl implements GemstoneService { ...@@ -122,17 +115,13 @@ public class GemstoneServiceImpl implements GemstoneService {
public Gemstone save(Gemstone gemstone) { public Gemstone save(Gemstone gemstone) {
Assert.notNull(gemstone, "The Gemstone to save must not be null!"); Assert.notNull(gemstone, "The Gemstone to save must not be null!");
Assert.notNull(gemstone.getName(), "The name of the Gemstone must be specified!"); Assert.notNull(gemstone.getName(), "The name of the Gemstone must be specified!");
// NOTE deliberately (& naively) validate the Gemstone after mutating data access
// NOTE deliberately (& naively) validate the Gemstone after mutating data access in // in GemFire rather than before to demonstrate transactions in GemFire.
// GemFire rather than before to demonstrate transactions in GemFire. Gemstone savedGemstone = validate(this.repository.save(gemstone));
Gemstone savedGemstone = validate(this.gemstoneRepository.save(gemstone)); Assert.state(savedGemstone.equals(get(gemstone.getId())),
String.format("Failed to find Gemstone (%1$s) in "
Assert.state(savedGemstone.equals(get(gemstone.getId())), String.format( + "GemFire's Cache Region 'Gemstones'!", gemstone));
"Failed to find Gemstone (%1$s) in GemFire's Cache Region 'Gemstones'!",
gemstone));
System.out.printf("Saved Gemstone [%1$s]%n", savedGemstone.getName()); System.out.printf("Saved Gemstone [%1$s]%n", savedGemstone.getName());
return gemstone; return gemstone;
} }
...@@ -144,16 +133,7 @@ public class GemstoneServiceImpl implements GemstoneService { ...@@ -144,16 +133,7 @@ public class GemstoneServiceImpl implements GemstoneService {
throw new IllegalGemstoneException( throw new IllegalGemstoneException(
String.format("[%1$s] is not a valid Gemstone!", gemstone.getName())); String.format("[%1$s] is not a valid Gemstone!", gemstone.getName()));
} }
return gemstone; return gemstone;
} }
public static final class IllegalGemstoneException extends IllegalArgumentException {
public IllegalGemstoneException(String message) {
super(message);
}
}
} }
/*
* Copyright 2012-2016 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package sample.data.gemfire.service;
/**
* Exception thrown from {@link GemstoneService}.
*
* @author John Blum
*/
public class IllegalGemstoneException extends IllegalArgumentException {
public IllegalGemstoneException(String message) {
super(message);
}
}
...@@ -22,7 +22,7 @@ import org.junit.Test; ...@@ -22,7 +22,7 @@ import org.junit.Test;
import org.junit.runner.RunWith; import org.junit.runner.RunWith;
import sample.data.gemfire.domain.Gemstone; import sample.data.gemfire.domain.Gemstone;
import sample.data.gemfire.service.GemstoneService; import sample.data.gemfire.service.GemstoneService;
import sample.data.gemfire.service.GemstoneServiceImpl.IllegalGemstoneException; import sample.data.gemfire.service.IllegalGemstoneException;
import org.springframework.beans.factory.annotation.Autowired; import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.test.context.SpringBootTest; import org.springframework.boot.test.context.SpringBootTest;
...@@ -40,54 +40,42 @@ import static org.assertj.core.api.Assertions.assertThat; ...@@ -40,54 +40,42 @@ import static org.assertj.core.api.Assertions.assertThat;
public class SampleDataGemFireApplicationTests { public class SampleDataGemFireApplicationTests {
@Autowired @Autowired
private GemstoneService gemstoneService; private GemstoneService service;
private final AtomicLong idGenerator = new AtomicLong(0L); private final AtomicLong idGenerator = new AtomicLong(0L);
@Test @Test
public void gemstonesAppServiceEndpoints() { public void gemstonesAppServiceEndpoints() {
assertThat(this.gemstoneService.count()).isEqualTo(0); assertThat(this.service.count()).isEqualTo(0);
assertThat(this.gemstoneService.list()).isEmpty(); assertThat(this.service.list()).isEmpty();
this.service.save(createGemstone("Diamond"));
this.gemstoneService.save(createGemstone("Diamond")); this.service.save(createGemstone("Ruby"));
this.gemstoneService.save(createGemstone("Ruby")); assertThat(this.service.count()).isEqualTo(2);
assertThat(this.service.list()).contains(getGemstones("Diamond", "Ruby"));
assertThat(this.gemstoneService.count()).isEqualTo(2);
assertThat(this.gemstoneService.list()).contains(
getGemstones("Diamond", "Ruby"));
try { try {
this.gemstoneService.save(createGemstone("Coal")); this.service.save(createGemstone("Coal"));
} }
catch (IllegalGemstoneException ignore) { catch (IllegalGemstoneException ignore) {
// expected // expected
} }
assertThat(this.service.count()).isEqualTo(2);
assertThat(this.gemstoneService.count()).isEqualTo(2); assertThat(this.service.list()).contains(getGemstones("Diamond", "Ruby"));
assertThat(this.gemstoneService.list()).contains( this.service.save(createGemstone("Pearl"));
getGemstones("Diamond", "Ruby")); this.service.save(createGemstone("Sapphire"));
assertThat(this.service.count()).isEqualTo(4);
this.gemstoneService.save(createGemstone("Pearl")); assertThat(this.service.list())
this.gemstoneService.save(createGemstone("Sapphire")); .contains(getGemstones("Diamond", "Ruby", "Pearl", "Sapphire"));
assertThat(this.gemstoneService.count()).isEqualTo(4);
assertThat(this.gemstoneService.list()).contains(
getGemstones("Diamond", "Ruby", "Pearl", "Sapphire"));
try { try {
this.gemstoneService.save(createGemstone("Quartz")); this.service.save(createGemstone("Quartz"));
} }
catch (IllegalGemstoneException ignore) { catch (IllegalGemstoneException ignore) {
// expected // expected
} }
assertThat(this.service.count()).isEqualTo(4);
assertThat(this.gemstoneService.count()).isEqualTo(4); assertThat(this.service.list())
assertThat(this.gemstoneService.list()).contains( .contains(getGemstones("Diamond", "Ruby", "Pearl", "Sapphire"));
getGemstones("Diamond", "Ruby", "Pearl", "Sapphire")); assertThat(this.service.get("Diamond")).isEqualTo(createGemstone("Diamond"));
assertThat(this.gemstoneService.get("Diamond")).isEqualTo( assertThat(this.service.get("Pearl")).isEqualTo(createGemstone("Pearl"));
createGemstone("Diamond"));
assertThat(this.gemstoneService.get("Pearl")).isEqualTo(
createGemstone("Pearl"));
} }
private Gemstone[] getGemstones(String... names) { private Gemstone[] getGemstones(String... names) {
......
...@@ -27,7 +27,7 @@ import org.springframework.test.context.ContextConfiguration; ...@@ -27,7 +27,7 @@ import org.springframework.test.context.ContextConfiguration;
* *
* @author Phillip Webb * @author Phillip Webb
* @see ConfigFileApplicationListener * @see ConfigFileApplicationListener
* @deprecated since 1.4.0 in favor of * @deprecated as of 1.4 in favor of
* {@link org.springframework.boot.test.context.ConfigFileApplicationContextInitializer} * {@link org.springframework.boot.test.context.ConfigFileApplicationContextInitializer}
*/ */
@Deprecated @Deprecated
......
...@@ -26,7 +26,7 @@ import org.springframework.core.env.Environment; ...@@ -26,7 +26,7 @@ import org.springframework.core.env.Environment;
* *
* @author Dave Syer * @author Dave Syer
* @author Stephane Nicoll * @author Stephane Nicoll
* @deprecated since 1.4.0 in favor of * @deprecated as of 1.4 in favor of
* {@link org.springframework.boot.test.util.EnvironmentTestUtils} * {@link org.springframework.boot.test.util.EnvironmentTestUtils}
*/ */
@Deprecated @Deprecated
......
...@@ -41,7 +41,7 @@ import org.springframework.test.context.transaction.TransactionalTestExecutionLi ...@@ -41,7 +41,7 @@ import org.springframework.test.context.transaction.TransactionalTestExecutionLi
* *
* @author Dave Syer * @author Dave Syer
* @see WebIntegrationTest * @see WebIntegrationTest
* @deprecated since 1.4.0 in favor of {@link SpringBootTest} * @deprecated as of 1.4 in favor of {@link SpringBootTest}
*/ */
@Documented @Documented
@Inherited @Inherited
......
...@@ -30,7 +30,7 @@ import org.springframework.test.util.ReflectionTestUtils; ...@@ -30,7 +30,7 @@ import org.springframework.test.util.ReflectionTestUtils;
* @author Dave Syer * @author Dave Syer
* @author Phillip Webb * @author Phillip Webb
* @since 1.2.0 * @since 1.2.0
* @deprecated since 1.4.0 as no longer used by {@code @IntegrationTest}. * @deprecated as of 1.4 as no longer used by {@code @IntegrationTest}.
*/ */
@Deprecated @Deprecated
public class IntegrationTestPropertiesListener extends AbstractTestExecutionListener { public class IntegrationTestPropertiesListener extends AbstractTestExecutionListener {
......
...@@ -27,7 +27,7 @@ import org.springframework.test.util.ReflectionTestUtils; ...@@ -27,7 +27,7 @@ import org.springframework.test.util.ReflectionTestUtils;
* Provides access to {@link MergedContextConfiguration} properties. * Provides access to {@link MergedContextConfiguration} properties.
* *
* @author Phillip Webb * @author Phillip Webb
* @deprecated since 1.4.0 along with {@link IntegrationTestPropertiesListener} * @deprecated as of 1.4 along with {@link IntegrationTestPropertiesListener}
*/ */
@Deprecated @Deprecated
class MergedContextConfigurationProperties { class MergedContextConfigurationProperties {
......
...@@ -21,7 +21,7 @@ package org.springframework.boot.test; ...@@ -21,7 +21,7 @@ package org.springframework.boot.test;
* *
* @author Phillip Webb * @author Phillip Webb
* @author Andy Wilkinson * @author Andy Wilkinson
* @deprecated since 1.4.0 in favor of * @deprecated as of 1.4 in favor of
* {@link org.springframework.boot.test.rule.OutputCapture} * {@link org.springframework.boot.test.rule.OutputCapture}
*/ */
@Deprecated @Deprecated
......
...@@ -41,7 +41,7 @@ import org.springframework.test.context.ContextConfiguration; ...@@ -41,7 +41,7 @@ import org.springframework.test.context.ContextConfiguration;
* @author Sam Brannen * @author Sam Brannen
* @see SpringBootContextLoader * @see SpringBootContextLoader
* @see ContextConfiguration * @see ContextConfiguration
* @deprecated since 1.4.0 in favor of {@link SpringBootTest} or direct use of * @deprecated as of 1.4 in favor of {@link SpringBootTest} or direct use of
* {@link SpringBootContextLoader}. * {@link SpringBootContextLoader}.
*/ */
@ContextConfiguration(loader = SpringBootContextLoader.class) @ContextConfiguration(loader = SpringBootContextLoader.class)
......
...@@ -70,10 +70,9 @@ import org.springframework.web.context.support.GenericWebApplicationContext; ...@@ -70,10 +70,9 @@ import org.springframework.web.context.support.GenericWebApplicationContext;
* @see org.springframework.boot.test.context.SpringBootTest * @see org.springframework.boot.test.context.SpringBootTest
* @see org.springframework.boot.test.IntegrationTest * @see org.springframework.boot.test.IntegrationTest
* @see org.springframework.boot.test.WebIntegrationTest * @see org.springframework.boot.test.WebIntegrationTest
* @deprecated since 1.4.0 in favor of * @deprecated as of 1.4 in favor of {@link SpringBootTest @SpringApplicationTest}
* {@link SpringBootTest @SpringApplicationTest} * {@link org.springframework.boot.test.context.SpringBootContextLoader} can also be
* {@link org.springframework.boot.test.context.SpringBootContextLoader} can also * considered if absolutely necessary.
* be considered if absolutely necessary.
*/ */
@Deprecated @Deprecated
public class SpringApplicationContextLoader extends AbstractContextLoader { public class SpringApplicationContextLoader extends AbstractContextLoader {
......
...@@ -25,7 +25,7 @@ import org.springframework.mock.web.MockServletContext; ...@@ -25,7 +25,7 @@ import org.springframework.mock.web.MockServletContext;
* found. * found.
* *
* @author Phillip Webb * @author Phillip Webb
* @deprecated since 1.4.0 in favor of * @deprecated as of 1.4 in favor of
* {@link org.springframework.boot.test.mock.web.SpringBootMockServletContext} * {@link org.springframework.boot.test.mock.web.SpringBootMockServletContext}
*/ */
@Deprecated @Deprecated
......
...@@ -26,7 +26,7 @@ import org.springframework.web.client.RestTemplate; ...@@ -26,7 +26,7 @@ import org.springframework.web.client.RestTemplate;
* *
* @author Dave Syer * @author Dave Syer
* @author Phillip Webb * @author Phillip Webb
* @deprecated since 1.4.0 in favor of * @deprecated as of 1.4 in favor of
* {@link org.springframework.boot.test.web.client.TestRestTemplate} * {@link org.springframework.boot.test.web.client.TestRestTemplate}
*/ */
@Deprecated @Deprecated
......
...@@ -29,7 +29,7 @@ import org.springframework.test.context.web.WebMergedContextConfiguration; ...@@ -29,7 +29,7 @@ import org.springframework.test.context.web.WebMergedContextConfiguration;
* *
* @author Phillip Webb * @author Phillip Webb
* @since 1.2.1 * @since 1.2.1
* @deprecated Since 1.4.0 * @deprecated as of 1.4 along with {@link WebIntegrationTest}
*/ */
@Deprecated @Deprecated
class WebAppIntegrationTestContextBootstrapper extends DefaultTestContextBootstrapper { class WebAppIntegrationTestContextBootstrapper extends DefaultTestContextBootstrapper {
......
...@@ -39,7 +39,7 @@ import org.springframework.test.context.BootstrapWith; ...@@ -39,7 +39,7 @@ import org.springframework.test.context.BootstrapWith;
* @author Phillip Webb * @author Phillip Webb
* @since 1.2.1 * @since 1.2.1
* @see IntegrationTest * @see IntegrationTest
* @deprecated since 1.4.0 in favor of * @deprecated as of 1.4 in favor of
* {@link org.springframework.boot.test.context.SpringBootTest} with * {@link org.springframework.boot.test.context.SpringBootTest} with
* {@code webEnvironment=RANDOM_PORT} or {@code webEnvironment=DEFINED_PORT}. * {@code webEnvironment=RANDOM_PORT} or {@code webEnvironment=DEFINED_PORT}.
*/ */
......
...@@ -582,8 +582,8 @@ public class ConfigFileApplicationListener implements EnvironmentPostProcessor, ...@@ -582,8 +582,8 @@ public class ConfigFileApplicationListener implements EnvironmentPostProcessor,
} }
private Set<String> asResolvedSet(String value, String fallback) { private Set<String> asResolvedSet(String value, String fallback) {
List<String> list = Arrays List<String> list = Arrays.asList(StringUtils.trimArrayElements(
.asList(StringUtils.trimArrayElements(StringUtils.commaDelimitedListToStringArray(value != null StringUtils.commaDelimitedListToStringArray(value != null
? this.environment.resolvePlaceholders(value) : fallback))); ? this.environment.resolvePlaceholders(value) : fallback)));
Collections.reverse(list); Collections.reverse(list);
return new LinkedHashSet<String>(list); return new LinkedHashSet<String>(list);
......
...@@ -90,7 +90,7 @@ public @interface ConfigurationProperties { ...@@ -90,7 +90,7 @@ public @interface ConfigurationProperties {
* defined in the environment. * defined in the environment.
* @return the path (or paths) of resources to bind to * @return the path (or paths) of resources to bind to
* @see #merge() * @see #merge()
* @deprecated since 1.4 in favor of configuring the environment directly with * @deprecated as of 1.4 in favor of configuring the environment directly with
* additional locations * additional locations
*/ */
@Deprecated @Deprecated
...@@ -101,7 +101,7 @@ public @interface ConfigurationProperties { ...@@ -101,7 +101,7 @@ public @interface ConfigurationProperties {
* merged with the default configuration. * merged with the default configuration.
* @return the flag value (default true) * @return the flag value (default true)
* @see #locations() * @see #locations()
* @deprecated since 1.4 along with {@link #locations()} in favor of configuring the * @deprecated as of 1.4 along with {@link #locations()} in favor of configuring the
* environment directly with additional locations * environment directly with additional locations
*/ */
@Deprecated @Deprecated
......
/* /*
* Copyright 2012-2014 the original author or authors. * Copyright 2012-2016 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
...@@ -33,7 +33,7 @@ import org.springframework.util.StringUtils; ...@@ -33,7 +33,7 @@ import org.springframework.util.StringUtils;
* @author Phillip Webb * @author Phillip Webb
* @see "http://stackoverflow.com/questions/7689206/ejb3namingstrategy-vs-improvednamingstrategy-foreign-key-naming" * @see "http://stackoverflow.com/questions/7689206/ejb3namingstrategy-vs-improvednamingstrategy-foreign-key-naming"
* @since 1.2.0 * @since 1.2.0
* @deprecated since 1.4.0 since {@link NamingStrategy} is no longer used by * @deprecated as of 1.4 since {@link NamingStrategy} is no longer used by
* {@link Hibernate}. Consider using {@link SpringPhysicalNamingStrategy} * {@link Hibernate}. Consider using {@link SpringPhysicalNamingStrategy}
*/ */
@Deprecated @Deprecated
......
/* /*
* Copyright 2012-2015 the original author or authors. * Copyright 2012-2016 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
...@@ -26,7 +26,7 @@ import org.springframework.web.servlet.view.velocity.VelocityViewResolver; ...@@ -26,7 +26,7 @@ import org.springframework.web.servlet.view.velocity.VelocityViewResolver;
* *
* @author Phillip Webb * @author Phillip Webb
* @since 1.2.5 * @since 1.2.5
* @deprecated In 1.4.0 following the deprecation of Velocity support in Spring Framework * @deprecated as of 1.4 following the deprecation of Velocity support in Spring Framework
* 4.3 * 4.3
*/ */
@Deprecated @Deprecated
......
...@@ -534,14 +534,16 @@ public class ConfigFileApplicationListenerTests { ...@@ -534,14 +534,16 @@ public class ConfigFileApplicationListenerTests {
public void yamlSetsMultiProfiles() throws Exception { public void yamlSetsMultiProfiles() throws Exception {
this.initializer.setSearchNames("testsetmultiprofiles"); this.initializer.setSearchNames("testsetmultiprofiles");
this.initializer.postProcessEnvironment(this.environment, this.application); this.initializer.postProcessEnvironment(this.environment, this.application);
assertThat(this.environment.getActiveProfiles()).containsExactly("dev", "healthcheck"); assertThat(this.environment.getActiveProfiles()).containsExactly("dev",
"healthcheck");
} }
@Test @Test
public void yamlSetsMultiProfilesWithWithespace() throws Exception { public void yamlSetsMultiProfilesWithWithespace() throws Exception {
this.initializer.setSearchNames("testsetmultiprofileswhitespace"); this.initializer.setSearchNames("testsetmultiprofileswhitespace");
this.initializer.postProcessEnvironment(this.environment, this.application); this.initializer.postProcessEnvironment(this.environment, this.application);
assertThat(this.environment.getActiveProfiles()).containsExactly("dev", "healthcheck"); assertThat(this.environment.getActiveProfiles()).containsExactly("dev",
"healthcheck");
} }
@Test @Test
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment