Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in / Register
Toggle navigation
S
spring-boot
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
DEMO
spring-boot
Commits
251dbddc
Commit
251dbddc
authored
Jun 03, 2014
by
Dave Syer
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Use null instead of 'none' for ddlAuto
Fixes gh-1012
parent
56e70ca5
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
15 additions
and
7 deletions
+15
-7
DataSourceInitialization.java
...ork/boot/autoconfigure/jdbc/DataSourceInitialization.java
+1
-0
JpaProperties.java
...ngframework/boot/autoconfigure/orm/jpa/JpaProperties.java
+8
-3
CustomHibernateJpaAutoConfigurationTests.java
...ure/orm/jpa/CustomHibernateJpaAutoConfigurationTests.java
+6
-4
No files found.
spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jdbc/DataSourceInitialization.java
View file @
251dbddc
...
...
@@ -160,6 +160,7 @@ public class DataSourceInitialization implements
return
resources
;
}
@SuppressWarnings
(
"serial"
)
public
static
class
DataSourceInitializedEvent
extends
ApplicationEvent
{
public
DataSourceInitializedEvent
(
DataSource
source
)
{
...
...
spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/orm/jpa/JpaProperties.java
View file @
251dbddc
...
...
@@ -27,6 +27,7 @@ import org.springframework.boot.autoconfigure.jdbc.EmbeddedDatabaseConnection;
import
org.springframework.boot.context.properties.ConfigurationProperties
;
import
org.springframework.boot.orm.jpa.SpringNamingStrategy
;
import
org.springframework.orm.jpa.vendor.Database
;
import
org.springframework.util.StringUtils
;
/**
* External configuration properties for a JPA EntityManagerFactory created by Spring.
...
...
@@ -181,8 +182,12 @@ public class JpaProperties {
private
Map
<
String
,
String
>
getDeferredAdditionalProperties
(
Map
<
String
,
String
>
properties
,
DataSource
dataSource
)
{
Map
<
String
,
String
>
deferred
=
getAdditionalProperties
(
properties
);
deferred
.
put
(
"hibernate.hbm2ddl.auto"
,
getDeferredDdlAuto
(
properties
,
dataSource
));
String
ddlAuto
=
getDeferredDdlAuto
(
properties
,
dataSource
);
if
(
StringUtils
.
hasText
(
ddlAuto
)
&&
!
"none"
.
equals
(
ddlAuto
))
{
deferred
.
put
(
"hibernate.hbm2ddl.auto"
,
ddlAuto
);
}
else
{
deferred
.
remove
(
"hibernate.hbm2ddl.auto"
);
}
return
deferred
;
}
...
...
@@ -197,7 +202,7 @@ public class JpaProperties {
DEFAULT_NAMING_STRATEGY
.
getName
());
}
if
(
this
.
deferDdl
)
{
result
.
put
(
"hibernate.hbm2ddl.auto"
,
"none
"
);
result
.
remove
(
"hibernate.hbm2ddl.auto
"
);
}
else
{
result
.
put
(
"hibernate.hbm2ddl.auto"
,
this
.
ddlAuto
);
...
...
spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/orm/jpa/CustomHibernateJpaAutoConfigurationTests.java
View file @
251dbddc
...
...
@@ -16,6 +16,11 @@
package
org
.
springframework
.
boot
.
autoconfigure
.
orm
.
jpa
;
import
static
org
.
hamcrest
.
Matchers
.
equalTo
;
import
static
org
.
hamcrest
.
Matchers
.
is
;
import
static
org
.
hamcrest
.
Matchers
.
nullValue
;
import
static
org
.
junit
.
Assert
.
assertThat
;
import
javax.sql.DataSource
;
import
org.junit.After
;
...
...
@@ -29,9 +34,6 @@ import org.springframework.boot.test.EnvironmentTestUtils;
import
org.springframework.context.annotation.AnnotationConfigApplicationContext
;
import
org.springframework.context.annotation.Configuration
;
import
static
org
.
hamcrest
.
Matchers
.
equalTo
;
import
static
org
.
junit
.
Assert
.
assertThat
;
/**
* Tests for {@link HibernateJpaAutoConfiguration}.
*
...
...
@@ -64,7 +66,7 @@ public class CustomHibernateJpaAutoConfigurationTests {
String
actual
=
bean
.
getHibernateProperties
(
dataSource
).
get
(
"hibernate.hbm2ddl.auto"
);
// Default is generic and safe
assertThat
(
actual
,
equalTo
(
"none"
));
assertThat
(
actual
,
is
(
nullValue
()
));
}
@Test
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment