Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in / Register
Toggle navigation
S
spring-boot
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
DEMO
spring-boot
Commits
3789424f
Commit
3789424f
authored
Dec 17, 2013
by
Dave Syer
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add JodaModule bean if detected on classpath
Fixes gh-146
parent
a79e3613
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
29 additions
and
3 deletions
+29
-3
pom.xml
spring-boot-autoconfigure/pom.xml
+5
-0
HttpMessageConvertersAutoConfiguration.java
...configure/web/HttpMessageConvertersAutoConfiguration.java
+13
-2
HttpMessageConvertersAutoConfigurationTests.java
...gure/web/HttpMessageConvertersAutoConfigurationTests.java
+11
-1
No files found.
spring-boot-autoconfigure/pom.xml
View file @
3789424f
...
...
@@ -26,6 +26,11 @@
<artifactId>
jackson-databind
</artifactId>
<optional>
true
</optional>
</dependency>
<dependency>
<groupId>
com.fasterxml.jackson.datatype
</groupId>
<artifactId>
jackson-datatype-joda
</artifactId>
<optional>
true
</optional>
</dependency>
<dependency>
<groupId>
commons-dbcp
</groupId>
<artifactId>
commons-dbcp
</artifactId>
...
...
spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/web/HttpMessageConvertersAutoConfiguration.java
View file @
3789424f
...
...
@@ -23,11 +23,11 @@ import java.util.List;
import
javax.annotation.PostConstruct
;
import
org.joda.time.DateTime
;
import
org.springframework.beans.factory.BeanFactoryUtils
;
import
org.springframework.beans.factory.ListableBeanFactory
;
import
org.springframework.beans.factory.annotation.Autowired
;
import
org.springframework.boot.autoconfigure.EnableAutoConfiguration
;
import
org.springframework.boot.autoconfigure.condition.ConditionalOnBean
;
import
org.springframework.boot.autoconfigure.condition.ConditionalOnClass
;
import
org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean
;
import
org.springframework.context.annotation.Bean
;
...
...
@@ -38,6 +38,7 @@ import org.springframework.http.converter.json.MappingJackson2HttpMessageConvert
import
com.fasterxml.jackson.databind.Module
;
import
com.fasterxml.jackson.databind.ObjectMapper
;
import
com.fasterxml.jackson.datatype.joda.JodaModule
;
/**
* {@link EnableAutoConfiguration Auto-configuration} for {@link HttpMessageConverter}s.
...
...
@@ -60,7 +61,17 @@ public class HttpMessageConvertersAutoConfiguration {
}
@Configuration
@ConditionalOnBean
(
ObjectMapper
.
class
)
@ConditionalOnClass
({
JodaModule
.
class
,
DateTime
.
class
})
protected
static
class
JodaModuleConfiguration
{
@Bean
public
JodaModule
jodaModule
()
{
return
new
JodaModule
();
}
}
@Configuration
@ConditionalOnClass
(
ObjectMapper
.
class
)
protected
static
class
ObjectMappers
{
...
...
spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/web/HttpMessageConvertersAutoConfigurationTests.java
View file @
3789424f
...
...
@@ -37,6 +37,7 @@ import com.fasterxml.jackson.databind.module.SimpleModule;
import
static
org
.
hamcrest
.
Matchers
.
hasItem
;
import
static
org
.
junit
.
Assert
.
assertEquals
;
import
static
org
.
junit
.
Assert
.
assertNotNull
;
import
static
org
.
junit
.
Assert
.
assertTrue
;
import
static
org
.
mockito
.
Matchers
.
argThat
;
import
static
org
.
mockito
.
Mockito
.
verify
;
...
...
@@ -72,6 +73,14 @@ public class HttpMessageConvertersAutoConfigurationTests {
assertTrue
(
converters
.
getConverters
().
contains
(
converter
));
}
@Test
public
void
defaultJacksonModules
()
throws
Exception
{
this
.
context
=
new
AnnotationConfigApplicationContext
();
this
.
context
.
register
(
HttpMessageConvertersAutoConfiguration
.
class
);
this
.
context
.
refresh
();
assertNotNull
(
this
.
context
.
getBean
(
"jodaModule"
,
Module
.
class
));
}
@Test
public
void
customJacksonModules
()
throws
Exception
{
this
.
context
=
new
AnnotationConfigApplicationContext
();
...
...
@@ -82,7 +91,8 @@ public class HttpMessageConvertersAutoConfigurationTests {
@SuppressWarnings
({
"unchecked"
,
"unused"
})
ObjectMapper
result
=
verify
(
mapper
).
registerModules
(
(
Iterable
<
Module
>)
argThat
(
hasItem
(
this
.
context
.
getBean
(
Module
.
class
))));
(
Iterable
<
Module
>)
argThat
(
hasItem
(
this
.
context
.
getBean
(
"jacksonModule"
,
Module
.
class
))));
}
@Test
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment