Commit 5123eb0c authored by Stephane Nicoll's avatar Stephane Nicoll

Fix deprecation in Testcontainers 1.15.0

See gh-24103
parent c1a1b5fe
...@@ -28,7 +28,6 @@ import com.datastax.oss.driver.api.core.cql.SimpleStatement; ...@@ -28,7 +28,6 @@ import com.datastax.oss.driver.api.core.cql.SimpleStatement;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
import org.rnorth.ducttape.TimeoutException; import org.rnorth.ducttape.TimeoutException;
import org.rnorth.ducttape.unreliables.Unreliables; import org.rnorth.ducttape.unreliables.Unreliables;
import org.testcontainers.containers.CassandraContainer;
import org.testcontainers.containers.ContainerLaunchException; import org.testcontainers.containers.ContainerLaunchException;
import org.testcontainers.containers.wait.strategy.AbstractWaitStrategy; import org.testcontainers.containers.wait.strategy.AbstractWaitStrategy;
import org.testcontainers.images.builder.Transferable; import org.testcontainers.images.builder.Transferable;
...@@ -37,6 +36,7 @@ import org.testcontainers.junit.jupiter.Testcontainers; ...@@ -37,6 +36,7 @@ import org.testcontainers.junit.jupiter.Testcontainers;
import org.springframework.boot.autoconfigure.AutoConfigurations; import org.springframework.boot.autoconfigure.AutoConfigurations;
import org.springframework.boot.test.context.runner.ApplicationContextRunner; import org.springframework.boot.test.context.runner.ApplicationContextRunner;
import org.springframework.boot.testsupport.testcontainers.CassandraContainer;
import org.springframework.util.StreamUtils; import org.springframework.util.StreamUtils;
import static org.assertj.core.api.Assertions.assertThat; import static org.assertj.core.api.Assertions.assertThat;
...@@ -51,7 +51,7 @@ import static org.assertj.core.api.Assertions.assertThatThrownBy; ...@@ -51,7 +51,7 @@ import static org.assertj.core.api.Assertions.assertThatThrownBy;
class CassandraAutoConfigurationWithPasswordAuthenticationIntegrationTests { class CassandraAutoConfigurationWithPasswordAuthenticationIntegrationTests {
@Container @Container
static final CassandraContainer<?> cassandra = new PasswordAuthenticatorCassandraContainer().withStartupAttempts(5) static final CassandraContainer cassandra = new PasswordAuthenticatorCassandraContainer().withStartupAttempts(5)
.withStartupTimeout(Duration.ofMinutes(10)).waitingFor(new CassandraWaitStrategy()); .withStartupTimeout(Duration.ofMinutes(10)).waitingFor(new CassandraWaitStrategy());
private final ApplicationContextRunner contextRunner = new ApplicationContextRunner() private final ApplicationContextRunner contextRunner = new ApplicationContextRunner()
...@@ -80,8 +80,7 @@ class CassandraAutoConfigurationWithPasswordAuthenticationIntegrationTests { ...@@ -80,8 +80,7 @@ class CassandraAutoConfigurationWithPasswordAuthenticationIntegrationTests {
.hasMessageContaining("Authentication error")); .hasMessageContaining("Authentication error"));
} }
static final class PasswordAuthenticatorCassandraContainer static final class PasswordAuthenticatorCassandraContainer extends CassandraContainer {
extends CassandraContainer<PasswordAuthenticatorCassandraContainer> {
@Override @Override
protected void containerIsCreated(String containerId) { protected void containerIsCreated(String containerId) {
......
...@@ -21,7 +21,6 @@ import java.time.Duration; ...@@ -21,7 +21,6 @@ import java.time.Duration;
import com.datastax.oss.driver.api.core.CqlSession; import com.datastax.oss.driver.api.core.CqlSession;
import com.datastax.oss.driver.api.core.CqlSessionBuilder; import com.datastax.oss.driver.api.core.CqlSessionBuilder;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
import org.testcontainers.containers.CassandraContainer;
import org.testcontainers.junit.jupiter.Container; import org.testcontainers.junit.jupiter.Container;
import org.testcontainers.junit.jupiter.Testcontainers; import org.testcontainers.junit.jupiter.Testcontainers;
...@@ -31,6 +30,7 @@ import org.springframework.boot.autoconfigure.AutoConfigurations; ...@@ -31,6 +30,7 @@ import org.springframework.boot.autoconfigure.AutoConfigurations;
import org.springframework.boot.autoconfigure.cassandra.CassandraAutoConfiguration; import org.springframework.boot.autoconfigure.cassandra.CassandraAutoConfiguration;
import org.springframework.boot.autoconfigure.data.cassandra.city.City; import org.springframework.boot.autoconfigure.data.cassandra.city.City;
import org.springframework.boot.test.context.runner.ApplicationContextRunner; import org.springframework.boot.test.context.runner.ApplicationContextRunner;
import org.springframework.boot.testsupport.testcontainers.CassandraContainer;
import org.springframework.context.annotation.Bean; import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration; import org.springframework.context.annotation.Configuration;
import org.springframework.data.cassandra.config.SchemaAction; import org.springframework.data.cassandra.config.SchemaAction;
...@@ -48,7 +48,7 @@ import static org.assertj.core.api.Assertions.assertThat; ...@@ -48,7 +48,7 @@ import static org.assertj.core.api.Assertions.assertThat;
class CassandraDataAutoConfigurationIntegrationTests { class CassandraDataAutoConfigurationIntegrationTests {
@Container @Container
static final CassandraContainer<?> cassandra = new CassandraContainer<>().withStartupAttempts(5) static final CassandraContainer cassandra = new CassandraContainer().withStartupAttempts(5)
.withStartupTimeout(Duration.ofMinutes(10)); .withStartupTimeout(Duration.ofMinutes(10));
private final ApplicationContextRunner contextRunner = new ApplicationContextRunner() private final ApplicationContextRunner contextRunner = new ApplicationContextRunner()
......
...@@ -18,6 +18,7 @@ dependencies { ...@@ -18,6 +18,7 @@ dependencies {
compileOnly("org.neo4j:neo4j-ogm-core") compileOnly("org.neo4j:neo4j-ogm-core")
compileOnly("org.springframework:spring-context") compileOnly("org.springframework:spring-context")
compileOnly("org.springframework.data:spring-data-redis") compileOnly("org.springframework.data:spring-data-redis")
compileOnly("org.testcontainers:cassandra")
compileOnly("org.testcontainers:elasticsearch") compileOnly("org.testcontainers:elasticsearch")
compileOnly("org.testcontainers:testcontainers") compileOnly("org.testcontainers:testcontainers")
......
/*
* Copyright 2012-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.springframework.boot.testsupport.testcontainers;
import org.testcontainers.utility.DockerImageName;
/**
* Extension of {@link org.testcontainers.containers.CassandraContainer} that provides a
* default version.
*
* @author Stephane Nicoll
* @since 2.3.6
*/
public class CassandraContainer extends org.testcontainers.containers.CassandraContainer<CassandraContainer> {
public CassandraContainer() {
super(DockerImageName.parse("cassandra").withTag("3.11.2"));
}
}
...@@ -22,16 +22,17 @@ import org.testcontainers.elasticsearch.ElasticsearchContainer; ...@@ -22,16 +22,17 @@ import org.testcontainers.elasticsearch.ElasticsearchContainer;
* Extension of {@link ElasticsearchContainer} to override default version. * Extension of {@link ElasticsearchContainer} to override default version.
* *
* @author Scott Frederick * @author Scott Frederick
* @since 2.3.6
*/ */
public class VersionOverridingElasticsearchContainer extends ElasticsearchContainer { public class VersionOverridingElasticsearchContainer extends ElasticsearchContainer {
/** /**
* Elasticsearch Docker base URL * Elasticsearch Docker base URL.
*/ */
private static final String ELASTICSEARCH_IMAGE = "docker.elastic.co/elasticsearch/elasticsearch"; private static final String ELASTICSEARCH_IMAGE = "docker.elastic.co/elasticsearch/elasticsearch";
/** /**
* Elasticsearch version * Elasticsearch version.
*/ */
protected static final String ELASTICSEARCH_VERSION = Version.CURRENT.toString(); protected static final String ELASTICSEARCH_VERSION = Version.CURRENT.toString();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment