Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in / Register
Toggle navigation
S
spring-boot
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
DEMO
spring-boot
Commits
554a962a
Commit
554a962a
authored
Jul 13, 2020
by
Sebastiaan Fernandez
Committed by
Andy Wilkinson
Jul 17, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add failure analyzer for missing Liquibase changelog
See gh-22320
parent
2c60672d
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
141 additions
and
1 deletion
+141
-1
LiquibaseChangelogMissingFailureAnalyzer.java
...cs/analyzer/LiquibaseChangelogMissingFailureAnalyzer.java
+52
-0
spring.factories
.../spring-boot/src/main/resources/META-INF/spring.factories
+2
-1
LiquibaseChangelogMissingFailureAnalyzerTest.java
...nalyzer/LiquibaseChangelogMissingFailureAnalyzerTest.java
+87
-0
No files found.
spring-boot-project/spring-boot/src/main/java/org/springframework/boot/diagnostics/analyzer/LiquibaseChangelogMissingFailureAnalyzer.java
0 → 100644
View file @
554a962a
/*
* Copyright 2012-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package
org
.
springframework
.
boot
.
diagnostics
.
analyzer
;
import
java.io.FileNotFoundException
;
import
liquibase.exception.ChangeLogParseException
;
import
org.springframework.boot.diagnostics.AbstractFailureAnalyzer
;
import
org.springframework.boot.diagnostics.FailureAnalysis
;
/**
* An {@link AbstractFailureAnalyzer} that analyzes exceptions of type
* {@link ChangeLogParseException} caused by a Liquibase changelog not being present.
*
* @author Sebastiaan Fernandez
*/
class
LiquibaseChangelogMissingFailureAnalyzer
extends
AbstractFailureAnalyzer
<
ChangeLogParseException
>
{
@Override
protected
FailureAnalysis
analyze
(
Throwable
rootFailure
,
ChangeLogParseException
cause
)
{
FileNotFoundException
exception
=
findCause
(
cause
,
FileNotFoundException
.
class
);
if
(
exception
!=
null
)
{
return
new
FailureAnalysis
(
getDescription
(
cause
),
"Make sure a Liquibase changelog is present at the configured path"
,
cause
);
}
return
null
;
}
private
String
getDescription
(
ChangeLogParseException
cause
)
{
return
"Liquibase failed to start because no changelog could be found at: "
+
extractChangelogPath
(
cause
);
}
private
String
extractChangelogPath
(
ChangeLogParseException
cause
)
{
return
cause
.
getMessage
().
substring
(
"Error parsing "
.
length
());
}
}
spring-boot-project/spring-boot/src/main/resources/META-INF/spring.factories
View file @
554a962a
...
@@ -56,7 +56,8 @@ org.springframework.boot.diagnostics.analyzer.ValidationExceptionFailureAnalyzer
...
@@ -56,7 +56,8 @@ org.springframework.boot.diagnostics.analyzer.ValidationExceptionFailureAnalyzer
org.springframework.boot.diagnostics.analyzer.IncompatibleConfigurationFailureAnalyzer,\
org.springframework.boot.diagnostics.analyzer.IncompatibleConfigurationFailureAnalyzer,\
org.springframework.boot.diagnostics.analyzer.InvalidConfigurationPropertyNameFailureAnalyzer,\
org.springframework.boot.diagnostics.analyzer.InvalidConfigurationPropertyNameFailureAnalyzer,\
org.springframework.boot.diagnostics.analyzer.InvalidConfigurationPropertyValueFailureAnalyzer,\
org.springframework.boot.diagnostics.analyzer.InvalidConfigurationPropertyValueFailureAnalyzer,\
org.springframework.boot.diagnostics.analyzer.PatternParseFailureAnalyzer
org.springframework.boot.diagnostics.analyzer.PatternParseFailureAnalyzer,\
org.springframework.boot.diagnostics.analyzer.LiquibaseChangelogMissingFailureAnalyzer
# FailureAnalysisReporters
# FailureAnalysisReporters
org.springframework.boot.diagnostics.FailureAnalysisReporter=\
org.springframework.boot.diagnostics.FailureAnalysisReporter=\
...
...
spring-boot-project/spring-boot/src/test/java/org/springframework/boot/diagnostics/analyzer/LiquibaseChangelogMissingFailureAnalyzerTest.java
0 → 100644
View file @
554a962a
/*
* Copyright 2012-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package
org
.
springframework
.
boot
.
diagnostics
.
analyzer
;
import
javax.sql.DataSource
;
import
liquibase.integration.spring.SpringLiquibase
;
import
org.junit.jupiter.api.Test
;
import
org.springframework.beans.factory.BeanCreationException
;
import
org.springframework.boot.diagnostics.FailureAnalysis
;
import
org.springframework.boot.jdbc.DataSourceBuilder
;
import
org.springframework.context.annotation.AnnotationConfigApplicationContext
;
import
org.springframework.context.annotation.Bean
;
import
org.springframework.context.annotation.Configuration
;
import
static
org
.
assertj
.
core
.
api
.
Assertions
.
assertThat
;
/**
* Tests for {@link LiquibaseChangelogMissingFailureAnalyzer}
*
* @author Sebastiaan Fernandez
*/
class
LiquibaseChangelogMissingFailureAnalyzerTest
{
@Test
void
changelogParseExceptionDueToChangelogNotPresent
()
{
FailureAnalysis
analysis
=
performAnalysis
();
assertThat
(
analysis
.
getDescription
())
.
isEqualTo
(
"Liquibase failed to start because no changelog could be found at: "
+
"classpath:/db/changelog/db.changelog-master.yaml"
);
assertThat
(
analysis
.
getAction
()).
isEqualTo
(
"Make sure a Liquibase changelog is present at the configured path"
);
}
private
FailureAnalysis
performAnalysis
()
{
BeanCreationException
failure
=
createFailure
();
assertThat
(
failure
).
isNotNull
();
return
new
LiquibaseChangelogMissingFailureAnalyzer
().
analyze
(
failure
);
}
private
BeanCreationException
createFailure
()
{
try
{
AnnotationConfigApplicationContext
context
=
new
AnnotationConfigApplicationContext
();
context
.
register
(
LiquibaseConfiguration
.
class
);
context
.
refresh
();
context
.
close
();
return
null
;
}
catch
(
BeanCreationException
ex
)
{
return
ex
;
}
}
@Configuration
(
proxyBeanMethods
=
false
)
static
class
LiquibaseConfiguration
{
@Bean
DataSource
dataSource
()
{
return
DataSourceBuilder
.
create
().
url
(
"jdbc:hsqldb:mem:normal"
).
username
(
"sa"
).
build
();
}
@Bean
SpringLiquibase
springLiquibase
(
DataSource
dataSource
)
{
SpringLiquibase
liquibase
=
new
SpringLiquibase
();
liquibase
.
setChangeLog
(
"classpath:/db/changelog/db.changelog-master.yaml"
);
liquibase
.
setShouldRun
(
true
);
liquibase
.
setDataSource
(
dataSource
);
return
liquibase
;
}
}
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment