Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in / Register
Toggle navigation
S
spring-boot
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
DEMO
spring-boot
Commits
63b8e82c
Commit
63b8e82c
authored
Aug 31, 2016
by
Andy Wilkinson
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Update OnBeanCondition to consider hierarchy for PARENTS search strategy
Closes gh-6762
parent
c8632f12
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
95 additions
and
3 deletions
+95
-3
OnBeanCondition.java
...amework/boot/autoconfigure/condition/OnBeanCondition.java
+2
-2
ConditionalOnMissingBeanTests.java
...utoconfigure/condition/ConditionalOnMissingBeanTests.java
+39
-0
ConditionalOnSingleCandidateTests.java
...onfigure/condition/ConditionalOnSingleCandidateTests.java
+54
-1
No files found.
spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/condition/OnBeanCondition.java
View file @
63b8e82c
/*
* Copyright 2012-201
5
the original author or authors.
* Copyright 2012-201
6
the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
...
...
@@ -135,7 +135,7 @@ class OnBeanCondition extends SpringBootCondition implements ConfigurationCondit
return
Collections
.
emptyList
();
}
List
<
String
>
beanNames
=
new
ArrayList
<
String
>();
boolean
considerHierarchy
=
beans
.
getStrategy
()
==
SearchStrategy
.
ALL
;
boolean
considerHierarchy
=
beans
.
getStrategy
()
!=
SearchStrategy
.
CURRENT
;
for
(
String
type
:
beans
.
getTypes
())
{
beanNames
.
addAll
(
getBeanNamesForType
(
beanFactory
,
type
,
context
.
getClassLoader
(),
considerHierarchy
));
...
...
spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/condition/ConditionalOnMissingBeanTests.java
View file @
63b8e82c
...
...
@@ -250,6 +250,45 @@ public class ConditionalOnMissingBeanTests {
is
(
equalTo
(
1
)));
}
@Test
public
void
grandparentIsConsideredWhenUsingParentsStrategy
()
{
this
.
context
.
register
(
ExampleBeanConfiguration
.
class
);
this
.
context
.
refresh
();
AnnotationConfigApplicationContext
parent
=
new
AnnotationConfigApplicationContext
();
parent
.
setParent
(
this
.
context
);
parent
.
refresh
();
AnnotationConfigApplicationContext
child
=
new
AnnotationConfigApplicationContext
();
child
.
setParent
(
parent
);
child
.
register
(
ExampleBeanConfiguration
.
class
,
OnBeanInParentsConfiguration
.
class
);
child
.
refresh
();
assertThat
(
child
.
getBeansOfType
(
ExampleBean
.
class
).
size
(),
is
(
equalTo
(
1
)));
child
.
close
();
parent
.
close
();
}
@Test
public
void
currentContextIsIgnoredWhenUsingParentsStrategy
()
{
this
.
context
.
refresh
();
AnnotationConfigApplicationContext
child
=
new
AnnotationConfigApplicationContext
();
child
.
register
(
ExampleBeanConfiguration
.
class
,
OnBeanInParentsConfiguration
.
class
);
child
.
setParent
(
this
.
context
);
child
.
refresh
();
assertThat
(
child
.
getBeansOfType
(
ExampleBean
.
class
).
size
(),
is
(
equalTo
(
2
)));
}
@Configuration
protected
static
class
OnBeanInParentsConfiguration
{
@Bean
@ConditionalOnMissingBean
(
search
=
SearchStrategy
.
PARENTS
)
public
ExampleBean
exampleBean2
()
{
return
new
ExampleBean
(
"test"
);
}
}
@Configuration
@ConditionalOnMissingBean
(
name
=
"foo"
)
protected
static
class
OnBeanNameConfiguration
{
...
...
spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/condition/ConditionalOnSingleCandidateTests.java
View file @
63b8e82c
...
...
@@ -64,6 +64,46 @@ public class ConditionalOnSingleCandidateTests {
assertEquals
(
"foo"
,
this
.
context
.
getBean
(
"baz"
));
}
@Test
public
void
singleCandidateInParentsOneCandidateInCurrent
()
{
load
();
AnnotationConfigApplicationContext
child
=
new
AnnotationConfigApplicationContext
();
child
.
register
(
FooConfiguration
.
class
,
OnBeanSingleCandidateInParentsConfiguration
.
class
);
child
.
setParent
(
this
.
context
);
child
.
refresh
();
assertFalse
(
child
.
containsBean
(
"baz"
));
child
.
close
();
}
@Test
public
void
singleCandidateInParentsOneCandidateInParent
()
{
load
(
FooConfiguration
.
class
);
AnnotationConfigApplicationContext
child
=
new
AnnotationConfigApplicationContext
();
child
.
register
(
OnBeanSingleCandidateInParentsConfiguration
.
class
);
child
.
setParent
(
this
.
context
);
child
.
refresh
();
assertTrue
(
child
.
containsBean
(
"baz"
));
assertEquals
(
"foo"
,
child
.
getBean
(
"baz"
));
child
.
close
();
}
@Test
public
void
singleCandidateInParentsOneCandidateInGrandparent
()
{
load
(
FooConfiguration
.
class
);
AnnotationConfigApplicationContext
parent
=
new
AnnotationConfigApplicationContext
();
parent
.
setParent
(
this
.
context
);
parent
.
refresh
();
AnnotationConfigApplicationContext
child
=
new
AnnotationConfigApplicationContext
();
child
.
register
(
OnBeanSingleCandidateInParentsConfiguration
.
class
);
child
.
setParent
(
parent
);
child
.
refresh
();
assertTrue
(
child
.
containsBean
(
"baz"
));
assertEquals
(
"foo"
,
child
.
getBean
(
"baz"
));
child
.
close
();
parent
.
close
();
}
@Test
public
void
singleCandidateMultipleCandidates
()
{
load
(
FooConfiguration
.
class
,
BarConfiguration
.
class
,
...
...
@@ -121,7 +161,9 @@ public class ConditionalOnSingleCandidateTests {
}
private
void
load
(
Class
<?>...
classes
)
{
this
.
context
.
register
(
classes
);
if
(
classes
.
length
>
0
)
{
this
.
context
.
register
(
classes
);
}
this
.
context
.
refresh
();
}
...
...
@@ -136,6 +178,17 @@ public class ConditionalOnSingleCandidateTests {
}
@Configuration
@ConditionalOnSingleCandidate
(
value
=
String
.
class
,
search
=
SearchStrategy
.
PARENTS
)
protected
static
class
OnBeanSingleCandidateInParentsConfiguration
{
@Bean
public
String
baz
(
String
s
)
{
return
s
;
}
}
@Configuration
@ConditionalOnSingleCandidate
(
value
=
String
.
class
,
type
=
"java.lang.String"
)
protected
static
class
OnBeanSingleCandidateTwoTypesConfiguration
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment