Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in / Register
Toggle navigation
S
spring-boot
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
DEMO
spring-boot
Commits
8c1b736b
Commit
8c1b736b
authored
Oct 03, 2016
by
Stephane Nicoll
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix list property to be mutable
Closes gh-7068
parent
4dfdce5a
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
10 additions
and
2 deletions
+10
-2
ManagementServerProperties.java
...oot/actuate/autoconfigure/ManagementServerProperties.java
+3
-2
ManagementServerPropertiesAutoConfigurationTests.java
...ure/ManagementServerPropertiesAutoConfigurationTests.java
+7
-0
No files found.
spring-boot-actuator/src/main/java/org/springframework/boot/actuate/autoconfigure/ManagementServerProperties.java
View file @
8c1b736b
...
...
@@ -17,6 +17,7 @@
package
org
.
springframework
.
boot
.
actuate
.
autoconfigure
;
import
java.net.InetAddress
;
import
java.util.ArrayList
;
import
java.util.Collections
;
import
java.util.List
;
...
...
@@ -178,7 +179,7 @@ public class ManagementServerProperties implements SecurityPrerequisite {
/**
* Comma-separated list of roles that can access the management endpoint.
*/
private
List
<
String
>
roles
=
Collections
.
singletonList
(
"ADMIN"
);
private
List
<
String
>
roles
=
new
ArrayList
<
String
>(
Collections
.
singletonList
(
"ADMIN"
)
);
/**
* Session creating policy to use (always, never, if_required, stateless).
...
...
@@ -199,7 +200,7 @@ public class ManagementServerProperties implements SecurityPrerequisite {
@Deprecated
public
void
setRole
(
String
role
)
{
this
.
roles
=
Collections
.
singletonList
(
role
);
this
.
roles
=
new
ArrayList
<
String
>(
Collections
.
singletonList
(
role
)
);
}
public
List
<
String
>
getRoles
()
{
...
...
spring-boot-actuator/src/test/java/org/springframework/boot/actuate/autoconfigure/ManagementServerPropertiesAutoConfigurationTests.java
View file @
8c1b736b
...
...
@@ -80,6 +80,13 @@ public class ManagementServerPropertiesAutoConfigurationTests {
assertThat
(
properties
.
getSecurity
().
getRoles
()).
containsOnly
(
"FOO"
);
}
@Test
public
void
managementRolesAllowsIndexedAccess
()
{
ManagementServerProperties
properties
=
load
(
"management.security.roles[0]=FOO"
);
assertThat
(
properties
.
getSecurity
().
getRoles
()).
containsOnly
(
"FOO"
);
}
@Test
public
void
managementRolesSetMultipleRoles
()
{
ManagementServerProperties
properties
=
load
(
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment