Commit 9692abba authored by Madhura Bhave's avatar Madhura Bhave

Use registrationId in redirectURI for default provider

Fixes gh-10505
parent 9f4688cf
...@@ -95,7 +95,7 @@ public enum CommonOAuth2Provider { ...@@ -95,7 +95,7 @@ public enum CommonOAuth2Provider {
}; };
private static final String DEFAULT_REDIRECT_URL = "{scheme}://{serverName}:{serverPort}{contextPath}/oauth2/authorize/code/{clientAlias}"; private static final String DEFAULT_REDIRECT_URL = "{scheme}://{serverName}:{serverPort}{contextPath}/oauth2/authorize/code/{registrationId}";
protected final ClientRegistration.Builder getBuilder(String registrationId, protected final ClientRegistration.Builder getBuilder(String registrationId,
ClientAuthenticationMethod method, String redirectUri) { ClientAuthenticationMethod method, String redirectUri) {
......
...@@ -33,7 +33,7 @@ import static org.assertj.core.api.Assertions.assertThat; ...@@ -33,7 +33,7 @@ import static org.assertj.core.api.Assertions.assertThat;
*/ */
public class CommonOAuth2ProviderTests { public class CommonOAuth2ProviderTests {
private static final String DEFAULT_REDIRECT_URL = "{scheme}://{serverName}:{serverPort}{contextPath}/oauth2/authorize/code/{clientAlias}"; private static final String DEFAULT_REDIRECT_URL = "{scheme}://{serverName}:{serverPort}{contextPath}/oauth2/authorize/code/{registrationId}";
@Test @Test
public void getBuilderWhenGoogleShouldHaveGoogleSettings() throws Exception { public void getBuilderWhenGoogleShouldHaveGoogleSettings() throws Exception {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment