Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in / Register
Toggle navigation
S
spring-boot
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
DEMO
spring-boot
Commits
b0e86bd7
Commit
b0e86bd7
authored
Feb 12, 2018
by
Andy Wilkinson
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Align New Relic and Signal FX tests with those for other exporters
Closes gh-11970
parent
384a4ed6
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
32 additions
and
37 deletions
+32
-37
NewRelicMetricsExportAutoConfigurationTests.java
...newrelic/NewRelicMetricsExportAutoConfigurationTests.java
+16
-20
SignalFxMetricsExportAutoConfigurationTests.java
...signalfx/SignalFxMetricsExportAutoConfigurationTests.java
+16
-17
No files found.
spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/export/newrelic/NewRelicMetricsExportAutoConfigurationTests.java
View file @
b0e86bd7
...
@@ -17,15 +17,16 @@
...
@@ -17,15 +17,16 @@
package
org
.
springframework
.
boot
.
actuate
.
autoconfigure
.
metrics
.
export
.
newrelic
;
package
org
.
springframework
.
boot
.
actuate
.
autoconfigure
.
metrics
.
export
.
newrelic
;
import
io.micrometer.core.instrument.Clock
;
import
io.micrometer.core.instrument.Clock
;
import
io.micrometer.influx.InfluxMeterRegistry
;
import
io.micrometer.newrelic.NewRelicConfig
;
import
io.micrometer.newrelic.NewRelicConfig
;
import
io.micrometer.newrelic.NewRelicMeterRegistry
;
import
io.micrometer.newrelic.NewRelicMeterRegistry
;
import
org.junit.Test
;
import
org.junit.Test
;
import
org.springframework.boot.actuate.autoconfigure.metrics.MetricsAutoConfiguration
;
import
org.springframework.boot.autoconfigure.AutoConfigurations
;
import
org.springframework.boot.autoconfigure.AutoConfigurations
;
import
org.springframework.boot.test.context.runner.ApplicationContextRunner
;
import
org.springframework.boot.test.context.runner.ApplicationContextRunner
;
import
org.springframework.context.annotation.Bean
;
import
org.springframework.context.annotation.Bean
;
import
org.springframework.context.annotation.Configuration
;
import
org.springframework.context.annotation.Configuration
;
import
org.springframework.context.annotation.Import
;
import
static
org
.
assertj
.
core
.
api
.
Assertions
.
assertThat
;
import
static
org
.
assertj
.
core
.
api
.
Assertions
.
assertThat
;
...
@@ -39,29 +40,31 @@ public class NewRelicMetricsExportAutoConfigurationTests {
...
@@ -39,29 +40,31 @@ public class NewRelicMetricsExportAutoConfigurationTests {
private
final
ApplicationContextRunner
runner
=
new
ApplicationContextRunner
()
private
final
ApplicationContextRunner
runner
=
new
ApplicationContextRunner
()
.
withConfiguration
(
.
withConfiguration
(
AutoConfigurations
.
of
(
NewRelicMetricsExportAutoConfiguration
.
class
,
AutoConfigurations
.
of
(
NewRelicMetricsExportAutoConfiguration
.
class
));
MetricsAutoConfiguration
.
class
));
@Test
public
void
backsOffWithoutAClock
()
{
this
.
runner
.
run
((
context
)
->
assertThat
(
context
)
.
doesNotHaveBean
(
InfluxMeterRegistry
.
class
));
}
@Test
@Test
public
void
failsWithoutAnApiKey
()
{
public
void
failsWithoutAnApiKey
()
{
this
.
runner
this
.
runner
.
withUserConfiguration
(
BaseConfiguration
.
class
)
.
withPropertyValues
(
"management.metrics.export.newrelic.account-id=12345"
)
.
withPropertyValues
(
"management.metrics.export.newrelic.account-id=12345"
)
.
run
((
context
)
->
assertThat
(
context
).
hasFailed
());
.
run
((
context
)
->
assertThat
(
context
).
hasFailed
());
}
}
@Test
@Test
public
void
failsWithoutAnAccountId
()
{
public
void
failsWithoutAnAccountId
()
{
this
.
runner
this
.
runner
.
withUserConfiguration
(
BaseConfiguration
.
class
)
.
withConfiguration
(
AutoConfigurations
.
of
(
NewRelicMetricsExportAutoConfiguration
.
class
,
MetricsAutoConfiguration
.
class
))
.
withPropertyValues
(
"management.metrics.export.newrelic.api-key=abcde"
)
.
withPropertyValues
(
"management.metrics.export.newrelic.api-key=abcde"
)
.
run
((
context
)
->
assertThat
(
context
).
hasFailed
());
.
run
((
context
)
->
assertThat
(
context
).
hasFailed
());
}
}
@Test
@Test
public
void
autoConfiguresWithAccountIdAndApiKey
()
{
public
void
autoConfiguresWithAccountIdAndApiKey
()
{
this
.
runner
this
.
runner
.
withUserConfiguration
(
BaseConfiguration
.
class
)
.
withPropertyValues
(
"management.metrics.export.newrelic.api-key=abcde"
,
.
withPropertyValues
(
"management.metrics.export.newrelic.api-key=abcde"
,
"management.metrics.export.newrelic.account-id=12345"
)
"management.metrics.export.newrelic.account-id=12345"
)
.
run
((
context
)
->
assertThat
(
context
)
.
run
((
context
)
->
assertThat
(
context
)
...
@@ -71,7 +74,7 @@ public class NewRelicMetricsExportAutoConfigurationTests {
...
@@ -71,7 +74,7 @@ public class NewRelicMetricsExportAutoConfigurationTests {
@Test
@Test
public
void
autoConfigurationCanBeDisabled
()
{
public
void
autoConfigurationCanBeDisabled
()
{
this
.
runner
this
.
runner
.
withUserConfiguration
(
BaseConfiguration
.
class
)
.
withPropertyValues
(
"management.metrics.export.newrelic.enabled=false"
,
.
withPropertyValues
(
"management.metrics.export.newrelic.enabled=false"
,
"management.metrics.export.newrelic.api-key=abcde"
,
"management.metrics.export.newrelic.api-key=abcde"
,
"management.metrics.export.newrelic.account-id=12345"
)
"management.metrics.export.newrelic.account-id=12345"
)
...
@@ -80,15 +83,6 @@ public class NewRelicMetricsExportAutoConfigurationTests {
...
@@ -80,15 +83,6 @@ public class NewRelicMetricsExportAutoConfigurationTests {
.
doesNotHaveBean
(
NewRelicConfig
.
class
));
.
doesNotHaveBean
(
NewRelicConfig
.
class
));
}
}
@Test
public
void
allowsClockToBeCustomized
()
{
this
.
runner
.
withUserConfiguration
(
CustomClockConfiguration
.
class
)
.
withPropertyValues
(
"management.metrics.export.newrelic.api-key=abcde"
,
"management.metrics.export.newrelic.account-id=12345"
)
.
run
((
context
)
->
assertThat
(
context
).
hasSingleBean
(
Clock
.
class
)
.
hasBean
(
"customClock"
));
}
@Test
@Test
public
void
allowsConfigToBeCustomized
()
{
public
void
allowsConfigToBeCustomized
()
{
this
.
runner
.
withUserConfiguration
(
CustomConfigConfiguration
.
class
)
this
.
runner
.
withUserConfiguration
(
CustomConfigConfiguration
.
class
)
...
@@ -109,7 +103,7 @@ public class NewRelicMetricsExportAutoConfigurationTests {
...
@@ -109,7 +103,7 @@ public class NewRelicMetricsExportAutoConfigurationTests {
}
}
@Configuration
@Configuration
static
class
CustomClock
Configuration
{
static
class
Base
Configuration
{
@Bean
@Bean
public
Clock
customClock
()
{
public
Clock
customClock
()
{
...
@@ -119,6 +113,7 @@ public class NewRelicMetricsExportAutoConfigurationTests {
...
@@ -119,6 +113,7 @@ public class NewRelicMetricsExportAutoConfigurationTests {
}
}
@Configuration
@Configuration
@Import
(
BaseConfiguration
.
class
)
static
class
CustomConfigConfiguration
{
static
class
CustomConfigConfiguration
{
@Bean
@Bean
...
@@ -142,6 +137,7 @@ public class NewRelicMetricsExportAutoConfigurationTests {
...
@@ -142,6 +137,7 @@ public class NewRelicMetricsExportAutoConfigurationTests {
}
}
@Configuration
@Configuration
@Import
(
BaseConfiguration
.
class
)
static
class
CustomRegistryConfiguration
{
static
class
CustomRegistryConfiguration
{
@Bean
@Bean
...
...
spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/export/signalfx/SignalFxMetricsExportAutoConfigurationTests.java
View file @
b0e86bd7
...
@@ -17,15 +17,16 @@
...
@@ -17,15 +17,16 @@
package
org
.
springframework
.
boot
.
actuate
.
autoconfigure
.
metrics
.
export
.
signalfx
;
package
org
.
springframework
.
boot
.
actuate
.
autoconfigure
.
metrics
.
export
.
signalfx
;
import
io.micrometer.core.instrument.Clock
;
import
io.micrometer.core.instrument.Clock
;
import
io.micrometer.influx.InfluxMeterRegistry
;
import
io.micrometer.signalfx.SignalFxConfig
;
import
io.micrometer.signalfx.SignalFxConfig
;
import
io.micrometer.signalfx.SignalFxMeterRegistry
;
import
io.micrometer.signalfx.SignalFxMeterRegistry
;
import
org.junit.Test
;
import
org.junit.Test
;
import
org.springframework.boot.actuate.autoconfigure.metrics.MetricsAutoConfiguration
;
import
org.springframework.boot.autoconfigure.AutoConfigurations
;
import
org.springframework.boot.autoconfigure.AutoConfigurations
;
import
org.springframework.boot.test.context.runner.ApplicationContextRunner
;
import
org.springframework.boot.test.context.runner.ApplicationContextRunner
;
import
org.springframework.context.annotation.Bean
;
import
org.springframework.context.annotation.Bean
;
import
org.springframework.context.annotation.Configuration
;
import
org.springframework.context.annotation.Configuration
;
import
org.springframework.context.annotation.Import
;
import
static
org
.
assertj
.
core
.
api
.
Assertions
.
assertThat
;
import
static
org
.
assertj
.
core
.
api
.
Assertions
.
assertThat
;
...
@@ -38,17 +39,23 @@ public class SignalFxMetricsExportAutoConfigurationTests {
...
@@ -38,17 +39,23 @@ public class SignalFxMetricsExportAutoConfigurationTests {
private
final
ApplicationContextRunner
runner
=
new
ApplicationContextRunner
()
private
final
ApplicationContextRunner
runner
=
new
ApplicationContextRunner
()
.
withConfiguration
(
.
withConfiguration
(
AutoConfigurations
.
of
(
SignalFxMetricsExportAutoConfiguration
.
class
,
AutoConfigurations
.
of
(
SignalFxMetricsExportAutoConfiguration
.
class
));
MetricsAutoConfiguration
.
class
));
@Test
public
void
backsOffWithoutAClock
()
{
this
.
runner
.
run
((
context
)
->
assertThat
(
context
)
.
doesNotHaveBean
(
InfluxMeterRegistry
.
class
));
}
@Test
@Test
public
void
failsWithoutAnAccessToken
()
{
public
void
failsWithoutAnAccessToken
()
{
this
.
runner
.
run
((
context
)
->
assertThat
(
context
).
hasFailed
());
this
.
runner
.
withUserConfiguration
(
BaseConfiguration
.
class
)
.
run
((
context
)
->
assertThat
(
context
).
hasFailed
());
}
}
@Test
@Test
public
void
autoConfiguresWithAnAccessToken
()
{
public
void
autoConfiguresWithAnAccessToken
()
{
this
.
runner
this
.
runner
.
withUserConfiguration
(
BaseConfiguration
.
class
)
.
withPropertyValues
(
.
withPropertyValues
(
"management.metrics.export.signalfx.access-token=abcde"
)
"management.metrics.export.signalfx.access-token=abcde"
)
.
run
((
context
)
->
assertThat
(
context
)
.
run
((
context
)
->
assertThat
(
context
)
...
@@ -58,7 +65,7 @@ public class SignalFxMetricsExportAutoConfigurationTests {
...
@@ -58,7 +65,7 @@ public class SignalFxMetricsExportAutoConfigurationTests {
@Test
@Test
public
void
autoConfigurationCanBeDisabled
()
{
public
void
autoConfigurationCanBeDisabled
()
{
this
.
runner
this
.
runner
.
withUserConfiguration
(
BaseConfiguration
.
class
)
.
withPropertyValues
(
.
withPropertyValues
(
"management.metrics.export.signalfx.access-token=abcde"
,
"management.metrics.export.signalfx.access-token=abcde"
,
"management.metrics.export.signalfx.enabled=false"
)
"management.metrics.export.signalfx.enabled=false"
)
...
@@ -67,16 +74,6 @@ public class SignalFxMetricsExportAutoConfigurationTests {
...
@@ -67,16 +74,6 @@ public class SignalFxMetricsExportAutoConfigurationTests {
.
doesNotHaveBean
(
SignalFxConfig
.
class
));
.
doesNotHaveBean
(
SignalFxConfig
.
class
));
}
}
@Test
public
void
allowsClockToBeCustomized
()
{
this
.
runner
.
withPropertyValues
(
"management.metrics.export.signalfx.access-token=abcde"
)
.
withUserConfiguration
(
CustomClockConfiguration
.
class
)
.
run
((
context
)
->
assertThat
(
context
).
hasSingleBean
(
Clock
.
class
)
.
hasBean
(
"customClock"
));
}
@Test
@Test
public
void
allowsConfigToBeCustomized
()
{
public
void
allowsConfigToBeCustomized
()
{
this
.
runner
this
.
runner
...
@@ -101,7 +98,7 @@ public class SignalFxMetricsExportAutoConfigurationTests {
...
@@ -101,7 +98,7 @@ public class SignalFxMetricsExportAutoConfigurationTests {
}
}
@Configuration
@Configuration
static
class
CustomClock
Configuration
{
static
class
Base
Configuration
{
@Bean
@Bean
public
Clock
customClock
()
{
public
Clock
customClock
()
{
...
@@ -111,6 +108,7 @@ public class SignalFxMetricsExportAutoConfigurationTests {
...
@@ -111,6 +108,7 @@ public class SignalFxMetricsExportAutoConfigurationTests {
}
}
@Configuration
@Configuration
@Import
(
BaseConfiguration
.
class
)
static
class
CustomConfigConfiguration
{
static
class
CustomConfigConfiguration
{
@Bean
@Bean
...
@@ -131,6 +129,7 @@ public class SignalFxMetricsExportAutoConfigurationTests {
...
@@ -131,6 +129,7 @@ public class SignalFxMetricsExportAutoConfigurationTests {
}
}
@Configuration
@Configuration
@Import
(
BaseConfiguration
.
class
)
static
class
CustomRegistryConfiguration
{
static
class
CustomRegistryConfiguration
{
@Bean
@Bean
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment