Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in / Register
Toggle navigation
S
spring-boot
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
DEMO
spring-boot
Commits
b6e860b2
Commit
b6e860b2
authored
May 19, 2021
by
Andy Wilkinson
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Prevent Jetty from delaying shutdown beyond grace period
Fixes gh-22689
parent
2a89b11d
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
53 additions
and
2 deletions
+53
-2
JettyReactiveWebServerFactory.java
...oot/web/embedded/jetty/JettyReactiveWebServerFactory.java
+2
-1
JettyServletWebServerFactory.java
...boot/web/embedded/jetty/JettyServletWebServerFactory.java
+2
-1
AbstractReactiveWebServerFactoryTests.java
...eactive/server/AbstractReactiveWebServerFactoryTests.java
+24
-0
AbstractServletWebServerFactoryTests.java
.../servlet/server/AbstractServletWebServerFactoryTests.java
+25
-0
No files found.
spring-boot-project/spring-boot/src/main/java/org/springframework/boot/web/embedded/jetty/JettyReactiveWebServerFactory.java
View file @
b6e860b2
/*
/*
* Copyright 2012-202
0
the original author or authors.
* Copyright 2012-202
1
the original author or authors.
*
*
* Licensed under the Apache License, Version 2.0 (the "License");
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* you may not use this file except in compliance with the License.
...
@@ -169,6 +169,7 @@ public class JettyReactiveWebServerFactory extends AbstractReactiveWebServerFact
...
@@ -169,6 +169,7 @@ public class JettyReactiveWebServerFactory extends AbstractReactiveWebServerFact
InetSocketAddress
address
=
new
InetSocketAddress
(
getAddress
(),
port
);
InetSocketAddress
address
=
new
InetSocketAddress
(
getAddress
(),
port
);
Server
server
=
new
Server
(
getThreadPool
());
Server
server
=
new
Server
(
getThreadPool
());
server
.
addConnector
(
createConnector
(
address
,
server
));
server
.
addConnector
(
createConnector
(
address
,
server
));
server
.
setStopTimeout
(
0
);
ServletHolder
servletHolder
=
new
ServletHolder
(
servlet
);
ServletHolder
servletHolder
=
new
ServletHolder
(
servlet
);
servletHolder
.
setAsyncSupported
(
true
);
servletHolder
.
setAsyncSupported
(
true
);
ServletContextHandler
contextHandler
=
new
ServletContextHandler
(
server
,
"/"
,
false
,
false
);
ServletContextHandler
contextHandler
=
new
ServletContextHandler
(
server
,
"/"
,
false
,
false
);
...
...
spring-boot-project/spring-boot/src/main/java/org/springframework/boot/web/embedded/jetty/JettyServletWebServerFactory.java
View file @
b6e860b2
/*
/*
* Copyright 2012-202
0
the original author or authors.
* Copyright 2012-202
1
the original author or authors.
*
*
* Licensed under the Apache License, Version 2.0 (the "License");
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* you may not use this file except in compliance with the License.
...
@@ -165,6 +165,7 @@ public class JettyServletWebServerFactory extends AbstractServletWebServerFactor
...
@@ -165,6 +165,7 @@ public class JettyServletWebServerFactory extends AbstractServletWebServerFactor
private
Server
createServer
(
InetSocketAddress
address
)
{
private
Server
createServer
(
InetSocketAddress
address
)
{
Server
server
=
new
Server
(
getThreadPool
());
Server
server
=
new
Server
(
getThreadPool
());
server
.
setConnectors
(
new
Connector
[]
{
createConnector
(
address
,
server
)
});
server
.
setConnectors
(
new
Connector
[]
{
createConnector
(
address
,
server
)
});
server
.
setStopTimeout
(
0
);
return
server
;
return
server
;
}
}
...
...
spring-boot-project/spring-boot/src/test/java/org/springframework/boot/web/reactive/server/AbstractReactiveWebServerFactoryTests.java
View file @
b6e860b2
...
@@ -437,6 +437,30 @@ public abstract class AbstractReactiveWebServerFactoryTests {
...
@@ -437,6 +437,30 @@ public abstract class AbstractReactiveWebServerFactoryTests {
blockingHandler
.
completeOne
();
blockingHandler
.
completeOne
();
}
}
@Test
void
whenARequestIsActiveAfterGracefulShutdownEndsThenStopWillComplete
()
throws
InterruptedException
{
AbstractReactiveWebServerFactory
factory
=
getFactory
();
factory
.
setShutdown
(
Shutdown
.
GRACEFUL
);
BlockingHandler
blockingHandler
=
new
BlockingHandler
();
this
.
webServer
=
factory
.
getWebServer
(
blockingHandler
);
this
.
webServer
.
start
();
Mono
<
ResponseEntity
<
Void
>>
request
=
getWebClient
(
this
.
webServer
.
getPort
()).
build
().
get
().
retrieve
()
.
toBodilessEntity
();
AtomicReference
<
ResponseEntity
<
Void
>>
responseReference
=
new
AtomicReference
<>();
CountDownLatch
responseLatch
=
new
CountDownLatch
(
1
);
request
.
subscribe
((
response
)
->
{
responseReference
.
set
(
response
);
responseLatch
.
countDown
();
});
blockingHandler
.
awaitQueue
();
AtomicReference
<
GracefulShutdownResult
>
result
=
new
AtomicReference
<>();
this
.
webServer
.
shutDownGracefully
(
result:
:
set
);
this
.
webServer
.
stop
();
Awaitility
.
await
().
atMost
(
Duration
.
ofSeconds
(
30
))
.
until
(()
->
GracefulShutdownResult
.
REQUESTS_ACTIVE
==
result
.
get
());
blockingHandler
.
completeOne
();
}
@Test
@Test
void
whenARequestIsActiveThenStopWillComplete
()
throws
InterruptedException
,
BrokenBarrierException
{
void
whenARequestIsActiveThenStopWillComplete
()
throws
InterruptedException
,
BrokenBarrierException
{
AbstractReactiveWebServerFactory
factory
=
getFactory
();
AbstractReactiveWebServerFactory
factory
=
getFactory
();
...
...
spring-boot-project/spring-boot/src/test/java/org/springframework/boot/web/servlet/server/AbstractServletWebServerFactoryTests.java
View file @
b6e860b2
...
@@ -1119,6 +1119,31 @@ public abstract class AbstractServletWebServerFactoryTests {
...
@@ -1119,6 +1119,31 @@ public abstract class AbstractServletWebServerFactoryTests {
}
}
}
}
@Test
void
whenARequestIsActiveAfterGracefulShutdownEndsThenStopWillComplete
()
throws
InterruptedException
,
BrokenBarrierException
{
AbstractServletWebServerFactory
factory
=
getFactory
();
factory
.
setShutdown
(
Shutdown
.
GRACEFUL
);
BlockingServlet
blockingServlet
=
new
BlockingServlet
();
this
.
webServer
=
factory
.
getWebServer
((
context
)
->
context
.
addServlet
(
"blockingServlet"
,
blockingServlet
).
addMapping
(
"/"
));
this
.
webServer
.
start
();
int
port
=
this
.
webServer
.
getPort
();
initiateGetRequest
(
port
,
"/"
);
blockingServlet
.
awaitQueue
();
AtomicReference
<
GracefulShutdownResult
>
result
=
new
AtomicReference
<>();
this
.
webServer
.
shutDownGracefully
(
result:
:
set
);
this
.
webServer
.
stop
();
Awaitility
.
await
().
atMost
(
Duration
.
ofSeconds
(
30
))
.
until
(()
->
GracefulShutdownResult
.
REQUESTS_ACTIVE
==
result
.
get
());
try
{
blockingServlet
.
admitOne
();
}
catch
(
RuntimeException
ex
)
{
}
}
protected
Future
<
Object
>
initiateGetRequest
(
int
port
,
String
path
)
{
protected
Future
<
Object
>
initiateGetRequest
(
int
port
,
String
path
)
{
return
initiateGetRequest
(
HttpClients
.
createMinimal
(),
port
,
path
);
return
initiateGetRequest
(
HttpClients
.
createMinimal
(),
port
,
path
);
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment