Spring/spring-ai
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Adjust Oracle Vector store class names

Browse Source
This commit is contained in:
Christian Tzolov
2024-06-14 06:55:54 +02:00
parent 41cf693bc0
commit a5d92ec30f
3 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
vector-stores/spring-ai-oracle-store/src/main/java/org/springframework/ai/vectorstore/OracleVectorStore.java
View File

@@ -178,7 +178,7 @@ public class OracleVectorStore implements VectorStore, InitializingBean {
private final boolean removeExistingVectorStoreTable;
public final FilterExpressionConverter filterExpressionConverter = new IsoSqlJsonPathFilterExpressionConverter();
public final FilterExpressionConverter filterExpressionConverter = new SqlJsonPathFilterExpressionConverter();
/**
* Table name where vectors will be stored.

2
vector-stores/spring-ai-oracle-store/src/main/java/org/springframework/ai/vectorstore/ISOSQLJSONPathFilterExpressionConverter.java → vector-stores/spring-ai-oracle-store/src/main/java/org/springframework/ai/vectorstore/SqlJsonPathFilterExpressionConverter.java
View File

@@ -9,7 +9,7 @@ import org.springframework.ai.vectorstore.filter.converter.AbstractFilterExpress
* "https://docs.oracle.com/en/database/oracle/oracle-database/23/adjsn/json-path-expressions.html#GUID-8656CAB9-C293-4A99-BB62-F38F3CFC4C13">JSON
* Path Documentation</a>
*/
public class IsoSqlJsonPathFilterExpressionConverter extends AbstractFilterExpressionConverter {
public class SqlJsonPathFilterExpressionConverter extends AbstractFilterExpressionConverter {
@Override
protected String convertOperand(final Filter.Operand operand) {

6
vector-stores/spring-ai-oracle-store/src/test/java/org/springframework/ai/vectorstore/IsoSqlJsonPathFilterExpressionConverterTests.java → vector-stores/spring-ai-oracle-store/src/test/java/org/springframework/ai/vectorstore/SqlJsonPathFilterExpressionConverterTests.java
View File

@@ -6,13 +6,13 @@ import org.junit.jupiter.api.Test;
import org.springframework.ai.vectorstore.filter.Filter;
import org.springframework.ai.vectorstore.filter.FilterExpressionTextParser;
public class IsoSqlJsonPathFilterExpressionConverterTests {
public class SqlJsonPathFilterExpressionConverterTests {
@Test
public void testNIN() {
final Filter.Expression e = new FilterExpressionTextParser().parse("weather nin [\"windy\", \"rainy\"]");
final String jsonPathExpression = new IsoSqlJsonPathFilterExpressionConverter().convertExpression(e);
final String jsonPathExpression = new SqlJsonPathFilterExpressionConverter().convertExpression(e);
assertThat(jsonPathExpression).isEqualTo("$?( !( @.weather in ( \"windy\",\"rainy\" ) ) )");
}
@@ -21,7 +21,7 @@ public class IsoSqlJsonPathFilterExpressionConverterTests {
public void testNOT() {
final Filter.Expression e = new FilterExpressionTextParser().parse("NOT( weather in [\"windy\", \"rainy\"] )");
final String jsonPathExpression = new IsoSqlJsonPathFilterExpressionConverter().convertExpression(e);
final String jsonPathExpression = new SqlJsonPathFilterExpressionConverter().convertExpression(e);
assertThat(jsonPathExpression).isEqualTo("$?( (!( @.weather in ( \"windy\",\"rainy\" ) )) )");
}