Mock setup for connection creation in 4 tests was not
updated for AMQP-225 changes (external executor).
Listener connection retry did not check for a
closed channel.
AMQP-231 More Spurious Integration Test Failures
RabbitBindingIntegrationTests Issues
* Asserting notNull on consumer tag before it might have been returned
by the broker.
* Calling basicCancel() on the wrong channel - the rabbit 2.5.0
client sent the cancel to the broker anyhow; the newer clients
check whether the tag is for a known consumer and throw an
exception if not. The Test cases were calling basicCancel() on
the sending channel instead of the consuming channel.
MessageListenerContainerLifecycleIntegrationTests did not
wait long enough for the listener's consumer to terminate.
Remove explicit mention of default exchange if key is not provided.
However, considering that no-key is still a valid option, and would result in binding to the default exchange
we may want to consider making 'key' a required field on the directExchange binding while also stating that
if you want the default binding than you should not have a <binding> defined in the first place.
it might help if I added the files to git
fixed for maps
removed bad import
removed ClassMapper
formatted code after importing eclipse-code-formatter.xml
formatted test code
added author tag
Reinstated the ClassMapper interface, Renamed DefaultJavaTypeMapper to DefaultClassMapper, DefaultClassMapper now implements ClassMapper and JavaTypeMapper interfaces, Moade TypeFactory imports static.
Reverted DefaultClassMapper. Moved DefaultJavaTypeMapper back.
added missing type mapper classes
Implemented backward compatibility with ClassMapper
The BindingFactoryBean already supported exchange to exchange
binding. Add namespace support; remove 'required' from queue
attribute in XSD; add 'exchange' (optional) and enforce XOR
in parser.
Builds on parser refactoring for Federated Exchange.
Tested with a real broker with the amqp-sample.
<rabbit:direct-exchange name="si.test.exchange">
<rabbit:bindings>
<rabbit:binding queue="si.test.queue" key="si.test.binding" />
</rabbit:bindings>
</rabbit:direct-exchange>
<rabbit:direct-exchange name="si.test.exchange2">
<rabbit:bindings>
<rabbit:binding exchange="si.test.exchange" key="si.test.binding" />
</rabbit:bindings>
</rabbit:direct-exchange>
Initial commit - schema, parser, parser tests,
integration tests.
TODO: doc.
Note: Federated exchanges need some hard config
on the server. The test cases use this
[
{rabbitmq_federation,
[
{upstream_sets, [{"upstream-set", [[{connection, "upstream-server"} ]]}
]},
{connections, [{"upstream-server", [{host, "somehost"}]}
]}
]
}
].
If not available, the tests will be ignored.
AMQP-215 Reference Documentation
Add information about federated exchanges.
AMQP-215 Polishing - remove test exchanges.
Previously, convertAndSend(), convertSendAndReceive() methods
"converted" an Object that was already a Message to a Message
with a null body.
Now, if the object is already a Message, no conversion is
performed.
Initial Commit
Add support for multiple acks in one call.
AMQP-213 Polishing
Move confirmation state to PublisherCallbackChannel. Allows
the RabbitTemplate to handle confirms from multiple
channels.
Remove unnecessary synchronization.
Add tests for multiple threads - verifying the
functionality when more than one thread concurrently
uses the template.
NOTES: The CF cache size must be large enough
to cover the number of required channels - otherwise
the channel is closed before the confirms are received.
This could be alleviated by not closing channels if
P.C. are turned on.
Each PublisherCallbackConnection has two maps, the
first map (seqToListener) identifies which listener
gets the confirmation. The second map (pendingConfirms)
is a map of maps where the key is the listener and
the value is a map of pending confirms for that
listener. This map is given back to the listener
when registering.
In this way, the Rabbit template does not need to
hold a reference to every connection he has used.
Instead, when a connection is closed, the listener
is informed via a call to removePendingConfirmsReference().
The listener uses the pending confirms maps to
determine if any confirms have expired.
Add test for two templates sharing the same
factory, ensuring the appropriate template
gets the confirmation.
AMQP-213 Polishing
AMQP-213 Add Support for Basic.Return
The rabbit template will be registered to receive return
messages if it is provided with a ReturnCallback. Either
mandatory or immediate must also be set for returns.
mandator and immediate are ignored if no callback is provided.
AMQP-213 Polishing
The RabbitTemplate can only support one each of
ConfirmCallback and ReturnCallback because there
is no way to correlate back to the caller.
In situations where more than one client is needed,
each needs its own RabbitTemplate.
The connection factory, and hence the connection and
channels, can be shared across templates.
AMQP-213 Add Namespace Support for Returns
Attributes added to template for mandatory, immediate,
return-callback.
Also confirm-callback for confirms.
AMQP-213 Return Reply Code Etc
Pass the reply code, reply text, exchange, and
routing key back to the client on returns.
AMQP-213 Polishing
Fix non-default exchange on convertAndSend.
AMQP-213 Polishing PR Review
- Configure a list of addresses in ConnectionFactory
- Allow arguments (e.g. HA) for temporary reply queue creation
AMQP-206 Add queue-arguments Attribute
<queue/> now supports either <queue-arguments /> element
or a queue-arguments attribute which is a reference to
a <queue-arguments /> bean.
<queue-arguments /> is promoted to a top-level bean,
allowing for re-use, such as...
<rabbit:queue-arguments id="haArgs">
<entry key="x-ha-policy" value="all" />
</rabbit:queue-arguments>
<rabbit:queue name="si.test.queue" queue-arguments="haArgs" />
AMQP-206 Fix Parser Tests
AMQP-206 ReConnect To Mirrored Queue
If a consumer is connected to a mirror (slave), and the
master dies, the queue is moved. The consumer is given a
cancel notification, indicating we need to reconnect.
However, the move might not be complete, so we retry the
queue declaration a number of times before failing.
AMQP-206 Polishing
Cleanup retry counter name; trap exception on cancel of
temporary reply queue.
AMQP-206 Add reply-queue to RabbitTemplate
Allow specification of an explicit queue for replies. Adds
a correlation header to sendAndReceive messages (spring_reply_correlation)
which is used to correlate replies on the reply queue.
The queue is supplied to the template via the reply-queue
attribute; the template must be added as a <listener/> to a
<listener-container/> for the same queue. For example...
<rabbit:template id="amqpTemplate" connection-factory="connectionFactory" reply-queue="si.test.replies" />
<rabbit:listener-container id="replyContainer" connection-factory="connectionFactory" task-executor="reply-exec">
<rabbit:listener ref="amqpTemplate" queues="si.test.replies"/>
</rabbit:listener-container>
<rabbit:queue name="si.test.replies" queue-arguments="haArgs" />
AMQP-206 Stack Reply Correlation
Stacks (pushes/pops) correlation when using a fixed queue for
replies in sendAndReceive methods.
Now supports
templatsendAndReceive()->listener->templateSendAndReceive()->
listener->templateSendAndReceive->...
and the replies get correlated in each template appropriately.
AMQP-206 Polishing
Add exclusive test for addresses attribute; add parser test.
AMQP-206 Polishing
Improve configuration of reply-queue listener on rabbit template.
Previously a disjoint listener was required. Now the listener
is a child element of the template itself.
<rabbit:template id="withReplyQ" connection-factory="connectionFactory" reply-queue="reply.queue">
<rabbit:reply-listener />
</rabbit:template>
The reply-listener is a full-blown listener container, but uses the
template's connection factory and so that attribute, as well as the
message-converter is disallowed at run-time.
AMQP-206 Polishing
Remove disallowed attributes from <retry-listener/> child element
in schema.
AMQP-206 Reference Documentation
Update docs with addresses attribute on ConnectionFactory and
reply-queue on template.
If no ExecutorService is provided when creating a new
connection, Rabbit uses a default fixed thread pool
executor with 5 threads.
You can now specify an executor on the
<rabbit:connection-factory/>.
Due to limitations in the Rabbit API,
this must either reference a ExecutorService (such as
one returned by Executors.new...Executor() methods, or
a Spring ThreadPoolTaskExecutor, such as one defined
using the <task:executor/> element.
The underlying API (newConnection()) with no arg
calls (newConnection(null)), so it is safe to
always use newConnection(exec), and not test for
null.
https://jira.springsource.org/browse/AMQP-208
Don't attempt to declare
the default exchange or bindings to it in RabbitAdmin.
Applied same logic to delete exchange and remove binding.
Refined existing auto delete queue tests to enable re-use of
native checking to see if queue exists and correct intent in names.
Support DLQ - the listener must throw an AmqpRejectAndDontRequeueException
and this will send a basic.reject with requeue false (instead of the
default true).
There is an issue with Rabbit DLQ handling with durable queues so,
currently, this only works when dead-lettering messages sent to
non-durable queues.
DLQ Polishing - Add Unit Tests
DLQ Polish Tests
AMQP-221 Add Option for Default Requeue Behavior
Previously, the default requeue behavior was true, with the
ability to override for a specific message by throwing an
AmqpRejectAndDontRequeueException.
However, as posted in a PR review, it is desirable to set
the default behavior using a property on the listener
container.
Now, by setting requeueRejected to false (default=true),
the default becomes false.
When true, the default can still be overriden for a specific
message as described above.
