Spring/spring-authorization-server
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Unsupported code_challenge_method parameter should return invalid_grant

Browse Source 
Issue gh-770
This commit is contained in:
Joe Grandja
2022-06-15 09:24:42 -04:00
parent 7dfdcf3a27
commit 4199ab0172
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
oauth2-authorization-server/src/main/java/org/springframework/security/oauth2/server/authorization/authentication/CodeVerifierAuthenticator.java
View File

@@ -122,9 +122,10 @@ final class CodeVerifierAuthenticator {
} catch (NoSuchAlgorithmException ex) {
// It is unlikely that SHA-256 is not available on the server. If it is not available,
// there will likely be bigger issues as well. We default to SERVER_ERROR.
throw new OAuth2AuthenticationException(OAuth2ErrorCodes.SERVER_ERROR);
}
}
throw new OAuth2AuthenticationException(OAuth2ErrorCodes.SERVER_ERROR);
return false;
}
private static void throwInvalidGrant(String parameterName) {

2
oauth2-authorization-server/src/test/java/org/springframework/security/oauth2/server/authorization/authentication/PublicClientAuthenticationProviderTests.java
View File

@@ -275,7 +275,7 @@ public class PublicClientAuthenticationProviderTests {
.isInstanceOf(OAuth2AuthenticationException.class)
.extracting(ex -> ((OAuth2AuthenticationException) ex).getError())
.extracting("errorCode")
.isEqualTo(OAuth2ErrorCodes.SERVER_ERROR);
.isEqualTo(OAuth2ErrorCodes.INVALID_GRANT);
}
private static Map<String, Object> createAuthorizationCodeTokenParameters() {