Spring/spring-batch
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Polish date converters

Browse Source
This commit is contained in:
Mahmoud Ben Hassine
2023-02-15 23:46:03 +01:00
parent 7ecac1c2ff
commit 30563cd25c
5 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
spring-batch-core/src/main/java/org/springframework/batch/core/converter/AbstractDateConverter.java → spring-batch-core/src/main/java/org/springframework/batch/core/converter/AbstractDateTimeConverter.java
View File

@@ -18,12 +18,14 @@ package org.springframework.batch.core.converter;
import java.time.format.DateTimeFormatter;
/**
* Base class for {@link java.util.Date} converters.
* Base class for date/time converters.
*
* @author Mahmoud Ben Hassine
* @since 5.0.1
*/
public class AbstractDateConverter {
class AbstractDateTimeConverter {
protected DateTimeFormatter instantFormatter = DateTimeFormatter.ISO_INSTANT;
protected DateTimeFormatter dateTimeFormatter = DateTimeFormatter.ISO_INSTANT;

4
spring-batch-core/src/main/java/org/springframework/batch/core/converter/DateToStringConverter.java
View File

@@ -28,11 +28,11 @@ import org.springframework.core.convert.converter.Converter;
* @author Mahmoud Ben Hassine
* @since 5.0.1
*/
public class DateToStringConverter extends AbstractDateConverter implements Converter<Date, String> {
public class DateToStringConverter extends AbstractDateTimeConverter implements Converter<Date, String> {
@Override
public String convert(Date source) {
return super.dateTimeFormatter.format(source.toInstant());
return super.instantFormatter.format(source.toInstant());
}
}

4
spring-batch-core/src/main/java/org/springframework/batch/core/converter/StringToDateConverter.java
View File

@@ -29,11 +29,11 @@ import org.springframework.core.convert.converter.Converter;
* @author Mahmoud Ben Hassine
* @since 5.0.1
*/
public class StringToDateConverter extends AbstractDateConverter implements Converter<String, Date> {
public class StringToDateConverter extends AbstractDateTimeConverter implements Converter<String, Date> {
@Override
public Date convert(String source) {
return Date.from(super.dateTimeFormatter.parse(source, Instant::from));
return Date.from(super.instantFormatter.parse(source, Instant::from));
}
}

2
spring-batch-core/src/test/java/org/springframework/batch/core/converter/DateToStringConverterTest.java → spring-batch-core/src/test/java/org/springframework/batch/core/converter/DateToStringConverterTests.java
View File

@@ -26,7 +26,7 @@ import org.junit.jupiter.api.Test;
*
* @author Mahmoud Ben Hassine
*/
class DateToStringConverterTest {
class DateToStringConverterTests {
private final DateToStringConverter converter = new DateToStringConverter();

2
spring-batch-core/src/test/java/org/springframework/batch/core/converter/StringToDateConverterTest.java → spring-batch-core/src/test/java/org/springframework/batch/core/converter/StringToDateConverterTests.java
View File

@@ -26,7 +26,7 @@ import org.junit.jupiter.api.Test;
*
* @author Mahmoud Ben Hassine
*/
class StringToDateConverterTest {
class StringToDateConverterTests {
private final StringToDateConverter converter = new StringToDateConverter();