Spring/spring-batch
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

REOPENED - BATCH-996: use default retryLimit == 1 (not 0) in *StepFactoryBean

Browse Source 
revert back to default 0
This commit is contained in:
robokaso
2009-01-29 13:55:06 +00:00
parent efda06ec85
commit 37f88ddab0
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
spring-batch-core/src/main/java/org/springframework/batch/core/step/item/SkipLimitStepFactoryBean.java
View File

@@ -31,7 +31,6 @@ import org.springframework.batch.retry.policy.RecoveryCallbackRetryPolicy;
import org.springframework.batch.retry.policy.SimpleRetryPolicy;
import org.springframework.batch.retry.support.RetryTemplate;
import org.springframework.batch.support.SubclassExceptionClassifier;
import org.springframework.util.Assert;
/**
* Factory bean for step that provides options for configuring skip behavior.
@@ -64,7 +63,7 @@ public class SkipLimitStepFactoryBean extends SimpleStepFactoryBean {
private int cacheCapacity = 0;
private int retryLimit = 1;
private int retryLimit = 0;
private Class[] retryableExceptionClasses = new Class[] {};
@@ -93,7 +92,6 @@ public class SkipLimitStepFactoryBean extends SimpleStepFactoryBean {
* @param retryLimit the retry limit to set
*/
public void setRetryLimit(int retryLimit) {
Assert.isTrue(retryLimit >= 1, "retry limit must be greater or equal to 1");
this.retryLimit = retryLimit;
}
@@ -202,7 +200,7 @@ public class SkipLimitStepFactoryBean extends SimpleStepFactoryBean {
protected void applyConfiguration(ItemOrientedStep step) {
super.applyConfiguration(step);
if (retryLimit > 1 || skipLimit > 0 || retryPolicy != null) {
if (retryLimit > 0 || skipLimit > 0 || retryPolicy != null) {
addFatalExceptionIfMissing(SkipLimitExceededException.class);
addFatalExceptionIfMissing(NonSkippableException.class);